fix(tracing): isolate trace summary rendering failures - #7682
wangtaotaotao95 wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe trace link renderer now catches console errors, logs the exception type, and allows execution cleanup to continue. A test verifies that a ChangesTrace link resilience
Suggested reviewers: Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Trace-link display failures no longer fail otherwise successful executions, while trace export continues. The change is mergeable. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes #7681.
Trace export can succeed and then fail the enclosing crew/flow during cleanup if Rich cannot render the post-export summary. This keeps that presentation step best-effort:
BrokenPipeErrorcannot escapeend_execution()after a successful upload.Verification
lib/crewai/tests/telemetry/test_session_trace_export.py: 81 passedgit diff --check: passedThis contribution was prepared with AI assistance. I do not have permission to apply the repository's
llm-generatedlabel; a maintainer will need to add it.