Repository navigation
fix(feed): use the source feed name on source pages and restore squad feed gating - #6733
Merged
Merged
Conversation
… feed gating a39b27f (#2289) replaced the source page's `feedName="source"` literal with `OtherFeedPage.Squad` instead of `OtherFeedPage.Source`. Since #3608 renamed that value to `squadsdiscover`, source page clicks, impressions and scroll events were attributed to the squads directory, the post modal carried `pmcid=squadsdiscover`, and the page skipped the hero cards that `HERO_ELIGIBLE_FEEDS` enables for `OtherFeedPage.Source`. It also meant the source page was the only feed hitting `isSquadFeed`: #4710 moved the squad page to `OtherFeedPage.Squads`, so the squad-only ad start and the first-slot `adPostLength` gate from #6456 never reached squad pages. `isSquadFeed` now compares against `OtherFeedPage.Squads`, and the Feed spec squad tests use the real squad feed name so they guard it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
OtherFeedPage.Source(source) instead ofOtherFeedPage.Squad(squadsdiscover). The swap came in with feat: search squad members #2289, which mapped the old"source"literal to the wrong enum member.isSquadFeedinFeed.tsxnow compares againstOtherFeedPage.Squads(squads[handle]), the name the squad page has used since feat: squad list view #4710. Before this, the source page was the only feed that matched it, so squad pages never got the squad ad start or the first-slotadPostLengthgate added in feat: unify first-slot CTAs, fix ad-slot displacement + placement math #6456.OtherFeedPage.Squads. Against the old comparison,holds the marketing CTA on squad feeds until enough posts loadfails.feed: 'source'(fails withsquadsdiscoverbefore the fix).Behavior changes:
extra.feedbecomessource, post modalpmcid=source, hero cards become eligible (OtherFeedPage.Sourceis inHERO_ELIGIBLE_FEEDS), and it uses the regular ad template instead of the squad overrides. The feed query key (sourceFeed) is unchanged.adStart: 2and the first-slot card waits for more than 2 posts, as feat: unify first-slot CTAs, fix ad-slot displacement + placement math #6456 intended.Events
No new events. The
feedvalue on existing source page feed events changes fromsquadsdiscovertosource, so squads directory numbers no longer include source page traffic.Experiment
No.
Preview domain
https://claude-mystifying-wright-3ed4b2.preview.app.daily.dev