Conversation
checkHookInterpreters demands a #! shebang from every hook command that is given as a path. A compiled executable (e.g. iTerm2's Mach-O cc-status status-line helper registered as a hook) has no shebang, so Doctor reported it as broken even though exec() runs it fine. Sniff the first four bytes for an ELF / Mach-O / fat header and skip the shebang check for those. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017w3q9FbuWxcW9fmh8G39NK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
checkHookInterpretersinLIFEOS/TOOLS/Doctor.tsrequires a#!shebang from every hook command given as a path. A compiled executable registered as a hook has no shebang, soDoctor --hooksflags it as broken:Concrete case: iTerm2's
~/.config/iterm2/cc-status(a Mach-O binary) wired as a status-line/hook command.exec()runs it without issue; only scripts need an interpreter line.Fix
Read the first four bytes of the resolved file and skip the shebang check when they are an ELF, Mach-O (32/64, either byte order) or fat/universal header. Everything else keeps the existing path (mode check, shebang check, interpreter lookup).
Verification
bun LIFEOS/TOOLS/Doctor.ts --hookson an install with the iTerm2 binary hook:hook interpreters: every registered hook resolves ✅(wasneeds attentionbefore).no #! shebang.🤖 Generated with Claude Code
https://claude.ai/code/session_017w3q9FbuWxcW9fmh8G39NK