Skip to content

Introduce "qsendrecsigs" to indicate that plain recovered sigs should be sent - #2783

Merged
codablock merged 2 commits into
dashpay:developfrom
codablock:pr_llmq_sendrecsigs
Mar 21, 2019
Merged

codablock merged 2 commits into
dashpay:developfrom
codablock:pr_llmq_sendrecsigs

Conversation

@codablock

Copy link
Copy Markdown

This avoids sending unnecessary data to SPV clients and other node implementations that don't know how to deal with qrecsig.

@codablock codablock added this to the 14.0 milestone Mar 20, 2019
UdjinM6
UdjinM6 previously approved these changes Mar 20, 2019

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

… be sent

Full nodes, including masternodes, will send this message automatically.
Other node implementations (e.g. SPV) are usually not interested and would
not send this message.
Not related to this PR, but a small enough change to include it here as
well.
@codablock

Copy link
Copy Markdown
Author

There was a typo (vRect) that caused builds to fail. Fixed this now.

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK :)

@UdjinM6 UdjinM6 added the P2P Some notable changes on p2p level label Mar 20, 2019
@codablock
codablock merged commit 12274e5 into dashpay:develop Mar 21, 2019
@codablock
codablock deleted the pr_llmq_sendrecsigs branch March 21, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2P Some notable changes on p2p level

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants