Skip to content

Fix revoke reason check for ProUpRevTx - #2787

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
gladcow:typo
Mar 21, 2019
Merged

UdjinM6 merged 1 commit into
dashpay:developfrom
gladcow:typo

Conversation

@gladcow

@gladcow gladcow commented Mar 20, 2019

Copy link
Copy Markdown

CProUpRevTx::REASON_LAST is equal to last valid reason (CProUpRevTx::REASON_CHANGE_OF_KEYS), and that's why it is valid too.

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Mar 20, 2019

@codablock codablock left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Also adding the backports label for v13 Udjin was faster :)

@UdjinM6
UdjinM6 merged commit 7135f01 into dashpay:develop Mar 21, 2019
codablock pushed a commit to codablock/dash that referenced this pull request Apr 4, 2019
@snogcel

snogcel commented May 25, 2024

Copy link
Copy Markdown

utACK

Might be worth taking a second look at?

@snogcel

snogcel commented May 25, 2024

Copy link
Copy Markdown

@snogcel

snogcel commented May 25, 2024

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants