Skip to content

Bump MAX_OUTBOUND_MASTERNODE_CONNECTIONS to 250 on masternodes - #2791

Merged
UdjinM6 merged 3 commits into
dashpay:developfrom
codablock:pr_llmq_maxoutbound
Mar 21, 2019
Merged

UdjinM6 merged 3 commits into
dashpay:developfrom
codablock:pr_llmq_maxoutbound

Conversation

@codablock

@codablock codablock commented Mar 21, 2019 •

Copy link
Copy Markdown

Masternodes now need to connect to much more other MNs due to the intra-quorum communication.

250 is a very conservative value loosely based on the absolute worst-case number of outgoing connections required, assuming that a MN manages to become part of all 24 active LLMQs.

250 might sound a lot, but in reality the chance of a MN being part of any single LLMQ is pretty low. For a quorum size of 50 and total number of 4500 masternodes, the chance is 1.11% to be part of a new LLMQ. Assuming we have 24 active LLMQs and the current DKG, we have a total chance of 27.77% to be part of any LLMQ at any time. Being a member of one LLMQ requires 5 outgoing connections. Being part of 2 LLMQs has a chance of 7.7%. For 4 LLMQs it's down to 0.5%, and so on. Even if you're extremely un-/lucky to be part of 10 LLMQs (chance of 0.0002%), you'd only have 50 extra connections so far (which any decent VPS should be able to handle).

@codablock codablock added this to the 14.0 milestone Mar 21, 2019
UdjinM6
UdjinM6 previously approved these changes Mar 21, 2019

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock

Copy link
Copy Markdown
Author

There was an infinite loop in CConnman::Interrupt which caused tests to fail. Fixed this now.

Comment thread src/net.cpp Resolved
Masternodes now need to connect to much more other MNs due to the intra-quorum
communication.

250 is a very conservative value loosely based on the absolute worst-case
number of outgoing connections required, assuming that a MN manages to
become part of all 24 active LLMQs.
@codablock
codablock force-pushed the pr_llmq_maxoutbound branch from 483cbb5 to 1108a0e Compare March 21, 2019 16:44
Co-Authored-By: codablock <ablock84@gmail.com>

@UdjinM6 UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@UdjinM6
UdjinM6 merged commit 071b60d into dashpay:develop Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants