Repository navigation
Bump MAX_OUTBOUND_MASTERNODE_CONNECTIONS to 250 on masternodes - #2791
Merged
Merged
Conversation
Author
|
There was an infinite loop in |
UdjinM6
reviewed
Mar 21, 2019
Masternodes now need to connect to much more other MNs due to the intra-quorum communication. 250 is a very conservative value loosely based on the absolute worst-case number of outgoing connections required, assuming that a MN manages to become part of all 24 active LLMQs.
codablock
force-pushed
the
pr_llmq_maxoutbound
branch
from
March 21, 2019 16:44
483cbb5 to
1108a0e
Compare
Co-Authored-By: codablock <ablock84@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Masternodes now need to connect to much more other MNs due to the intra-quorum communication.
250 is a very conservative value loosely based on the absolute worst-case number of outgoing connections required, assuming that a MN manages to become part of all 24 active LLMQs.
250 might sound a lot, but in reality the chance of a MN being part of any single LLMQ is pretty low. For a quorum size of 50 and total number of 4500 masternodes, the chance is 1.11% to be part of a new LLMQ. Assuming we have 24 active LLMQs and the current DKG, we have a total chance of 27.77% to be part of any LLMQ at any time. Being a member of one LLMQ requires 5 outgoing connections. Being part of 2 LLMQs has a chance of 7.7%. For 4 LLMQs it's down to 0.5%, and so on. Even if you're extremely un-/lucky to be part of 10 LLMQs (chance of 0.0002%), you'd only have 50 extra connections so far (which any decent VPS should be able to handle).