Skip to content

fix: sign sporks over their serialized fields and stop using sporks on mainnet - #7847

Merged
PastaPastaPasta merged 3 commits into
dashpay:developfrom
PastaPastaPasta:codex/security-devnet-typed-spork-signatures
Oct 9, 2026
Merged

PastaPastaPasta merged 3 commits into
dashpay:developfrom
PastaPastaPasta:codex/security-devnet-typed-spork-signatures

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Outside testnet, a spork signature covers the decimal text of the spork id, value and signing time concatenated with no separator. Different field values can produce the same text. For example, id 10020, value 1, time 1791370200 and id 10020, value 11, time 791370200 both sign 100201791370200. A peer can take a genuine signed spork, re-split its fields and relay it. A node that has not yet seen the original (or a newer) spork accepts the altered value. The older time doesn't help, because validation only rejects times too far in the future.

This matters on devnets, where SPORK_21_QUORUM_ALL_CONNECTED and similar sporks compare against exact values. Testnet already signs the serialized fields (CSporkMessage::GetSignatureHash).

An earlier version of this PR added a devnet opt-in option. It is simpler to make the typed format the only one:

  • Devnet nodes all run the same version, so a devnet can switch at once.
  • Regtest's spork key is public anyway.
  • Mainnet spork values have been fixed in GetSporkValue since v22, so received sporks already have no effect there.

Changing the format on mainnet would still break relay: upgraded nodes ask peers for sporks with getsporks, and older peers answer with sporks in the old format. The upgraded node would score each of those peers 100. So mainnet stops handling sporks entirely.

What was done?

  • Mainnet stops handling sporks. It does not send getsporks during sync and never requests announced sporks. It ignores spork and getsporks messages without scoring the peer, and sporkupdate returns an error. The inventory benchmark announces sporks, so it now runs on regtest.
  • Typed signatures are the only format. CSporkMessage::Sign and CheckSignature always sign and verify GetSignatureHash(). The legacy text-message path and the stale "Harden Spork6" comments are removed.
  • doc/release-notes-7847.md describes both changes.

When sporks.dat loads, CSporkManager::LoadCache calls CheckAndRemove, which re-checks each cached signature. Sporks cached in the old format are dropped and defaults apply until the signer re-issues them.

How Has This Been Tested?

macOS arm64, depends build.

  • spork_tests/spork_signature_binds_value_and_time (regtest, which used the old format before this change): a spork signed as id 10020, value 1, time 1791370200 verifies, and the same signature with value 11, time 791370200 is rejected.
  • net_tests/mainnet_ignores_sporks: on mainnet, an announced spork is not requested, and an incoming spork that doesn't verify leaves the sender's misbehavior score at 0.
  • Both new tests fail with src/spork.cpp and src/net_processing.cpp reverted to develop: the reinterpreted spork verifies, the mainnet spork is requested, and the sender is scored 100. Both pass with this change.
  • Unit suites spork_tests, net_tests, interfaces_tests and denialofservice_tests pass.
  • Functional tests feature_sporks.py, feature_llmq_signing.py and feature_llmq_signing.py --spork21 pass.
  • The InventoryBatch benchmarks run on regtest.
  • git diff --check and the whitespace, include and circular-dependency lints are clean. check-doc.py reports only -statsport and -printcrashinfo, which already fail on develop.

Breaking Changes

  • Devnets: every node and the spork signer must upgrade together. Older nodes reject sporks in the new format and penalize the peer that sends them. Spork values return to defaults until the signer re-issues them.
  • Mainnet: upgraded nodes no longer serve sporks. Light clients that read spork values from mainnet peers stop receiving them from upgraded nodes. dash-spv (rust-dashcore) and dashwallet-ios don't use sporks. dashj does, and is being replaced by the dash-spv-based clients.
  • sporkupdate returns an error on mainnet.
  • Test fixtures: pre-generated regtest datadirs with sporks cached in the old format lose them on startup. For example, rust-dashcore's integration tests use dashpay/regtest-blockchain data that relies on cached SPORK_2/17/19. When they move to a dashd with this change, their setup needs to re-issue those sporks with sporkupdate, or the data needs regenerating.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 947a566f-4500-4cdc-b18a-7f750609f381
📥 Commits

Reviewing files that changed from the base of the PR and between e333d5b and 302a3fe.

📒 Files selected for processing (9)
  • doc/release-notes-7847.md
  • src/bench/net_processing.cpp
  • src/init.cpp
  • src/net_processing.cpp
  • src/node/sync_manager.cpp
  • src/rpc/node.cpp
  • src/spork.cpp
  • src/test/net_tests.cpp
  • src/test/spork_tests.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

Sporks now use signature hashes for signing and verification on every network. Nodes outside test chains do not request or process spork messages, and the sporkupdate RPC rejects requests. Tests cover signature tampering and mainnet handling of spork messages.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 302a3

Sporks now use a stronger signature format on all networks, and mainnet nodes stop handling sporks. Devnet operators must upgrade all nodes and signers together, as the release notes describe. No blocking issues remain.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 11.76% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 10 files. (1 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly summarizes the two main changes: typed spork signatures and disabling sporks on mainnet.
Description check Passed The description is directly related to the changeset and explains the signature-format change, mainnet behavior, testing, and breaking changes.
Full details: Docstring Coverage

Explanation

Docstring coverage is 11.76% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 10 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit 302a3fe) · triage: normal

@PastaPastaPasta PastaPastaPasta changed the title feat(spork): let devnets opt in to typed spork signatures feat: let devnets opt in to typed spork signatures Oct 7, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

Static verification of be348fe found no implementation defects: signing and verification consistently select the configured encoding, existing network defaults are preserved, and cache loading revalidates signatures. The PR title does fail the repository's required title convention and needs a metadata-only correction. No builds or tests were run in this lane; the supplied CI snapshot still has container builds queued.

🔴 1 blocking

1 finding(s) not shown inline (the lines are not part of this PR's diff)

🔴 Blocking: PR title scope 'spork' fails the semantic-pull-request CI check
.github/workflows/semantic-pull-request.yml:39-52

The title feat(spork): let devnets opt in to typed spork signatures uses a scope absent from this workflow's allowed list. The failed log for Actions run 37597393828 explicitly reports Unknown scope "spork", confirming the supplied CI failure. The project requires PR titles to satisfy this workflow. Rename the PR to feat: let devnets opt in to typed spork signatures, or use an allowed scope; the workflow does not require a scope. This requires only a PR-title edit, not a change to the workflow or implementation.

source: glm-5.3-flash (phase1-reviewer: general)

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — The diff adds a small, explicit devnet opt-in and substitutes a chain-parameter selector in spork signing and verification, with focused tests; it is well-contained rather than large or intricate despite touching signatures.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 80% left, weekly 92% left; passed over gemini-3.8-flash-high (antigravity below 15% reserve: weekly 15% left, 5h 100% left)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort medium); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `.github/workflows/semantic-pull-request.yml`:
- [BLOCKING] .github/workflows/semantic-pull-request.yml:39-52: PR title scope 'spork' fails the semantic-pull-request CI check
  The title `feat(spork): let devnets opt in to typed spork signatures` uses a scope absent from this workflow's allowed list. The failed log for Actions run 37597393828 explicitly reports `Unknown scope "spork"`, confirming the supplied CI failure. The project requires PR titles to satisfy this workflow. Rename the PR to `feat: let devnets opt in to typed spork signatures`, or use an allowed scope; the workflow does not require a scope. This requires only a PR-title edit, not a change to the workflow or implementation.
Out-of-scope follow-up suggestions (1)

These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.

  • Fix pre-existing check-doc.py failures for -statsport and -printcrashinfo on develop — Routine pre-existing lint cleanup outside this PR's scope. Both options are already registered as hidden arguments in the base commit's src/init.cpp, while check-doc.py recognizes literal AddArg registrations rather than these hidden-argument entries. This PR neither introduces nor worsens that mismatch, and it does not warrant an exceptional maintainer follow-up in this review.
    • Follow-up: Consider creating a separate issue or author/maintainer-requested PR for this.

@thepastaclaw thepastaclaw added the pastaclaw:changes-requested thepastaclaw's latest review requested changes label Oct 7, 2026
@PastaPastaPasta

Copy link
Copy Markdown
Member Author

The title finding in review 5441537432 is addressed: the title is now feat: let devnets opt in to typed spork signatures. The fresh title-validation job passed. The source head remains be348fe7bfdbf2dec9a23af085241e7dc7081a88; this was a metadata-only correction. Please revalidate the title blocker.


🤖 Posted autonomously by Codex on behalf of pasta.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review after discussion — commit be348fe

Standing review was CHANGES_REQUESTED; this re-review is APPROVE: no blocking findings remain.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Independently reviewed the complete two-commit diff at be348fe and verified the supplied reviewer claims against chain-parameter selection, signing and verification, peer validation, cache initialization, and test fixtures. No in-scope defects were found, and the prior title blocker is fixed. This was a static review: the supplied CI snapshot shows lint, formatting, and corrected title validation passing, while source-build jobs and several platform checks remain queued; build and test completion is not independently confirmed.

Same commit as the standing review; the inline threads above carry the per-finding outcome. This follow-up exists only to correct the verdict.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — The diff makes a small, well-contained signature-format selection change using an existing typed-signature implementation, with focused tests and documentation, rather than a large or intricate cryptographic change.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 87% left, weekly 89% left; passed over gemini-3.8-flash-high (antigravity below 15% reserve: weekly 15% left, 5h 100% left)
  • Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort medium); agent phase2-reviewer

@thepastaclaw thepastaclaw added pastaclaw:approved thepastaclaw's latest review approved this PR and removed pastaclaw:changes-requested thepastaclaw's latest review requested changes labels Oct 7, 2026
@PastaPastaPasta
PastaPastaPasta force-pushed the codex/security-devnet-typed-spork-signatures branch from be348fe to e333d5b Compare October 7, 2026 17:07

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

Static verification of the complete diff at e333d5b found no actionable defects: the devnet opt-in consistently selects typed signing and verification without fallback, preserves existing network defaults, and revalidates cached sporks after the spork address is initialized. The tests cover the network selector matrix and rejection of reinterpreted value/time fields, and the release notes accurately describe the coordinated switch. The prior title blocker is fixed; the supplied CI snapshot shows title validation and formatting passing, but container builds remain queued, so build/test validation at this head is not established.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — The diff is a small, contained change that selects an existing spork signature format through a devnet opt-in, with focused tests, rather than introducing intricate signature logic.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 99% left, weekly 88% left; passed over gemini-3.8-flash-high (antigravity below 15% reserve: weekly 15% left, 5h 100% left)
  • Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort medium); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@PastaPastaPasta PastaPastaPasta added this to the 24.1 milestone Oct 9, 2026
PastaPastaPasta and others added 3 commits October 8, 2026 19:45
Spork values have been fixed on mainnet since v22 (GetSporkValue ignores
received sporks there), so spork messages carry no information on
mainnet. Stop asking peers for them with GETSPORKS, never request
announced sporks, ignore SPORK and GETSPORKS messages, and reject
sporkupdate.

This also lets the spork signature format change without upgraded
mainnet nodes penalizing older peers that still hold sporks in the
current format.

The inventory benchmark announces sporks, so run it on regtest where
they are still requested.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Outside testnet, a spork signature covered the decimal text of the spork
id, value and signing time concatenated with no separator. Different
field values can produce the same text: id 10020, value 1, time
1791370200 and id 10020, value 11, time 791370200 both sign
"100201791370200". A peer could re-split a genuine spork's fields and
relay it with a different value to a node that has not seen the
original yet.

Testnet already signs the serialized fields. Make that the only format.
Mainnet no longer uses sporks, nodes on a devnet run the same version,
and regtest's spork key is public, so no network needs the old format.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@PastaPastaPasta
PastaPastaPasta force-pushed the codex/security-devnet-typed-spork-signatures branch from e333d5b to 302a3fe Compare October 9, 2026 01:38
@PastaPastaPasta PastaPastaPasta changed the title feat: let devnets opt in to typed spork signatures fix: sign sporks over their serialized fields and stop using sporks on mainnet Oct 9, 2026

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

Independently reviewed the complete PR diff at 302a3fe and the surrounding signing, cache-loading, P2P, synchronization, RPC, and test paths; no actionable in-scope defects were found. Serialized-field signatures remove the field-boundary ambiguity, and the mainnet guards prevent requesting or validating legacy sporks while preserving fixed mainnet values. This was a static review: the supplied CI snapshot confirms successful title validation, lint, completed builds, and no-wallet tests; ASan, TSan, SQLite, and standard Linux tests plus the multiprocess build were still pending.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: gemini-3.8-flash-high (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — The diff changes spork signature verification and mainnet handling across signing, networking, sync and RPC paths, but the changes are straightforward rather than large or intricate enough to qualify as critical.
  • Phase 1 reviewers: gemini-3.8-flash-high — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: gemini-3.8-flash-high — antigravity quota: weekly 70% left, 5h 100% left
  • Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@knst knst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 302a3fe

I wanted to do it long time ago ::thumbs_up::

@PastaPastaPasta
PastaPastaPasta merged commit d39b193 into dashpay:develop Oct 9, 2026
50 of 51 checks passed
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Oct 16, 2026
…ing mnsync

On test networks a node only fetched sporks by sending GETSPORKS from the
mnsync tick. That request was skipped once mnsync finished, skipped for any
peer address with a still-valid "spork-sync" entry in netfulfilled.dat
(which survives restarts), and skipped for inbound peers on an active
masternode. A node that came up without sporks, e.g. after the sporks.dat
format change in v24, could therefore finish mnsync without them and never
ask again, leaving DKG and ChainLocks disabled until `mnsync reset`.

Announce every active spork as an inv to each peer when the handshake
completes, in both directions. Like spork relay, this includes masternode
connections, which only become relay-capable after MNAUTH. Peers request
the ones they lack with getdata, and a node that newly accepts a spork
already relays it, so the spork set converges without any opt-in or sync
state. The GETSPORKS handler is kept so v23 nodes can still ask us.

Fixes dashpay#7891

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 45acdf3)

Backport notes: develop merged dashpay#7893 twice. The first merge
(f99212b) carried an earlier revision of this commit, and the second
merge (72a5997) carried this one, so develop now announces sporks in
two places in the VERACK handler. Only the PR's final commit is picked
here.

Conflict in src/node/sync_manager.cpp: on this branch the mnsync tick
still sent GETSPORKS on every network, because dashpay#7847 (which limited it
to test chains) is not included. The request is removed entirely, as on
develop. Mainnet spork values are hardcoded in
CSporkManager::GetSporkValue, so the mainnet request had no effect.
PastaPastaPasta added a commit that referenced this pull request Oct 17, 2026
6c02b2b ci: let DEPENDS_ARCH override the machine arch for multiprocess and tsan (pasta)
ce5dbf3 Merge #7888: fix(consensus): canonical ExtNetInfo encoding and strict netInfo decoding (pasta)
54cba5c Merge #7537: fix: data races and check-then-act races in the CoinJoin server (pasta)
08d8bca Merge #7909: feat(mining): build the masternode list incrementally during block assembly (pasta)
5633761 Merge #7895: test: cover retroactive provider tx refusal, fix wording (pasta)
cbb9500 Merge #7846: fix: treat pending owner keys and Platform node IDs as one conflict namespace (pasta)
8efdf5e Merge #7857: fix: mine a pending ProUpServTx before a key change of its masternode (pasta)
e56e6ae Merge #7842: fix(wallet): reject mnemonic passphrases that seed derivation truncates (pasta)
79480ff test: follow-up for #7821: check if wallet is locked after failed upgrade instead creating brand-new scenario (Konstantin Akimov)
a56ed47 fix(net): announce sporks to new peers instead of requesting them during mnsync (pasta)
cdaea5f Merge #7894: fix: due to logical conflicts feature_pruning.py had been broken while (pasta)
98d92f6 Merge #7817: backport: partial bitcoin#34156 restore cleanup ownership (pasta)
35e6d18 Merge #7858: fix: do not InstantSend-lock provider transactions (pasta)
904d73d Merge #7881: fix: refuse to sign shared registrar updates that move the funder's coins (pasta)
95982f5 Merge #7782: fix(wallet): persist pending-observation coin locks once the record becomes readable (pasta)
cdf65d0 Merge #7836: backport: partial bitcoin#25812, bitcoin#29855 (pasta)
cc5716f Merge #7824: fix: retain initialized DKG sessions during inventory reads (pasta)
588e458 Merge #7827: backport: partial bitcoin#35984 (pasta)
795c6f1 Merge #7839: fix: release InstantSend tracking after mempool eviction (pasta)
dc1a6b2 Merge #7875: docs(rpc): clarify getchainlockbyheight availability (pasta)
e4798ff Merge #7876: fix(consensus): capture operator key scheme changes with unchanged bytes in state diffs (pasta)
fe68ecb Merge #7871: backport!: Merge bitcoin#27217: wallet: Replace use of purpose strings with an enum (pasta)
8348d22 Merge #7867: fix: refuse masternode list RPCs for blocks outside the active chain (pasta)
861a579 Merge #7866: fix: stop `masternode payments` at the genesis block (pasta)
efcef71 Merge #7521: fix: update masternode rate limit on failed governance trigger path (pasta)
0623182 Merge #7831: fix: bound governance object signatures and reset the governance cache (pasta)
b230657 Merge #7841: fix: authenticate cached InstantSend proof bytes (pasta)
a1f37ea Merge #7820: fix: hold chainstate lock during CoinJoin input validation (pasta)
50a5617 Merge #7829: fix: preserve wallet permissions when changing passphrases (pasta)
2ff0103 Merge #7818: fix: return REST errors for unavailable deployment data (pasta)
cb39369 Merge #7834: fix: validate Electrum import input boundaries (pasta)
e7e3daa Merge #7821: fix: relock encrypted wallets after HD upgrade failures (pasta)
2fea45f Merge #7792: fix: treat missing snapshots during evodb repair as repair errors (pasta)
3c5c039 Merge #7838: fix(wallet): authenticate unlock deadline extensions (pasta)
0bf80f8 Merge #7810: fix(rpc): handle unavailable masternode payment inputs (pasta)
bcefee4 Merge #7822: fix: reject malformed detached quorum share batches (pasta)
86a7737 Merge #7828: fix: omit recovery words from invalid mnemonic errors (pasta)
886d5c4 Merge #7816: fix: check credit pool amount accumulation (pasta)
00fc3b9 Merge #7851: fix(rpc): correct masternode status help for top-level service field (pasta)
0e75c22 Merge #7814: fix(qt): restore HTML escaping of send confirmation recipients (pasta)

Pull request description:

  ## Issue being fixed or feature implemented

  Backports for v24.0.0-rc.4, on top of `v24.0.x` at the v24.0.0-rc.3 tag (0364ed6, #7808).

  ## What was done?

  Cherry-picked (`git cherry-pick -m1 -x`) every develop merge since rc.3 that carries `backport-candidate-24.0.x`, plus eight unlabeled fixes picked after an audit of every other develop merge since rc.3 (marked † below). They are in develop merge order:

  - #7814 fix(qt): restore HTML escaping of send confirmation recipients †
  - #7851 fix(rpc): correct masternode status help for top-level service field
  - #7816 fix: check credit pool amount accumulation
  - #7828 fix: omit recovery words from invalid mnemonic errors †
  - #7822 fix: reject malformed detached quorum share batches †
  - #7810 fix(rpc): handle unavailable masternode payment inputs †
  - #7838 fix(wallet): authenticate unlock deadline extensions
  - #7792 fix: treat missing snapshots during evodb repair as repair errors
  - #7821 fix: relock encrypted wallets after HD upgrade failures
  - #7834 fix: validate Electrum import input boundaries
  - #7818 fix: return REST errors for unavailable deployment data
  - #7829 fix: preserve wallet permissions when changing passphrases
  - #7820 fix: hold chainstate lock during CoinJoin input validation
  - #7841 fix: authenticate cached InstantSend proof bytes
  - #7831 fix: bound governance object signatures and reset the governance cache
  - #7521 fix: update masternode rate limit on failed governance trigger path
  - #7866 fix: stop `masternode payments` at the genesis block
  - #7867 fix: refuse masternode list RPCs for blocks outside the active chain †
  - #7871 backport!: bitcoin#27217: wallet: Replace use of purpose strings with an enum
  - #7876 fix(consensus): capture operator key scheme changes with unchanged bytes in state diffs
  - #7875 docs(rpc): clarify getchainlockbyheight availability †
  - #7839 fix: release InstantSend tracking after mempool eviction
  - #7827 backport: partial bitcoin#35984
  - #7824 fix: retain initialized DKG sessions during inventory reads
  - #7836 backport: partial bitcoin#25812, bitcoin#29855
  - #7782 fix(wallet): persist pending-observation coin locks once the record becomes readable
  - #7881 fix: refuse to sign shared registrar updates that move the funder's coins †
  - #7858 fix: do not InstantSend-lock provider transactions
  - #7817 backport: partial bitcoin#34156 restore cleanup ownership
  - #7894 test: fix feature_pruning.py restart arguments † (needed because #7792 makes the evodb repair fatal, which the old restart arguments trip)
  - #7893 fix(net): announce sporks to new peers instead of requesting them during mnsync
  - 4a19742 (from #7859) test: follow-up for #7821: check if wallet is locked after failed upgrade instead creating brand-new scenario. Test-only, picked as its commit. Without it, #7821's `test_failed_upgrade()` expects RPC error -1 for a 257-byte mnemonic passphrase, which #7842's new precheck rejects with -8 first, so `wallet_upgradetohd.py --legacy-wallet` fails. On develop, #7859 replaced that scenario before #7842 merged. The rest of #7859 is test cleanup and docs and is left out.
  - #7842 fix(wallet): reject mnemonic passphrases that seed derivation truncates
  - #7857 fix: mine a pending ProUpServTx before a key change of its masternode
  - #7846 fix: treat pending owner keys and Platform node IDs as one conflict namespace
  - #7895 test: cover retroactive provider tx refusal, fix wording
  - #7909 feat(mining): build the masternode list incrementally during block assembly
  - #7537 fix: data races and check-then-act races in the CoinJoin server
  - #7888 fix(consensus): canonical ExtNetInfo encoding and strict netInfo decoding

  34 of the 39 picks change exactly the same lines as their develop merges. #7888 and #7782 needed test-only changes (see testing), and three others needed adaptation, described in their commit messages:

  - **#7893** was merged to develop twice: f99212b with an earlier revision of its commit, then 72a5997 with the final one, so develop now announces sporks twice in the VERACK handler (a develop fix is open separately). Here the PR's final commit 45acdf3 is picked once instead of either merge. In `src/node/sync_manager.cpp`, this branch still sent `GETSPORKS` from the mnsync tick on every network, because #7847, which limited it to test chains, is not included. The request is removed entirely, as on develop. Mainnet spork values are hardcoded in `CSporkManager::GetSporkValue`, so the mainnet request had no effect.
  - **#7857** and **#7909**: develop folded `CChainstateHelper` into `Chainstate` (d5c1bd7), which is not on this branch, so the new code goes through `ChainHelper().special_tx` / `m_chain_helper.special_tx` instead of `m_special_tx`. The neighbouring develop-only `CSpecialTxProcessor::GetDeterministicMNListHash` is left out.

  #7888 tightens consensus rules for ExtAddr provider transactions behind V24, so I checked it against testnet. V24 is not active there yet (the tip's CbTx is still version 3), so the chain has no ExtAddr ProTxs the new rules could reject. rc.3's own serializer always writes canonical, sorted purposes, so every ProTx it builds passes the new rules. Mixed rc.3/rc.4 networks could only split on a hand-crafted non-canonical ExtAddr ProTx mined after V24 activates. So testnet miners and masternodes should move to rc.4 before V24 is signalled.

  Unlabeled develop fixes since rc.3 that were audited and left out:
  - Worth considering before the final release: #7869 (startup block replay after an unclean shutdown asserts on a quorum commitment, so recovery needs `-reindex-chainstate`; not a v24 regression), #7833 (gate signing intake before quorum retrieval, DoS hardening), #7682 (intermittent `relic_conf.h` parallel-build failure).
  - Left for 24.1: #7812, #7826, #7844, #7847, #7850, #7868, plus the routine upstream backports (#7780, #7806, #7830, #7855, #7856, #7862, #7863, #7865, #7883, #7884, #7898, #7906), refactors (#7805, #7878, #7880), and CI, docs and test-only changes.

  One CI-only commit comes last. It takes only the `ci/test` hunks of 6f71fa5 (#7901), which make `ci/test/00_setup_env_native_{multiprocess,tsan}.sh` honor `DEPENDS_ARCH`. Pull requests into `v24.0.x` run develop's workflow files (`pull_request_target`), and since #7901 those check the depends cache on x86_64 runners and pass the aarch64 build arch in `DEPENDS_ARCH`. Without the hunks, `linux64_multiprocess / Build depends` fails on any depends cache miss (`Build runner computes HOST=aarch64-linux-gnu but check-cache used x86_64-pc-linux-gnu`). Without `DEPENDS_ARCH` the scripts still use `uname -m`, so this branch's own push CI is unchanged.

  No version change is needed. `configure.ac` is already 24.0.0 with `CLIENT_VERSION_IS_RELEASE` false, so the build takes its version string from the `v24.0.0-rc.4` tag.

  ## How Has This Been Tested?

  Built and tested at 6c02b2b on macOS arm64 against depends, with `--enable-debug --enable-werror --disable-hardening`.

  - `make check`: all unit test suites pass, including `test_dash-qt`.
  - Functional tests, all passing: `feature_evo_shares_activation.py`, `feature_governance_objects.py`, `feature_llmq_signing.py` (plain and `--spork21`), `feature_masternode_shares.py`, `feature_sporks.py`, `interface_rest.py`, `p2p_instantsend.py`, `p2p_quorum_data.py`, `rpc_masternode.py`, `rpc_psbt.py`, `rpc_quorum.py`, `wallet_backup.py`, `wallet_dump.py`, `wallet_encryption.py`, `wallet_labels.py` and `wallet_upgradetohd.py`, each with `--descriptors` and `--legacy-wallet` where it supports them.

  - Each pick's changed lines were compared with its develop merge (or, for #7893, its PR commit). They are identical except for the #7893, #7857 and #7909 adaptations above, and the #7888 test adaptation below.
  - A local macOS arm64 debug build (`--enable-debug --enable-werror`) compiled most of the tree and stopped on a single error in `src/test/evo_netinfo_tests.cpp`. #7888's new test used `CNetAddr::V2()`, the serialization-parameter API from bitcoin#25284, which this branch lacks. The pick now writes that entry through an `OverrideStream` with `ADDRV2_FORMAT`, the way `NetInfoEntry::Serialize` does on this branch (see its commit message).
  - #7782's new unit test reloads the wallet with develop's three-argument `CWallet` constructor. On this branch the constructor still takes the CoinJoin loader and an `ArgsManager`, so the test passes them the way its fixture already does (see the commit message).
  - With both test fixes, a full local `make` (`dashd`, `dash-qt`, `test_dash`, `test_dash-qt`) completes with no errors.
  - `feature_pruning.py` is an extended test that CI does not run. #7894 is included because #7792 makes its restart path fail.

  ## Breaking Changes

  Carried over from the picked PRs:

  - #7876: rc.1 to rc.3 nodes that connected an affected block stored a wrong masternode list diff for it. Those nodes need `-reindex`; `-reindex-chainstate` is not enough for nodes that already marked the following block invalid.
  - #7888: stricter ExtAddr `netInfo` decoding and validation behind V24 (see above). The RFC1918 check now applies even with `-allowprivatenet`.
  - #7858: provider transactions no longer get InstantSend locks. Software that waits for an islock on a ProTx should wait for a ChainLock or confirmations instead.
  - #7857: a `ProUpServTx` spending an output of a pending operator key change, asset lock, asset unlock or MNHF signal is rejected from the mempool until that transaction confirms.
  - #7831: governance object signatures over 96 bytes are rejected, and the governance cache is discarded and re-synced on first start (`doc/release-notes-7831.md`).
  - #7871: address purposes are limited to `send`, `receive` and `refund`. Wallets with other purpose strings load with warnings, and `listlabels` errors on an unknown purpose (`doc/release-notes-27217.md`).
  - #7842: creating an HD wallet with a mnemonic passphrase over 248 bytes fails unless `-allow-deprecated-long-mnemonics` is set, and over 256 bytes always fails (`doc/release-notes-7842.md`).
  - #7792: a node whose evodb is missing a masternode list snapshot now stops at startup and asks for `-reindex`, and `evodb repair` reports it in `repairErrors`.
  - #7867: `protx info <proTxHash> <blockHash>`, `protx listdiff` and `masternode payments <blockHash>` return an error for blocks outside the active chain.
  - #7881: `protx shared_combine` on a `ProUpSharedRegTx` is refused unless its inputs are unlocked coins of a single address of the calling wallet, change returns to that address, and the fee is within `-maxtxfee`.
  - #7836: PSBTs referencing nonexistent previous outputs fail to deserialize (RPC error -22).
  - #7834: negative Electrum-import rescan indices are rejected.
  - #7893: on this branch, mainnet nodes no longer send `GETSPORKS` during mnsync (no effect, mainnet spork values are hardcoded).

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

Top commit has no ACKs.

Tree-SHA512: 7de9535ca51620f4ddf5a46df2c3341a5e5fdd2263606f83f7db6b576c31ff7b82e1b285bf66988ac4b2729a9060513c45710135f61d7fd5c147b670d5f405dc
PastaPastaPasta added a commit that referenced this pull request Oct 29, 2026
…ixes: #7682, #7869, #7861, #7951)

1ba2609 Merge #7951: fix(net): stop peers lingering after disconnect under edge-triggered epoll (pasta)
696d45f Merge #7861: feat: keep at least 4-days worth blocks after pruning (merge-script)
9cd1c72 Merge #7869: fix: let startup block replay handle quorum commitments and asset unlocks (pasta)
73e7254 Merge #7682: build: finish relic_conf.h regeneration before compiling BLS consumers (pasta)

Pull request description:

  ## Issue being fixed or feature implemented

  Third v24.0.0-rc.5 backport PR, on top of `v24.0.x` at v24.0.0-rc.4 (0e7382d). It is independent of #7965 (v23.1.9 fixes and #7947) and #7967 (#7916). rc.5 is meant to be ready to become the final release, so every develop merge since the `v24.0.x` branch point that is neither picked nor labeled was audited again. These four unlabeled fixes are needed for a final v24.0.0. #7869 was already listed in #7917 as "worth considering before the final release".

  ## What was done?

  Cherry-picked with `git cherry-pick -m1 -x`, in develop merge order:

  - #7682 build: finish relic_conf.h regeneration before compiling BLS consumers. Fixes an intermittent parallel-build failure.
  - #7869 fix: let startup block replay handle quorum commitments and asset unlocks. After an unclean shutdown, block replay asserted on a quorum commitment, so the node needed `-reindex-chainstate` to recover.
  - #7861 feat: keep at least 4-days worth blocks after pruning. A pruned node could prune blocks that a credit-pool rebuild, or the work block of a rotated LLMQ cycle, still needs. It then rejected a canonical block after restart, or computed different quorum members than the network.
  - #7951 fix(net): stop peers lingering after disconnect under edge-triggered epoll

  #7682 and #7951 change exactly the same lines as their develop merges. Two picks needed adaptation, described in their commit messages:

  - **#7869**: develop folded `CChainstateHelper` into `Chainstate` (d5c1bd7), which is not on this branch, so `RollforwardBlock()` keeps calling `m_chain_helper->special_tx`.
  - **#7861**: chain parameters live in `src/chainparams.{h,cpp}` here (develop moved them to `src/kernel/`), and regtest's `nPruneAfterHeight` still reads `-fastprune` through `ArgsManager`. No caller of the old `MIN_BLOCKS_TO_KEEP` is left on this branch. `doc/release-notes-7861.md` comes with the pick and needs folding into the final release notes.

  Unlabeled develop merges since the branch point that were audited and left out:
  - #7918: not needed. The duplicate spork announcement it removes was never on this branch, because #7917 picked #7893's final commit once.
  - Left for 24.1:
    - perf work (#7934, #7935, #7936), because #7934 reworks MN list construction and payee validation;
    - #7847, which changes spork signing and stops using sporks on mainnet;
    - #7868 (GETMNLISTDIFF/GETQRINFO rate limit), #7844 and #7812;
    - #7260 (Qt feature) and its follow-up #7804;
    - #7937 (maintainer script);
    - the routine upstream backports and CI/docs/test-only changes.

  ## How Has This Been Tested?

  Linux x86_64 against depends, `--enable-debug --enable-werror --disable-hardening --without-gui`: build is clean.

  - Unit suites, passing: `evo_assetlocks_tests` (including #7861's new case), `blockmanager_tests`, `net_tests`, `denialofservice_tests`.
  - Functional tests, passing: `feature_asset_locks.py` (including #7869's replay case), `feature_pruning.py` (extended), `feature_index_prune.py`, `p2p_node_network_limited.py` (v1/v2), `rpc_blockchain.py` (v1/v2), `p2p_addr_relay.py`, `p2p_disconnect_ban.py` (v1/v2).
  - `feature_asset_locks.py` failed once in a parallel run, and the log was not kept. It then passed 5 of 5 runs, 4 of them in parallel.
  - An independent review compared each adapted pick with its develop merge and checked v24.0.x for remaining users of the old pruning constant.

  ## Breaking Changes

  - #7861: pruned nodes keep at least 2304 blocks (four days) instead of 288 on mainnet, testnet and devnet, so they use slightly more disk. On testnet and devnet, pruning starts after height 3000 instead of 1000. Regtest is unchanged.

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

Top commit has no ACKs.

Tree-SHA512: a8e39c6025e1737bcd55e7aa50c1419633a67dd82a0585f0586a63b8fb14f4770e9e24b7e7d2605da44c12e6c98768a893fccf6972aa71c1eaab23eec7e5b59f
PastaPastaPasta added a commit that referenced this pull request Nov 6, 2026
Brings the v24.0.0 release into develop. upstream/master is at the
signed v24.0.0 tag (938fba5), so this merges master itself.

v24.0.x was cut from develop, and every code change on it is already on
develop: its backports are cherry-picks of develop commits, and its
remaining commits reached develop through #7966, #7973 and #8042. The
textual merge conflicts in dozens of files because v24.0.x carries
adapted copies of those changes. All of them resolve to develop's side,
which keeps develop's code, translations and configure.ac (24.1.0).

Taken from v24.0.0:
- doc/release-notes.md: the v24.0.0 release notes; the v23.1.10 notes
  are archived in doc/release-notes/dash/
- the man pages regenerated for v24.0.0, replacing develop's older
  v24.0.0 pages; a few entries (-prune, -par, -parbls,
  -maxconnections) still trail develop's help text, as before, until
  they are regenerated for the next release
- feature_addressindex.py: the test that blocks orphaned while the
  address index is disabled are removed from it once it is re-enabled

Release notes folded into the v24.0.0 notes are removed, including
release-notes-8018.md, release-notes-8029.md and release-notes-27114.md,
whose changes shipped in v24.0.0 without their files. Develop's
release-notes-28113.md and release-notes-28414.md also described
descriptorprocesspsbt, which only develop has, so they are trimmed to
that RPC instead of removed. Notes for changes v24.0.0 does not include
(#7812, #7847, #7860, #7862, #8010's bitcoin#26485, bitcoin#25943,
bitcoin#27501) stay.
PastaPastaPasta added a commit that referenced this pull request Nov 6, 2026
d6c066f chore: add v23.1.10 to the flatpak release history (pasta)
202632c chore: release v24.0.0 (pasta)
2bf133c docs: cite #8042 for the index fixes in the v24.0.0 release notes (pasta)
8aa11f6 docs: add the v24.0.0-rc.7 picks and index fixes to the v24.0.0 release notes (pasta)
ad4e5d6 docs: drop the index caveat from the -reindex-chainstate man page entry (pasta)
19a90bb test: blocks orphaned while the address index is disabled are removed from it (pasta)
d2f2a1f fix(index): don't adopt an empty or rebuilt async index as migrated legacy data (pasta)
e3bafdb fix(index): reject an uncommitted tip the block index lost (pasta)
9198962 fix(index): check the blocks governance resumes from at startup (pasta)
baff347 fix(index): resume from the tip a skipped commit leaves behind (pasta)
2dbf5ca fix(index): write a rewound block's erasures in one batch with its locator (pasta)
252acbe fix(index): move the committed locator below the entries a rewind erases (Konstantin Akimov)
e9f9c8a Merge bitcoin#36150: indexes: set prune lock to genesis before first block (Konstantin Akimov)
2edeb98 partial Merge bitcoin#34897: indexes: Don't commit ahead of the flushed chainstate (Konstantin Akimov)
3eba84c Merge bitcoin#32875: index: handle case where pindex_prev equals chain tip in NextSyncBlock() (Konstantin Akimov)
399125c Merge bitcoin#32882: index: remove unnecessary locator cleaning in BaseIndex::Init() (Konstantin Akimov)
bb724c6 Merge bitcoin#33212: index: Don't commit state in BaseIndex::Rewind (Konstantin Akimov)
d5ff431 Merge bitcoin#32878: index: fix wrong assert of current_tip == m_best_block_index (Konstantin Akimov)
31c7d8f partial Merge bitcoin#32580: wallet, test: best block locator matches scan state follow-ups (Konstantin Akimov)
94f5c58 partial Merge bitcoin#30221: wallet: Ensure best block matches wallet scan state (Konstantin Akimov)
8e0b1e8 partial Merge bitcoin#32069: test: fix intermittent failure in wallet_reorgsrestore.py (Konstantin Akimov)
4d17947 Merge bitcoin#25193: indexes: Read the locator's top block during init, allow interaction with reindex-chainstate (Konstantin Akimov)
0127df8 Merge #8045: test: scale the mempool-loaded wait by timeout_factor so TSAN reindex restarts stop timing out (pasta)
62d0cef Merge #8036: fix(qt): let a shared masternode participant follow a revised invitation that keeps their share (merge-script)
775d31c Merge #8018: fix(consensus): require IPv4 masternode primaries until IPv4 is optional, pin mainnet ports (merge-script)
e1b826e Merge #8026: fix(qt): keep shared masternode contribution fields locked while coins are reserved (merge-script)
9fa3df3 Merge #8020: fix(rpc): make protx shared_sign sign only dissolutions that return every principal (merge-script)
246a465 Merge #8024: fix(qt): keep the shared masternode dissolve dialog consistent with what it will send (merge-script)
590ad0a Merge #8021: fix(qt): don't load a newer shared masternode session copy that changes your own share (merge-script)
974aaa3 Merge #8034: fix(qt): check a shared masternode's service and refund addresses before coins are reserved (merge-script)
0026e3e Merge #8027: fix(qt): fund a shared masternode's service update from this wallet by default (merge-script)
6a5d2dc Merge #8035: fix(qt): don't strand coins reserved for a shared masternode session (merge-script)
df6083a Merge #8032: fix(qt): don't offer a new operator key when reopening a shared masternode session (merge-script)
2b5bf30 Merge #8029: fix: let dashd -version, -help and first start work without an existing data directory (merge-script)
e33d9b1 Merge #8037: docs: list the config file path each Linux init system uses (merge-script)
6030ea0 docs: add the #8014 migratewallet fixes to the v24.0.0 release notes (pasta)
1b1ea95 Merge #8014: backport: bitcoin#28609, bitcoin#34215, bitcoin#34226, bitcoin#34370, partials bitcoin#31423, bitcoin#34156 (migratewallet fixes from 28.x) (merge-script)
608ff63 Merge bitcoin#28542: wallet: Check for uninitialized last processed and conflicting heights in MarkConflicted (DCG-Claude)
3af6f63 Merge bitcoin#28038: wallet: address book migration bug fixes (DCG-Claude)
2fe41fb docs: add ecosystem notes on Asset Unlock txids, coinbase payees and RPC errors (pasta)
0e3f653 docs: correct operator guidance in the v24.0.0 release notes for rc.7 (pasta)
11c8140 Merge #8019: fix(qt): stop reporting refused shared masternode broadcasts as sent (merge-script)
cdb250c doc: note operator-relevant v23.1.x patch-release changes for v24.0.0 (pasta)
fcd332b doc: state the provider-transaction InstantSend change on its own (pasta)
e6f3ad4 fix(bls): stop weighted contribution batch verification on an invalid partial aggregate (pasta)
e04acba fix(llmq): weight batched DKG contribution verification (UdjinM6)
ed96227 fix(bls): weight batch-verified signatures so complementary errors cannot cancel (UdjinM6)
b5c7985 fix(governance): don't vote on triggers while not synced (pasta)
a79f432 fix(governance): don't vote NO-FUNDING on triggers before their maturity window (pasta)
8615244 fix(llmq): accept equal DKG secret key shares when aggregating a member's share (pasta)
1c356f4 test: cover DKG members dealing identical contributions (UdjinM6)
f23f748 fix(llmq): drop DKG members whose verification vectors share coefficients (UdjinM6)
914c052 docs: add #8003 to the v24.0.0 release notes and man pages (pasta)
e81c511 Merge #8003: fix(net): don't refuse to start over the automatic onion service unless -listenonion=1 (merge-script)
41b4578 ci: run cppcheck as test/lint/cppcheck-dash.py, as develop does since #7966 (pasta)
c97f3b3 docs: regenerate man pages for v24.0.0-rc.6 (pasta)
784312c docs: add the v24.0.0-rc.6 changes to the v24.0.0 release notes (pasta)
f15a53a Merge #7991: fix(qt): shared masternode wizard fixes for taken shares, unconfirmed funding and reply handling (merge-script)
1c46224 Merge #7995: fix(wallet): don't let a waiting CoinJoin promotion/demotion queue block standard mixing (merge-script)
546db2f Merge #7996: fix(wallet): fill a CoinJoin promotion with sibling coins when needed (merge-script)
349859f Merge #7957: fix(qt): validate shared-masternode shares with the consensus rules (merge-script)
9091f0b Merge #8005: backport: bitcoin#27114, bitcoin#33395 (merge-script)
e915ab5 Merge #7990: fix(wallet): pay for 3 byte input and output counts so 253+ input sends work (merge-script)
4f4d188 Merge #7984: chore: Translations 2026-10 (pasta)
129a1fc Merge #7980: chore: update seeds, checkpoints, minimum chain work, assumevalid and tx stats for v24 (pasta)
5800e5d docs: state that SPORK_3/SPORK_9 were already hardened on mainnet (pasta)
ddc82a8 docs: separate extended addresses from shared masternodes in v24 notes (pasta)
8660e54 docs: complete the v24.0.0 release notes against the full v24 changeset (pasta)
11ea306 Merge #7947: fix: stop quorum key warming from stalling DKG on 2-core masternodes (pasta)
25d7c85 Merge #7826: fix: skip repeated authenticated Platform bans (pasta)
18073dd Merge #7850: perf: let CHECKDATASIG use the signature cache (pasta)
3759397 Merge #7833: fix: gate signing intake before quorum retrieval (pasta)
db98ee2 fix: keep flat-file positions 64-bit clean at the remaining raw seek/tell sites (Konstantin Akimov)
54c9738 Merge bitcoin#36667: net: enforce timeout interval for paused send peers (Konstantin Akimov)
f1adb2c Merge bitcoin#36665: sock: align exception monitoring between poll() and select() backends (Konstantin Akimov)
8becf6a Merge bitcoin#36669: refactor: store positions as a 64 bits integer in flatfiles (Konstantin Akimov)
4c0cbd6 fix(llmq): judge every sig-share sender by its own verified shares (pasta)
649259f fix(governance): cap the orphan parent objects re-requested per tick (pasta)
418f5ee fix(llmq): verify DKG contributions individually when a batch vvec check fails (pasta)
abf2eb0 fix(llmq): reject invalid decrypted DKG shares before aggregation (pasta)
39bda8f fix(consensus): reject negative transaction nVersion after DIP3 (pasta)
1ba2609 Merge #7951: fix(net): stop peers lingering after disconnect under edge-triggered epoll (pasta)
696d45f Merge #7861: feat: keep at least 4-days worth blocks after pruning (merge-script)
9cd1c72 Merge #7869: fix: let startup block replay handle quorum commitments and asset unlocks (pasta)
73e7254 Merge #7682: build: finish relic_conf.h regeneration before compiling BLS consumers (pasta)
7312925 ci: bake the macOS SDK into the CI runner image (pasta)
d885ecd Merge #7916: backport: bitcoin#27800, bitcoin#28125, bitcoin#28232, bitcoin#27695 (merge-script)
f55ad1d Merge bitcoin#28139: test: create wallet specific for test_locked_wallet case (DCG-Claude)
80f6cbe chore: add the v23.1.9 release entry to flatpak metainfo (pasta)
5ba801f chore: use translation source strings generated from v24.0.x (pasta)
a3b9e30 Merge #7974: chore: update man pages, translation strings, SECURITY.md and flatpak for v24.0.0 (pasta)
b5d26bd feat(consensus): schedule V24 and evo_shares on mainnet for November 9, 2026 (pasta)
fe78211 docs: state the earliest v24 activation height and the v23.1.9 fixes (pasta)
3bbe3e2 docs: address review of v24.0.0 release notes (pasta)
28c39fc docs: add v24.0.0 release notes and remove individual release notes files (pasta)
e8cbfaf docs: archive v23.1.8 and v23.1.9 release notes (pasta)
6c02b2b ci: let DEPENDS_ARCH override the machine arch for multiprocess and tsan (pasta)
ce5dbf3 Merge #7888: fix(consensus): canonical ExtNetInfo encoding and strict netInfo decoding (pasta)
54cba5c Merge #7537: fix: data races and check-then-act races in the CoinJoin server (pasta)
08d8bca Merge #7909: feat(mining): build the masternode list incrementally during block assembly (pasta)
5633761 Merge #7895: test: cover retroactive provider tx refusal, fix wording (pasta)
cbb9500 Merge #7846: fix: treat pending owner keys and Platform node IDs as one conflict namespace (pasta)
8efdf5e Merge #7857: fix: mine a pending ProUpServTx before a key change of its masternode (pasta)
e56e6ae Merge #7842: fix(wallet): reject mnemonic passphrases that seed derivation truncates (pasta)
79480ff test: follow-up for #7821: check if wallet is locked after failed upgrade instead creating brand-new scenario (Konstantin Akimov)
a56ed47 fix(net): announce sporks to new peers instead of requesting them during mnsync (pasta)
cdaea5f Merge #7894: fix: due to logical conflicts feature_pruning.py had been broken while (pasta)
98d92f6 Merge #7817: backport: partial bitcoin#34156 restore cleanup ownership (pasta)
35e6d18 Merge #7858: fix: do not InstantSend-lock provider transactions (pasta)
904d73d Merge #7881: fix: refuse to sign shared registrar updates that move the funder's coins (pasta)
95982f5 Merge #7782: fix(wallet): persist pending-observation coin locks once the record becomes readable (pasta)
cdf65d0 Merge #7836: backport: partial bitcoin#25812, bitcoin#29855 (pasta)
cc5716f Merge #7824: fix: retain initialized DKG sessions during inventory reads (pasta)
588e458 Merge #7827: backport: partial bitcoin#35984 (pasta)
795c6f1 Merge #7839: fix: release InstantSend tracking after mempool eviction (pasta)
dc1a6b2 Merge #7875: docs(rpc): clarify getchainlockbyheight availability (pasta)
e4798ff Merge #7876: fix(consensus): capture operator key scheme changes with unchanged bytes in state diffs (pasta)
fe68ecb Merge #7871: backport!: Merge bitcoin#27217: wallet: Replace use of purpose strings with an enum (pasta)
8348d22 Merge #7867: fix: refuse masternode list RPCs for blocks outside the active chain (pasta)
861a579 Merge #7866: fix: stop `masternode payments` at the genesis block (pasta)
efcef71 Merge #7521: fix: update masternode rate limit on failed governance trigger path (pasta)
0623182 Merge #7831: fix: bound governance object signatures and reset the governance cache (pasta)
b230657 Merge #7841: fix: authenticate cached InstantSend proof bytes (pasta)
a1f37ea Merge #7820: fix: hold chainstate lock during CoinJoin input validation (pasta)
50a5617 Merge #7829: fix: preserve wallet permissions when changing passphrases (pasta)
2ff0103 Merge #7818: fix: return REST errors for unavailable deployment data (pasta)
cb39369 Merge #7834: fix: validate Electrum import input boundaries (pasta)
e7e3daa Merge #7821: fix: relock encrypted wallets after HD upgrade failures (pasta)
2fea45f Merge #7792: fix: treat missing snapshots during evodb repair as repair errors (pasta)
3c5c039 Merge #7838: fix(wallet): authenticate unlock deadline extensions (pasta)
0bf80f8 Merge #7810: fix(rpc): handle unavailable masternode payment inputs (pasta)
bcefee4 Merge #7822: fix: reject malformed detached quorum share batches (pasta)
86a7737 Merge #7828: fix: omit recovery words from invalid mnemonic errors (pasta)
886d5c4 Merge #7816: fix: check credit pool amount accumulation (pasta)
00fc3b9 Merge #7851: fix(rpc): correct masternode status help for top-level service field (pasta)
0e75c22 Merge #7814: fix(qt): restore HTML escaping of send confirmation recipients (pasta)
fbe6526 Merge #7807: feat(consensus): hold EvoNode shares and multiple payouts behind a new evo_shares deployment (pasta)
57fd2d9 Merge #7776: fix: keep a pending ProUpServTx across a registrar update that keeps the operator key (pasta)
ca69801 Merge #7803: fix: return non-zero amount of accounts after sethdseed (pasta)
57a8f07 Merge #7796: backport: bitcoin#26720 (remaining), partial bitcoin#29523: weight-check the knapsack exact-match selection (pasta)
4eb82f6 Merge #7786: fix(net): keep a dedicated onion listener when -bind is given and correct the bind release note (pasta)
70626a0 Merge #7793: backport: partial bitcoin#28868 (wallet: reload wallet if migration exited early, keep mixed watchonly txs) (pasta)
250a3cd Merge #7790: fix: guard cached governance object flags with the object lock (pasta)
700c195 Merge #7787: fix: only sign EHF signals inside the deployment's start/timeout window (pasta)
a3b0f3c Merge #7785: fix: restore the txindex requirement when governance validation is enabled (pasta)
2d1735d Merge #7794: fix(wallet): floor the denomination gap threshold so rebalancing cannot oscillate (pasta)
d9f6592 Merge #7783: fix: stop fish completion from re-running the typed dash-cli command (pasta)
89d44c8 Merge #7795: backport: bitcoin#34272, partial bitcoin#31650 (pass PSBT by const reference in PSBTInputSignedAndVerified) (pasta)
a1d7411 Merge #7779: fix!: report legacy evonode Platform addresses when listdiff changes its address (pasta)
73f6ea2 Merge #7789: fix(qt): report malformed lang/font settings instead of aborting at startup (pasta)
40de493 Merge #7781: fix(rpc): use a consistent tip height in quorum dkgstatus (pasta)
7d1a90d Merge #7791: fix(net): request object votes from nPeersPerHashMax peers (pasta)
51b145c Merge #7778: test: use single-member in functional tests: feature_mnehf, feature_notifications, p2p_instantsend (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  Merges the v24.0.0 release back into develop, as the release process asks once `master` is fast-forwarded. `master`, `v24.0.x` and the signed `v24.0.0` tag all point to the same commit (938fba5).

  ## What was done?
  One merge commit of `master` into develop.

  `v24.0.x` was cut from develop, so all of its code is already here. Every commit on it that develop lacks by patch is one of these:
  - a `cherry-pick -x` of a develop commit;
  - covered by a develop PR: the index fixes by #8042, the mainnet V24 schedule by #7973, the cppcheck CI move by #7966;
  - release bookkeeping.

  Git reports conflicts in many files, because `v24.0.x` carries adapted copies of develop's changes. All of them resolve to develop's side, which keeps develop's code, translations and version (`configure.ac` stays at 24.1.0, `CLIENT_VERSION_IS_RELEASE` false).

  Taken from v24.0.0:
  - `doc/release-notes.md`: the v24.0.0 release notes. The v23.1.10 notes move to `doc/release-notes/dash/`.
  - The man pages regenerated for v24.0.0, replacing develop's older v24.0.0 pages. A few entries (`-prune`, `-par`, `-parbls`, `-maxconnections`) still trail develop's help text, as they did before, until the next regeneration.
  - `feature_addressindex.py`: the v24.0.x test that blocks orphaned while the address index is disabled are removed from it once it is re-enabled.

  Release notes:
  - Individual `doc/release-notes-*.md` files whose content is in the v24.0.0 notes are removed. This includes `release-notes-8018.md`, `release-notes-8029.md` and `release-notes-27114.md`, whose changes shipped in v24.0.0 without the files.
  - `release-notes-28113.md` and `release-notes-28414.md` also covered `descriptorprocesspsbt`, which only develop has. They are trimmed to that RPC instead of removed.
  - Notes for changes v24.0.0 doesn't include stay: #7812, #7847, #7860, #7862, bitcoin#25943, bitcoin#26485 and bitcoin#27501.

  ## How Has This Been Tested?
  macOS arm64 against depends, `--enable-debug --enable-werror --disable-hardening --without-gui`. `dashd`, `dash-cli` and `test_dash` build cleanly.

  - `src/` is byte-identical to develop's. The only non-doc change is the new `feature_addressindex.py` case.
  - Functional tests, all passing: `feature_addressindex.py` (with the new case) and `feature_spentindex.py`.
  - Unit suites, all passing: `txindex_tests`, `blockfilter_index_tests`, `coinstatsindex_tests`, `index_migration_tests`, `baseindex_tests`.
  - `lint-python.py`, `lint-whitespace.py`, `lint-includes.py` and `lint-circular-dependencies.py` pass.
  - An independent review checked every non-merge commit in `develop..master` against develop (by patch, by cherry-pick source, and line by line for the rest), re-merged each `v24.0.x` merge commit to look for content added in a merge, and checked each release-note file decision.

  I did not run the full functional suite locally; CI covers it.

  ## Breaking Changes
  None. Develop's code is unchanged; the only non-doc change is the new functional test case.

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [x] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(if you have permission to set one)_

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

Top commit has no ACKs.

Tree-SHA512: 3c2d1b7d2885f983f1457a18920f42907009c8ca77522a6116739d387b011d8d5583da6a4b6a1227bcaa21fa07a7ef635aae58fb8b19e4f31a95582ee1ce2318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pastaclaw:approved thepastaclaw's latest review approved this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants