Skip to content

fix(rpc): undefined behaviour, locking and argument handling in Dash RPCs - #8118

Merged
PastaPastaPasta merged 6 commits into
dashpay:developfrom
PastaPastaPasta:fix/rpc-input-locking
Nov 13, 2026
Merged

PastaPastaPasta merged 6 commits into
dashpay:developfrom
PastaPastaPasta:fix/rpc-input-locking

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Several Dash RPC edge cases reject supported inputs, perform overflowing signed arithmetic, or access chain state without the required protection. EvoDB verification and repair also accept stale-fork endpoints even though they operate on active-chain data.

What was done?

One commit per fix:

  • masternode payments, getspecialtxes: handle an explicit null payment count as the default, compute the magnitude of negative counts safely (including INT64_MIN), and avoid overflowing skip + count.
  • getblockheaders: collect the block indexes and the tip under cs_main, then serialize the captured headers outside the lock.
  • getaddressdeltas: accept the supported single-address string form.
  • mnauth: use EnsureConnman.
  • evodb verify/repair: require both endpoints to belong to the active chain.
  • operatorReward help and error messages: describe percentages from 0 to 100 and display a single percent sign.

How Has This Been Tested?

On macOS arm64, with a debug/werror build and functional-test datadirs on a RAM disk:

  • Added checks to existing masternode, address-index and blockchain scenarios. On unchanged develop, null payment counts and string-form address deltas fail with RPC type errors, and stale-fork EvoDB endpoints are accepted. Those checks pass with the fixes. The added getblockheaders checks (multiple headers, count truncation, hex form) also pass on develop: they cover the rewritten traversal, not the race.
  • Ran the INT64_MIN payment and getspecialtxes checks separately on unchanged develop: both terminate the debug daemon with an arithmetic trap (-ftrapv). The reachable special-transaction overflow uses count=2147483647, skip=1 in a block containing at least two special transactions.
  • make -j4; src/test/test_dash --run_test=rpc_tests.
  • RAM-disk functional runner: -j2 --timeout-factor=2 rpc_masternode.py feature_addressindex.py rpc_blockchain.py rpc_mnauth.py rpc_help.py.
  • Rebuilt with --with-sanitizers=integer,undefined and reran the same five tests with CI's UBSan options and suppressions: all pass. The first version of the negative-count magnitude (0 - uint64_t(count)) tripped unsigned-integer-overflow in rpc_masternode.py there, as it did in linux64_asan; it is now ~uint64_t(count) + 1, the form CScriptNum uses.
  • Python flake8 using the repository's enabled checks, whitespace lint, and git diff --check. The repository Python lint's mypy step reports three existing errors in unchanged files with mypy 2.4.1.

The header traversal race and absent-connman path were verified by source inspection; no TSAN run was performed.

Breaking Changes

EvoDB verify/repair now reject stale-fork endpoints with RPC error -8. Supported active-chain requests retain their behavior.

Some error messages change on invalid input:

  • getblockheaders checks count before looking up the block, so a call with an unknown hash and a bad count now reports "Count is out of range".
  • getaddressdeltas called without an address or with an array now fails with -5 "Invalid address" instead of a JSON type error.
  • The evodb not-found errors now say "... not found in active chain".

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes update block header collection and special transaction pagination. Evo RPC descriptions state the operator reward range, and verification endpoints reject blocks outside the active chain. Masternode payment handling covers null and minimum signed counts. Node RPC changes update connection manager access and address delta parameter handling. Functional tests cover these behaviors and query results.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: Minimal · up to ce16d

This change fixes undefined behavior and argument-handling problems in several RPCs and adds functional tests for them. No actionable merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the Dash RPC fixes in this changeset: undefined behaviour (signed overflow in payment and getspecialtxes counts), locking (getblockheaders capturing state under cs_main), and argument …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the purpose (several Dash RPC edge cases, EvoDB stale-fork endpoints) and lists fixes that match the changeset: masternode payments and getspecialtxes count handling, getblockhe…
Full details: Title check

Explanation

The title names the Dash RPC fixes in this changeset: undefined behaviour (signed overflow in payment and getspecialtxes counts), locking (getblockheaders capturing state under cs_main), and argument handling (null counts, getaddressdeltas string form). It is specific to the RPC layer. It does not name the EvoDB active-chain endpoint change, but it is a partial summary of the main change, which is acceptable.

Full details: Description check

Explanation

The description states the purpose (several Dash RPC edge cases, EvoDB stale-fork endpoints) and lists fixes that match the changeset: masternode payments and getspecialtxes count handling, getblockheaders locking, getaddressdeltas string form, mnauth EnsureConnman, evodb verify/repair active-chain checks, and operatorReward help text. It also describes testing and breaking changes. It is clearly related to the changes.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e52780b5-b6e0-42ea-8677-adeef6a27eda
Commits

Reviewing files that changed from the base of the PR and between f45771f and ce16d7f.

Files selected for processing: 2

  • src/rpc/masternode.cpp
  • test/functional/rpc_masternode.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

@PastaPastaPasta PastaPastaPasta added this to the 24.1 milestone Nov 11, 2026
@thepastaclaw

thepastaclaw commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit ce16d7f) · triage: normal

@github-actions

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 2 only (queue backlog)

Static verification of the exact head found no actionable in-scope defects. The RPC arithmetic, locking, argument handling, active-chain validation, documentation, and regression-test changes are consistent with their stated intent; no code checks have failed, while build, lint, and analysis checks remain queued.

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a cross-cutting RPC correctness and concurrency fix spanning chain-state locking, arithmetic validation, connection handling, and functional tests, but it does not change consensus, funds movement, cryptography, peer-facing deserialization, or storage migrations.
  • Phase 1 reviewers: not run (skipped for throughput: 13 PRs queued, above the 10 limit)
  • Second Phase-2 pass: on this first full review every Phase-2 reviewer also ran a second, independent time, and the verifier weighed both sets
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort high); agent phase2-reviewer

@thepastaclaw thepastaclaw added the pastaclaw:approved thepastaclaw's latest review approved this PR label Nov 11, 2026
@thepastaclaw thepastaclaw removed the pastaclaw:approved thepastaclaw's latest review approved this PR label Nov 13, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 2 only (queue backlog)

The complete reviewed range is correct and contains no actionable in-scope defects. The RPC input handling, overflow protections, chain locking, active-chain validation, and operatorReward documentation are consistent with the stated fixes; CI has no failed code checks, with build checks still queued.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — The diff changes multiple RPC argument-validation, arithmetic, locking, chain-state, and connection-management paths, but it does not modify consensus, funds movement, cryptography, peer deserialization, or storage migrations.
  • Phase 1 reviewers: not run (skipped for throughput: 13 PRs queued, above the 10 limit)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@thepastaclaw thepastaclaw added the pastaclaw:approved thepastaclaw's latest review approved this PR label Nov 13, 2026
PastaPastaPasta and others added 6 commits November 13, 2026 03:19
…txes

`masternode payments` took std::abs() of the count, which is undefined
for INT64_MIN, and `getspecialtxes` added skip and count, which overflows
for a large count with a non-zero skip. Both abort a -ftrapv build; a
release build of `getspecialtxes` returns an empty list instead of the
remaining transactions.

Also treat an explicit null `masternode payments` count as the default
instead of failing with a type error.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The loop called CChain::Next() after cs_main was released, racing with
tip updates. Collect the block indexes under the lock and serialize
them outside it, as blockheaderToJSON requires.

The count is now validated before the block lookup, so an unknown hash
combined with a bad count reports "Count is out of range".

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
getAddressesFromParams takes either an address string or an object
with an "addresses" array, and the sibling address index RPCs accept
both. getaddressdeltas called get_obj() for its start/end lookup first,
so a plain address string failed with a JSON type error.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Report the usual "P2P functionality missing or disabled" error instead
of dereferencing a null connman.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Explicit start and stop blocks were only looked up in the block index,
so a stale-fork block was accepted. The snapshot walk follows
stop->GetAncestor() while the start snapshot comes from start->pprev,
so endpoints on different branches paired snapshots from unrelated
chains, and the diffs being checked belong to the active chain anyway.

Such endpoints are now rejected with RPC_INVALID_PARAMETER.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Help strings are not format strings, so "%%" was printed literally, and
the value is parsed as a percentage with two decimals (0 to 100), not
as the internal 0 to 10000 representation.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@thepastaclaw thepastaclaw removed the pastaclaw:approved thepastaclaw's latest review approved this PR label Nov 13, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

The pull request’s RPC hardening changes are correct and appropriately scoped. The arithmetic, locking, active-chain validation, argument handling, connection-manager guard, and operator-reward documentation changes are consistent with surrounding code and regression coverage. No code checks have failed; build and sanitizer jobs remain queued in the supplied CI snapshot.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a cross-cutting RPC correctness and concurrency change involving arithmetic edge cases, chain locking, argument validation, and EvoDB behavior, but it does not alter consensus, funds movement, cryptography, networking deserialization, or storage migrations.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@thepastaclaw thepastaclaw added the pastaclaw:approved thepastaclaw's latest review approved this PR label Nov 13, 2026

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@PastaPastaPasta
PastaPastaPasta merged commit f75b6ab into dashpay:develop Nov 13, 2026
52 checks passed
@thepastaclaw thepastaclaw removed the pastaclaw:approved thepastaclaw's latest review approved this PR label Nov 13, 2026
PastaPastaPasta added a commit that referenced this pull request Nov 14, 2026
b534385 chore: prepare v24.0.2 release (pasta)
70e06ae Merge #8117: fix: races in watch-connection seed, partial sig-share batches, and ChainLock shutdown (merge-script)
d50ea34 Merge #8115: fix: free pooled secure allocations with their allocated size (merge-script)
824e58a Merge #8113: fix(wallet): schedule CoinJoin auto-denomination per wallet and guard an empty round list (merge-script)
068529f Merge #8112: fix: answer govsync only to the requesting peer and index replayed orphan votes (merge-script)
484ec63 Merge #8119: fix(stats): wrong inputValue gauge, counter data race, and null-tip crash (merge-script)
28d5711 Merge #8120: fix(utils): accept -printcrashinfo in dash-cli and dash-tx (merge-script)
578b914 Merge bitcoin-core/gui#770: Revert "gui: provide wallet controller context to wallet actions" (Konstantin Akimov)
d6902fa Merge bitcoin-core/gui#765: Fix wallet list hover crash on shutdown (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented

  Backports and release prep for v24.0.2, on top of `v24.0.x` at 137d999 (v24.0.1). One PR carries both, so the release branch gets a single merge.

  Two fixes are the reason for the release:

  - **Memory leak (#8115).** Since v24.0.0 a node's locked-memory use grows for as long as it runs. On `v24.0.x` BLS still uses relic, where a G2 element is 296 bytes; the pooled secure allocator frees such an allocation with one chunk fewer than it allocated. The batch-verification weighting added in v24.0.0 makes one such allocation per verified message, so the pool keeps growing until restart. On develop (blst, 288-byte elements) the same code path does not leak, which is why #8115 describes the bug as latent.
  - **macOS crash on close (#8073's bitcoin-core/gui#765 and gui#770).** On macOS the menu bar stays usable after the main window is hidden for shutdown. `File > Open Wallet`, `Close Wallet` and the other wallet items then call the wallet controller after it has been deleted.

  The rest are small fixes that were already merged on develop and are low risk to carry.

  ## What was done?

  ### Picked

  In develop merge order. The Dash PRs are picked from their develop merge commits with `git cherry-pick -m1 -x`; the two GUI backports are picked with `-x` from the commits #8073 merged, like earlier partial picks on this branch.

  - bitcoin-core/gui#765 Fix wallet list hover crash on shutdown, and bitcoin-core/gui#770, which reverts its first commit (from #8073). Together they leave one change: `appMenuBar->clear()` when shutdown starts.
  - #8120 fix(utils): accept -printcrashinfo in dash-cli and dash-tx
  - #8119 fix(stats): wrong inputValue gauge, counter data race, and null-tip crash
  - #8112 fix: answer govsync only to the requesting peer and index replayed orphan votes
  - #8113 fix(wallet): schedule CoinJoin auto-denomination per wallet and guard an empty round list
  - #8115 fix: free pooled secure allocations with their allocated size
  - #8117 fix: races in watch-connection seed, partial sig-share batches, and ChainLock shutdown

  Then one commit, `chore: prepare v24.0.2 release`:

  - `configure.ac`: `_CLIENT_VERSION_BUILD` 1 → 2.
  - `doc/release-notes.md`: v24.0.2 notes. The v24.0.1 notes are archived verbatim to `doc/release-notes/dash/release-notes-24.0.1.md` and added to "Older releases".
  - `contrib/flatpak/org.dash.dash-core.metainfo.xml`: `24.0.2` entry dated 2026-11-13. The date needs changing if the tag is cut on another day.
  - `doc/man/*.1`: version string only. `-printcrashinfo` (#8120) is a hidden option, so no help text changed.

  ### Adaptations

  Every pick changes the same lines as its develop counterpart except:

  - **#8073:** only the two GUI commits are taken. The other two backports in that PR (bitcoin#28629, partial bitcoin#28639) are test and refactor changes for code `v24.0.x` doesn't need.
  - **#8112:** `test/functional/feature_governance.py` differs on `v24.0.x` (no pruned node from #7860). The `v24.0.x` file is kept and only #8112's additions are applied: the imports it needs, `GovernanceSyncPeer`, `check_govsync_is_peer_local()` and its call. The source change is identical.
  - **#8113:** one line of the new unit test. `v24.0.x` has the five-argument `CWallet` constructor and `CreateMockWalletDatabase()`, so the second wallet is built the way the fixture in the same file builds the first. The source change is identical.
  - **#8117:** in `src/llmq/utils.cpp` the neighbouring includes differ; the pick removes `<atomic>` and adds nothing. The source change is otherwise identical.

  ### Not picked

  - #8111 (check every BIP39 checksum bit): it can refuse a mnemonic that v24.0.1 accepts, so it should come with a major or minor release and a release note, not a patch release.
  - #8118 (RPC argument and locking fixes): changes RPC error behaviour and needs a hand-port to `rpc/masternode.cpp`.
  - #8122 (CacheMultiMap): the use-after-free can't be reached on `v24.0.x`, and the capacity part is hardening with no behaviour change.
  - #8047 (index startup after an unclean stop): on `v24.0.x` a synced node never records the uncommitted tip it handles, and the governance index it mainly covers doesn't exist here.
  - #8092 (wording): changes two translatable strings.
  - #8101, #8102, #8098, #8095 with #8121, #8116 with #7815, #8085: unchanged from the v24.0.1 decision in #8128.
  - Features, refactors, Bitcoin Core backports, CI and test-only changes merged since the branch point.

  #8103 (EvoDB left ahead of the coins DB after a reindex) is a candidate that is still open on develop. If it merges before this PR does, its pick will be added here.

  ## How Has This Been Tested?

  Linux x86_64, depends build with `--enable-debug --enable-werror`, GUI enabled. Head is b534385.

  - `dashd`, `dash-qt`, `test_dash` and `test_dash-qt` build cleanly; `dashd -version` reports `v24.0.2`.
  - `test_dash` (1106 cases), `test_dash-qt` and `test/util/test_runner.py` pass. That includes the picked unit tests: `allocator_tests/mt_pooled_secure_allocator_reuses_all_chunks` (#8115), `coinjoin_tests/coinjoin_maintenance_runs_for_every_wallet` (#8113) and the orphan-vote case in `governance_vote_processing_tests` (#8112).
  - The full functional suite (`test_runner.py -j14`): 312 passed, 12 skipped, 1 failed. The skipped ones are the usual environment-dependent tests (`feature_bind_port_*`, `rpc_bind.py --ipv6`, `interface_usdt_*`, previous-release compatibility and `feature_unsupported_utxo_db.py`). The run includes the scenarios the picks add or extend: `feature_governance.py` (#8112), `feature_stats.py` (#8119) and `interface_bitcoin_cli.py` (#8120).
  - The failure was `feature_llmq_is_cl_conflicts.py`, in `mine_cycle_quorum`: the node logs show the block for the final commitments being built about 40 ms before the second quorum's final commitment reached the mining node, so that quorum was not mined. It is a timing race in the test helper under load, in code none of the picks touch (develop reworked those waits in #7892). Run again on its own four times in parallel, it passed all four.
  - **Leak, end to end.** A regtest script (not part of the tree) mines a single-member InstantSend quorum, sends InstantSend-locked transactions and reads `getmemoryinfo` `locked.used` on each node every 50 locks.
    - The published v24.0.1 Linux binary: the four non-masternode nodes go from 39,568 bytes to 467,664 bytes over 600 locks, and are still growing at the end.
    - This branch: the same nodes stay at 20,096 bytes for all 600 locks.
  - The man pages were regenerated with `contrib/devtools/gen-manpages.py` from this build. They are byte-identical to the committed ones except for the `lock` debug category in `dashd.1` and `dash-qt.1`, which only an `--enable-debug` build lists.
  - The archived v24.0.1 notes are byte-identical to the previous `doc/release-notes.md`.

  Not tested: the macOS shutdown crash itself. The GUI change is the upstream one-liner and was built and run through `test_dash-qt` on Linux only.

  ## Breaking Changes

  None. No consensus change, and no change to which P2P messages a node accepts or how it scores peers. A node that syncs governance from a v24.0.2 node receives the same inventories as before; other peers of that node no longer receive them.

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(if you have permission to set one)_

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

Top commit has no ACKs.

Tree-SHA512: 6d9861f4a8c2341889bb0ce5dd500a7083ea59395777a21c5e5d01e70ec8e8b489cf6425bc26ca79f15b1919610ceab10baada361043322dc689b7dfcae7cb5d
@PastaPastaPasta
PastaPastaPasta deleted the fix/rpc-input-locking branch November 18, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants