Skip to content

refactor: cleaned abci execution module - #1039

Merged
QuantumExplorer merged 2 commits into
v0.25-devfrom
refactor/cleanAbci
May 8, 2023
Merged

QuantumExplorer merged 2 commits into
v0.25-devfrom
refactor/cleanAbci

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

What was done?

Moved some files around and added documentation comments.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

identity,
operations,
}
| ExecutionEvent::PaidDriveEvent {

@antouhou antouhou May 8, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to this PR, but generally for the future - I'm wondering if there's a DriveEvent suffix, do you think it might be valuable to create a separate enum for the DriveEvent?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand your question.

@QuantumExplorer
QuantumExplorer merged commit fb1c28d into v0.25-dev May 8, 2023
@QuantumExplorer
QuantumExplorer deleted the refactor/cleanAbci branch May 8, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants