Repository navigation
ci: re-pin PR Hygiene to read each pull request once - #1029
Merged
Merged
Conversation
Rebuilding an author slots already read every candidate comments and latest inactive transition in one batched query, and the snapshot that followed read both again over REST. A reconcile of one platform pull request drops from 38 requests to 25. Also carries gh own message when an API call fails, instead of only its exit code, and keeps a GraphQL reply that only partly resolved. dashpay/stale_prs_are_bad#28 and #29 landed as 1ef768028f88b7f662fb260d9f8ba33fc0e48a44. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the reusable PR review workflow reference in the policy workflow to a newer commit. ChangesReview workflow update
Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1029 +/- ##
==========================================
+ Coverage 77.20% 77.37% +0.16%
==========================================
Files 329 329
Lines 83862 83862
==========================================
+ Hits 64747 64887 +140
+ Misses 19115 18975 -140
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins the shared review workflow onto dashpay/stale_prs_are_bad#28 and #29.
Each pull request is read once, not twice. Rebuilding an author's review slots already reads every candidate's comments and latest inactive transition in one batched query — and the snapshot that followed read both again over REST, the comments a second time and a walk of the whole issue timeline, which pages once per hundred events. A reconcile of one platform pull request drops from 38 requests to 25.
That matters here specifically: the failures this workflow produced on 14 and 15 September were
API rate limit exceeded for installation, and the fix for them is spending fewer requests. Platform went 13 failures on the 14th, 20 on the 15th, 3 on the 16th — all before that morning's re-pin — and none since.A failure now says what went wrong. The engine reported only
GitHub API command failed (exit 1), discarding gh's own message, so diagnosing one meant re-running the query by hand. It now carries what gh printed.A GraphQL reply that only partly resolved is kept. gh exits non-zero whenever a response carries any errors array, even when the data is complete and only one aliased field is null. The tolerance written for that case had never executed.
Verified before this round: the batched and per-pull-request reads are byte-identical across 38 open pull requests in all five repositories, and a full report of platform reaches the same verdict on all 29 of its pull requests.
No change to who may approve, when a pull request is ready, or what blocks it. The only line that differs here is the pinned engine revision.
🤖 Generated with Claude Code
Summary by CodeRabbit