Skip to content

ci: re-pin PR Hygiene to read each pull request once - #1029

Merged
shumkov merged 1 commit into
devfrom
chore/pr-hygiene-read-once-dev
Sep 16, 2026
Merged

shumkov merged 1 commit into
devfrom
chore/pr-hygiene-read-once-dev

Conversation

@shumkov

@shumkov shumkov commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Re-pins the shared review workflow onto dashpay/stale_prs_are_bad#28 and #29.

Each pull request is read once, not twice. Rebuilding an author's review slots already reads every candidate's comments and latest inactive transition in one batched query — and the snapshot that followed read both again over REST, the comments a second time and a walk of the whole issue timeline, which pages once per hundred events. A reconcile of one platform pull request drops from 38 requests to 25.

That matters here specifically: the failures this workflow produced on 14 and 15 September were API rate limit exceeded for installation, and the fix for them is spending fewer requests. Platform went 13 failures on the 14th, 20 on the 15th, 3 on the 16th — all before that morning's re-pin — and none since.

A failure now says what went wrong. The engine reported only GitHub API command failed (exit 1), discarding gh's own message, so diagnosing one meant re-running the query by hand. It now carries what gh printed.

A GraphQL reply that only partly resolved is kept. gh exits non-zero whenever a response carries any errors array, even when the data is complete and only one aliased field is null. The tolerance written for that case had never executed.

Verified before this round: the batched and per-pull-request reads are byte-identical across 38 open pull requests in all five repositories, and a full report of platform reaches the same verdict on all 29 of its pull requests.

No change to who may approve, when a pull request is ready, or what blocks it. The only line that differs here is the pinned engine revision.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the automated pull request review workflow to use a newer version.

Rebuilding an author slots already read every candidate comments and latest
inactive transition in one batched query, and the snapshot that followed read
both again over REST. A reconcile of one platform pull request drops from 38
requests to 25.

Also carries gh own message when an API call fails, instead of only its exit
code, and keeps a GraphQL reply that only partly resolved.

dashpay/stale_prs_are_bad#28 and #29 landed as 1ef768028f88b7f662fb260d9f8ba33fc0e48a44.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 8028ed0f-6ccb-4900-8637-c375bac6ba61

📥 Commits

Reviewing files that changed from the base of the PR and between ed0df9d and addc1c1.

📒 Files selected for processing (1)
  • .github/workflows/pr-review-policy.yml

📝 Walkthrough

Walkthrough

The PR updates the reusable PR review workflow reference in the policy workflow to a newer commit.

Changes

Review workflow update

Layer / File(s) Summary
Update reusable workflow reference
.github/workflows/pr-review-policy.yml
The policy job now references commit 1ef768028f88b7f662fb260d9f8ba33fc0e48a44 instead of commit b378d1d7f9c3949a5f73822362ca02d251ab8141.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/pr-hygiene-read-once-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shumkov
shumkov merged commit 7f77e16 into dev Sep 16, 2026
31 of 32 checks passed
@shumkov
shumkov deleted the chore/pr-hygiene-read-once-dev branch September 16, 2026 18:03
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.37%. Comparing base (ed0df9d) to head (addc1c1).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1029      +/-   ##
==========================================
+ Coverage   77.20%   77.37%   +0.16%     
==========================================
  Files         329      329              
  Lines       83862    83862              
==========================================
+ Hits        64747    64887     +140     
+ Misses      19115    18975     -140     
Flag Coverage Δ
core 78.24% <ø> (ø)
ffi 52.36% <ø> (+1.42%) ⬆️
rpc 20.00% <ø> (ø)
spv 92.02% <ø> (-0.05%) ⬇️
wallet 79.79% <ø> (ø)
see 19 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant