Repository navigation
fix(dash): only decode a special payload from transaction version 3 - #1155
Conversation
Core reads the version as an int16_t and a payload only when nVersion >= 3 and nType != 0. Below version 3, non-zero type bits are kept as ClassicalWithNonStandardVersionTypeBytes, without a payload. Closes #1135 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1155 +/- ##
==========================================
- Coverage 78.49% 78.46% -0.03%
==========================================
Files 299 299
Lines 80213 80214 +1
==========================================
- Hits 62960 62943 -17
- Misses 17253 17271 +18
|
Closes #1135. Part of #1047.
Core reads
vExtraPayloadonly whennVersion >= 3 && nType != 0, withnVersionread as anint16_t. We read a payload wheneverversion != 0, so a version 1 or 2 transaction (or one with a negative version) with non-zero type bits misaligned the rest of the block.version as i16 >= 3. Below that, non-zero type bits are kept asClassicalWithNonStandardVersionTypeBytes, without a payload, as for version 0.0xffff.🤖 Generated with Claude Code
PR Hygiene ·
855a71f/skip-botsproceeds without the ones not yet reported/self-revieweddash/src/blockdata/transaction/mod.rs) — QuantumExplorer or xdustinfaceWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.