Skip to content

fix(dash): set LLMQ params to Dash Core's values - #1187

Merged
xdustinface merged 1 commit into
devfrom
fix/llmq-params-core
Oct 16, 2026
Merged

xdustinface merged 1 commit into
devfrom
fix/llmq-params-core

Conversation

@ZocoLini

@ZocoLini ZocoLini commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

LLMQType::params() disagreed with Dash Core's src/llmq/params.h (compared field by field against master):

Type Field Was Core
llmq_test_platform DKG interval 288 24
llmq_devnet_platform DKG interval 288 24
llmq_devnet_dip0024 mining window 10–18 12–20
llmq_test size 4 3
llmq_devnet keepOldConnections 4 5
llmq_devnet_platform keepOldConnections, recoveryMembers 4, 3 5, 6
llmq_devnet_platform name llmq_dev_platform llmq_devnet_platform

Parsing already accepted both names for the devnet platform type.

Closes #1180

🤖 Generated with Claude Code

PR Hygiene · 8e12eb0

  • Bots — coderabbitai not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed
  • Build running
  • Approvals
    • files with no dedicated owner (dash/src/sml/llmq_type/mod.rs) — QuantumExplorer or xdustinface

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

`LLMQType::params()` disagreed with Dash Core's `src/llmq/params.h`:

- llmq_test_platform, llmq_devnet_platform: DKG interval 24, not 288.
- llmq_devnet_dip0024: mining window 12 to 20, not 10 to 18.
- llmq_test: size 3, not 4.
- llmq_devnet: keepOldConnections 5, not 4.
- llmq_devnet_platform: keepOldConnections 5, recoveryMembers 6, and its
  name is llmq_devnet_platform.

Closes #1180

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: dashpay/rust-dashcore/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fa356cce-3ab2-424c-85c5-302e6fc66a20
📥 Commits

Reviewing files that changed from the base of the PR and between c4535d4 and 8e12eb0.

📒 Files selected for processing: 1
  • dash/src/sml/llmq_type/mod.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 16, 2026
@ZocoLini
ZocoLini requested a review from xdustinface October 16, 2026 12:53
@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.87%. Comparing base (a52586f) to head (8e12eb0).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1187      +/-   ##
==========================================
- Coverage   78.88%   78.87%   -0.01%     
==========================================
  Files         304      304              
  Lines       81410    81410              
==========================================
- Hits        64222    64214       -8     
- Misses      17188    17196       +8     
Flag Coverage Δ
core 77.59% <ø> (ø)
ffi 50.80% <ø> (ø)
rpc 52.05% <ø> (ø)
spv 92.79% <ø> (-0.04%) ⬇️
wallet 82.19% <ø> (ø)
Files with missing lines Coverage Δ
dash/src/sml/llmq_type/mod.rs 79.44% <ø> (ø)

... and 4 files with indirect coverage changes

@xdustinface
xdustinface merged commit f35115b into dev Oct 16, 2026
36 of 37 checks passed
@xdustinface
xdustinface deleted the fix/llmq-params-core branch October 16, 2026 14:18
xdustinface pushed a commit that referenced this pull request Oct 21, 2026
`LLMQType::params()` disagreed with Dash Core's `src/llmq/params.h`:

- llmq_test_platform, llmq_devnet_platform: DKG interval 24, not 288.
- llmq_devnet_dip0024: mining window 12 to 20, not 10 to 18.
- llmq_test: size 3, not 4.
- llmq_devnet: keepOldConnections 5, not 4.
- llmq_devnet_platform: keepOldConnections 5, recoveryMembers 6, and its
  name is llmq_devnet_platform.

Closes #1180

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit f35115b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LLMQ params table disagrees with Dash Core for llmq_test_platform, llmq_devnet_platform and llmq_devnet_dip0024

2 participants