Repository navigation
fix(dash): set LLMQ params to Dash Core's values - #1187
Conversation
`LLMQType::params()` disagreed with Dash Core's `src/llmq/params.h`: - llmq_test_platform, llmq_devnet_platform: DKG interval 24, not 288. - llmq_devnet_dip0024: mining window 12 to 20, not 10 to 18. - llmq_test: size 3, not 4. - llmq_devnet: keepOldConnections 5, not 4. - llmq_devnet_platform: keepOldConnections 5, recoveryMembers 6, and its name is llmq_devnet_platform. Closes #1180 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1187 +/- ##
==========================================
- Coverage 78.88% 78.87% -0.01%
==========================================
Files 304 304
Lines 81410 81410
==========================================
- Hits 64222 64214 -8
- Misses 17188 17196 +8
|
`LLMQType::params()` disagreed with Dash Core's `src/llmq/params.h`: - llmq_test_platform, llmq_devnet_platform: DKG interval 24, not 288. - llmq_devnet_dip0024: mining window 12 to 20, not 10 to 18. - llmq_test: size 3, not 4. - llmq_devnet: keepOldConnections 5, not 4. - llmq_devnet_platform: keepOldConnections 5, recoveryMembers 6, and its name is llmq_devnet_platform. Closes #1180 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f35115b)
LLMQType::params()disagreed with Dash Core'ssrc/llmq/params.h(compared field by field againstmaster):llmq_test_platformllmq_devnet_platformllmq_devnet_dip0024llmq_testllmq_devnetllmq_devnet_platformllmq_devnet_platformllmq_dev_platformllmq_devnet_platformParsing already accepted both names for the devnet platform type.
Closes #1180
🤖 Generated with Claude Code
PR Hygiene ·
8e12eb0/skip-botsproceeds without the ones not yet reported/self-revieweddash/src/sml/llmq_type/mod.rs) — QuantumExplorer or xdustinfaceWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.