Repository navigation
fix(dash-spv): build with bip324 0.11.1 - #1310
Conversation
bip324 0.11.1's async `handshake` also returns the session id, so a fresh resolve of `bip324 = "0.11"` no longer compiles `dash-spv` (peer.rs:407, E0308). Destructure the fourth field and require 0.11.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post |
|
Bots are done — your move: post |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1310 +/- ##
==========================================
+ Coverage 77.26% 82.17% +4.90%
==========================================
Files 194 290 +96
Lines 53827 76392 +22565
==========================================
+ Hits 41590 62775 +21185
- Misses 12237 13617 +1380
|
Problem
dash-spvno longer builds on a fresh resolve. bip324 0.11.1 (released 2026-11-03) adds the session id to the tuple thatbip324::futures::handshakereturns, and the workspace asks forbip324 = "0.11", so cargo picks 0.11.1:This breaks every job that builds
dash-spvondev, starting with run 41738522737 (2ddafdf): Documentation, MSRV and the spv groups on Ubuntu, Ubuntu ARM, macOS and Windows.Fix
peer.rsand thev2_transporttest's mock responder take the fourth field and ignore it.bip324 = "0.11.1", since the four-field form doesn't build against 0.11.0.The other 0.11.1 change,
Handshake::new_with_rngtaking aVerificationcontext, doesn't affectdash-spv, which only callshandshake.Changelog
Tests
cargo clippy -p dash-spv --all-targets -- -D warnings, with and without--all-features.cargo test -p dash-spv --all-features --test v2_transport: 7 passed.cargo test -p dash-spv --all-features --lib: 630 passed.RUSTDOCFLAGS="-D warnings" cargo doc -p dash-spv --all-features --no-deps.🤖 Generated with Claude Code
PR Hygiene ·
13c2ac4/self-reviewedCargo.toml) — QuantumExplorer or ZocoLini or xdustinfacedash-spv(dash-spv/src/network/peer.rs,dash-spv/tests/v2_transport.rs) — QuantumExplorer or ZocoLini or xdustinfaceWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.Summary by CodeRabbit