Skip to content

fix(dash-spv): build with bip324 0.11.1 - #1310

Merged
xdustinface merged 1 commit into
devfrom
pasta/spv-bip324-0-11-1
Nov 4, 2026
Merged

xdustinface merged 1 commit into
devfrom
pasta/spv-bip324-0-11-1

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Problem

dash-spv no longer builds on a fresh resolve. bip324 0.11.1 (released 2026-11-03) adds the session id to the tuple that bip324::futures::handshake returns, and the workspace asks for bip324 = "0.11", so cargo picks 0.11.1:

error[E0308]: mismatched types
   --> dash-spv/src/network/peer.rs:407:19
    = note: expected tuple `(InboundCipher, OutboundCipher, ProtocolSessionReader<OwnedReadHalf>, SessionId)`

This breaks every job that builds dash-spv on dev, starting with run 41738522737 (2ddafdf): Documentation, MSRV and the spv groups on Ubuntu, Ubuntu ARM, macOS and Windows.

Fix

  • peer.rs and the v2_transport test's mock responder take the fourth field and ignore it.
  • The workspace requires bip324 = "0.11.1", since the four-field form doesn't build against 0.11.0.

The other 0.11.1 change, Handshake::new_with_rng taking a Verification context, doesn't affect dash-spv, which only calls handshake.

Changelog

  • dash-spv: builds with bip324 0.11.1, which is now the minimum version.

Tests

  • cargo clippy -p dash-spv --all-targets -- -D warnings, with and without --all-features.
  • cargo test -p dash-spv --all-features --test v2_transport: 7 passed.
  • cargo test -p dash-spv --all-features --lib: 630 passed.
  • RUSTDOCFLAGS="-D warnings" cargo doc -p dash-spv --all-features --no-deps.

🤖 Generated with Claude Code

PR Hygiene · 13c2ac4

  • Bots — coderabbitai ✓
  • Self-review — post /self-reviewed
  • Build running
  • Approvals
    • files with no dedicated owner (Cargo.toml) — QuantumExplorer or ZocoLini or xdustinface
    • dash-spv (dash-spv/src/network/peer.rs, dash-spv/tests/v2_transport.rs) — QuantumExplorer or ZocoLini or xdustinface

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • Chores
    • Updated the network transport implementation and its test coverage alongside an underlying library version update. No user-facing behavior changes are included in this release.

bip324 0.11.1's async `handshake` also returns the session id, so a
fresh resolve of `bip324 = "0.11"` no longer compiles `dash-spv`
(peer.rs:407, E0308). Destructure the fourth field and require 0.11.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The workspace updates bip324 from 0.11 to 0.11.1. The peer handshake and V2 transport mock bind the added session-ID return value; neither uses it.

Changes: BIP324 Handshake Compatibility

Layer / File(s) Summary
Dependency and handshake callers
Cargo.toml, dash-spv/src/network/peer.rs, dash-spv/tests/v2_transport.rs
The workspace dependency changes to bip324 0.11.1. The peer handshake and test mock bind the returned session ID and do not use it.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: xdustinface

Merge Risk: Minimal · up to 13c2a

No actionable regression or unresolved merge risk is established by this change.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the build fix and the dependency version update to bip324 0.11.1, which matches the main changes.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2ddafdf and 13c2ac4.

Files selected for processing: 3
  • Cargo.toml
  • dash-spv/src/network/peer.rs
  • dash-spv/tests/v2_transport.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed and removed waiting-bots Waiting for the review bots to report on this head labels Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.17%. Comparing base (2ddafdf) to head (13c2ac4).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1310      +/-   ##
==========================================
+ Coverage   77.26%   82.17%   +4.90%     
==========================================
  Files         194      290      +96     
  Lines       53827    76392   +22565     
==========================================
+ Hits        41590    62775   +21185     
- Misses      12237    13617    +1380     
Flag Coverage Δ
core 82.00% <ø> (ø)
ffi 60.37% <ø> (ø)
rpc 52.10% <ø> (ø)
spv 93.88% <100.00%> (?)
wallet 83.13% <ø> (ø)
Files with missing lines Coverage Δ
dash-spv/src/network/peer.rs 88.94% <100.00%> (ø)

... and 95 files with indirect coverage changes

@xdustinface
xdustinface merged commit 6635735 into dev Nov 4, 2026
43 of 44 checks passed
@xdustinface
xdustinface deleted the pasta/spv-bip324-0-11-1 branch November 4, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-self-review Waiting for the author to post /self-reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants