Repository navigation
chore: drop dashcore::FeeRate - #482
Conversation
📝 WalkthroughWalkthroughThe PR removes the entire Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
xdustinface
left a comment
There was a problem hiding this comment.
Agree we shouldn't double keep FeeRate but i think it should still live in dash crate not key-wallet as dash is where the core primitives live and so other crates like rpc-client will still be able to use it without depending on key-wallet. I think you should move the one from key-wallet into dash.
|
I strongly disagree.
It makes more sense to have all those pieces together in dashcore than in key-wallet but that is not the way is designed right now. After i finish fixing the transaction building logic and coin selection I would agree in moving everything into dashcore (my rewrite/fix is moving that stuff into the same module so it will be easy to move it after) |
dashcore::FeeRate
We already have the FeeRate struct in KeyWallet, there is no point in maintaining twice the same struct
Summary by CodeRabbit
Release Notes