Skip to content

chore: fix codecov uploads - #494

Merged
QuantumExplorer merged 1 commit into
v0.42-devfrom
chore/fix-coverage-uploads
Mar 4, 2026
Merged

QuantumExplorer merged 1 commit into
v0.42-devfrom
chore/fix-coverage-uploads

Conversation

@xdustinface

@xdustinface xdustinface commented Mar 4, 2026 •

Copy link
Copy Markdown
Collaborator

Codecov requires one flag per upload. Switch from per-crate flags to group-based flags matching CI matrix groups (core, spv, wallet, ffi, rpc). Exclude the tools group from coverage since fuzz targets produce unusable reports.

Summary by CodeRabbit

  • Chores
    • Reorganized coverage collection into logical component groups (core, spv, wallet, ffi, rpc) for clearer reporting.
    • Excluded tools from coverage collection to focus metrics on primary components.
    • Updated coverage documentation to reflect the new grouping structure.

Codecov requires one flag per upload. Switch from per-crate flags
to group-based flags matching CI matrix groups (core, spv, wallet, ffi,
rpc). Exclude the tools group from coverage since fuzz targets produce
unusable reports.
@coderabbitai

coderabbitai Bot commented Mar 4, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 09b46085-7c7e-4384-928a-f8f0145a8562

📥 Commits

Reviewing files that changed from the base of the PR and between ab17348 and a261a3e.

📒 Files selected for processing (5)
  • .codecov.yml
  • .github/ci-groups.yml
  • .github/scripts/ci_config.py
  • .github/workflows/build-and-test.yml
  • README.md

📝 Walkthrough

Walkthrough

These changes reorganize coverage tracking from individual crates to grouped categories across configuration files and documentation. A new no_coverage configuration option is introduced to exclude specific groups from coverage collection, with corresponding updates to CI scripts and build workflows to enforce these exclusions.

Changes

Cohort / File(s) Summary
Coverage Configuration Reorganization
.codecov.yml, README.md
Replaced individual per-crate coverage flags with grouped categories (core, spv, wallet, ffi, rpc). Coverage table in README updated from per-crate rows to group-based entries with aggregated crate lists.
CI Group Configuration
.github/ci-groups.yml
Added new no_coverage CI group containing the tools member to exclude it from coverage collection.
CI Script and Workflow Updates
.github/scripts/ci_config.py, .github/workflows/build-and-test.yml
Added logic to read no_coverage configuration and conditionally suppress coverage output and llvm-cov commands for excluded groups. Coverage report generation now depends on both coverage flag and non-empty crate_flags output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 From many flags to grouped delight,
Coverage organized, shining bright,
Some groups excluded, some full of care,
A hopping improvement beyond compare! 🎯

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: fix codecov uploads' directly addresses the main change: updating codecov upload configuration from per-crate flags to group-based flags to comply with codecov's one-flag-per-upload requirement.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-coverage-uploads

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer
QuantumExplorer merged commit 6971963 into v0.42-dev Mar 4, 2026
53 checks passed
@xdustinface
xdustinface deleted the chore/fix-coverage-uploads branch March 4, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants