Repository navigation
chore: remove dead dash/embedded crate and unused fuzz/Cargo.lock - #773
Conversation
`dash/embedded` has been non-buildable since #521 dropped `no-std` support from `dashcore`: it requests a `dashcore` `no-std` feature that no longer exists, so its committed `Cargo.lock` can no longer be regenerated. That stale lockfile was the source of Dependabot security alerts (`linked_list_allocator` 0.8.11, RUSTSEC-2022-0063 out-of-bounds writes, pulled via the abandoned `alloc-cortex-m`, plus the yanked `core2`). The example is not a member of the root workspace and is not built in CI, so it is dead code. `fuzz` is a member of the root workspace, so cargo always resolves it against the gitignored root `Cargo.lock`. The committed `fuzz/Cargo.lock` is never read by any build (confirmed via `cargo locate-project --workspace`) and only served to surface Dependabot advisories (`atty`, `ansi_term`, `memmap`) for a file nothing uses. Removing both eliminates the Dependabot alerts at their source with no behavior change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (6)
📝 WalkthroughWalkthroughThis PR removes the embedded ARM firmware infrastructure from the dash crate, including the Cargo manifest, linker memory configuration, build environment setup scripts, dependency installation script, Rust firmware entrypoint with allocator and panic handlers, and "Running" instructions from the README. ChangesEmbedded Firmware Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #773 +/- ##
=============================================
+ Coverage 72.62% 72.68% +0.06%
=============================================
Files 320 320
Lines 70254 70333 +79
=============================================
+ Hits 51022 51123 +101
+ Misses 19232 19210 -22
|
dash/embeddedhas been non-buildable since #521 droppedno-stdsupport fromdashcore: it requests adashcoreno-stdfeature that no longer exists, so its committedCargo.lockcan no longer be regenerated. That stale lockfile was the source of Dependabot security alerts (linked_list_allocator0.8.11, RUSTSEC-2022-0063 out-of-bounds writes, pulled via the abandonedalloc-cortex-m, plus the yankedcore2). The example is not a member of the root workspace and is not built in CI, so it is dead code.fuzzis a member of the root workspace, so cargo always resolves it against the gitignored rootCargo.lock. The committedfuzz/Cargo.lockis never read by any build (confirmed viacargo locate-project --workspace) and only served to surface Dependabot advisories (atty,ansi_term,memmap) for a file nothing uses.Removing both eliminates the Dependabot alerts at their source with no behavior change.
Summary by CodeRabbit