Skip to content

chore: remove dead dash/embedded crate and unused fuzz/Cargo.lock - #773

Merged
xdustinface merged 1 commit into
v0.42-devfrom
chore/remove-dead-embedded-fuzz-lockfiles
May 18, 2026
Merged

xdustinface merged 1 commit into
v0.42-devfrom
chore/remove-dead-embedded-fuzz-lockfiles

Conversation

@xdustinface

@xdustinface xdustinface commented May 17, 2026 •

Copy link
Copy Markdown
Collaborator

dash/embedded has been non-buildable since #521 dropped no-std support from dashcore: it requests a dashcore no-std feature that no longer exists, so its committed Cargo.lock can no longer be regenerated. That stale lockfile was the source of Dependabot security alerts (linked_list_allocator 0.8.11, RUSTSEC-2022-0063 out-of-bounds writes, pulled via the abandoned alloc-cortex-m, plus the yanked core2). The example is not a member of the root workspace and is not built in CI, so it is dead code.

fuzz is a member of the root workspace, so cargo always resolves it against the gitignored root Cargo.lock. The committed fuzz/Cargo.lock is never read by any build (confirmed via cargo locate-project --workspace) and only served to surface Dependabot advisories (atty, ansi_term, memmap) for a file nothing uses.

Removing both eliminates the Dependabot alerts at their source with no behavior change.

Summary by CodeRabbit

  • Chores
    • Removed embedded build system and related infrastructure, including build configuration, environment setup scripts, linker definitions, and associated documentation.

Review Change Stack

`dash/embedded` has been non-buildable since #521 dropped `no-std` support from `dashcore`: it requests a `dashcore` `no-std` feature that no longer exists, so its committed `Cargo.lock` can no longer be regenerated. That stale lockfile was the source of Dependabot security alerts (`linked_list_allocator` 0.8.11, RUSTSEC-2022-0063 out-of-bounds writes, pulled via the abandoned `alloc-cortex-m`, plus the yanked `core2`). The example is not a member of the root workspace and is not built in CI, so it is dead code.

`fuzz` is a member of the root workspace, so cargo always resolves it against the gitignored root `Cargo.lock`. The committed `fuzz/Cargo.lock` is never read by any build (confirmed via `cargo locate-project --workspace`) and only served to surface Dependabot advisories (`atty`, `ansi_term`, `memmap`) for a file nothing uses.

Removing both eliminates the Dependabot alerts at their source with no behavior change.
@coderabbitai

coderabbitai Bot commented May 17, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e8f201de-4b2f-488d-9345-de78dceb44f3

📥 Commits

Reviewing files that changed from the base of the PR and between cfb01fa and f312c84.

⛔ Files ignored due to path filters (2)
  • dash/embedded/Cargo.lock is excluded by !**/*.lock
  • fuzz/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • dash/embedded/Cargo.toml
  • dash/embedded/README.md
  • dash/embedded/memory.x
  • dash/embedded/scripts/env.sh
  • dash/embedded/scripts/install-deps
  • dash/embedded/src/main.rs
💤 Files with no reviewable changes (6)
  • dash/embedded/memory.x
  • dash/embedded/scripts/env.sh
  • dash/embedded/scripts/install-deps
  • dash/embedded/Cargo.toml
  • dash/embedded/README.md
  • dash/embedded/src/main.rs

📝 Walkthrough

Walkthrough

This PR removes the embedded ARM firmware infrastructure from the dash crate, including the Cargo manifest, linker memory configuration, build environment setup scripts, dependency installation script, Rust firmware entrypoint with allocator and panic handlers, and "Running" instructions from the README.

Changes

Embedded Firmware Removal

Layer / File(s) Summary
Embedded firmware infrastructure cleanup
dash/embedded/Cargo.toml, dash/embedded/README.md, dash/embedded/memory.x, dash/embedded/scripts/env.sh, dash/embedded/scripts/install-deps, dash/embedded/src/main.rs
Removes the embedded ARM firmware module entirely: cargo manifest with package metadata and dependencies, linker memory layout, environment variable exports for rustflags and QEMU runner configuration, dependency installation script, firmware entrypoint with heap allocator and panic/alloc error handlers, and build/run documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops away from embedded code,
No more firmware on this rocky road,
Memory maps and linkers fade to dust,
Cleanup complete—in removals we trust! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing the dead dash/embedded crate and unused fuzz/Cargo.lock file, which aligns perfectly with the raw summary showing complete removal of all dash/embedded files and implicit removal of fuzz/Cargo.lock.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-dead-embedded-fuzz-lockfiles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xdustinface
xdustinface requested a review from ZocoLini May 17, 2026 12:00
@codecov

codecov Bot commented May 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.68%. Comparing base (bbf0a9c) to head (f312c84).
⚠️ Report is 1 commits behind head on v0.42-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #773      +/-   ##
=============================================
+ Coverage      72.62%   72.68%   +0.06%     
=============================================
  Files            320      320              
  Lines          70254    70333      +79     
=============================================
+ Hits           51022    51123     +101     
+ Misses         19232    19210      -22     
Flag Coverage Δ
core 76.30% <ø> (ø)
ffi 49.16% <ø> (+0.75%) ⬆️
rpc 20.00% <ø> (ø)
spv 89.92% <ø> (-0.06%) ⬇️
wallet 71.27% <ø> (-0.01%) ⬇️
see 9 files with indirect coverage changes

@github-actions github-actions Bot added the ready-for-review CodeRabbit has approved this PR label May 17, 2026
@xdustinface
xdustinface merged commit d4c669d into v0.42-dev May 18, 2026
38 checks passed
@xdustinface
xdustinface deleted the chore/remove-dead-embedded-fuzz-lockfiles branch May 18, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review CodeRabbit has approved this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants