Skip to content

test_matrix_norm incorrect sampling #114

Closed
#116
Closed
test_matrix_norm incorrect sampling#114
#116

Description

@bicycleman15
bicycleman15
opened on Apr 19, 2022

array-api-tests/array_api_tests/test_linalg.py

Line 318 in 9816011

ord=sampled_from([-float('inf'), -2, -2, 1, 2, float('inf'), 'fro', 'nuc']))

Shouldn't we also sample -1, right now we are sampling -2 twice, seems to me like one of those -2 should be -1. I might be wrong tho.

I am happy to make a PR for the same :)

Activity

  1. honno
    assigned
    asmeurer
    on Apr 19, 2022

  2. honno commented on Apr 19, 2022

    @honno
    honno
    on Apr 19, 2022
    Member

    Thanks for pointing this out @bicycleman15, yea you're right. Would hold of a PR incase @asmeurer was going to rework test_matrix_norm in #101 anywho. Eh I'll just fix it now heh.

  3. honno
    unassigned
    asmeurer
    on Apr 21, 2022
  4. honno
    closed this as completedin #116on Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions