Repository navigation
EPA_GHGRPFacilities_EPA_GHGRP_ParentCompanies_Ownership_refresh - #2271
Open
balit-raibot wants to merge 10 commits into
Open
balit-raibot wants to merge 10 commits into
balit-raibot wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the EPA facility processing scripts to use the consolidated PUB_DIM_FACILITY table, introducing row deduplication, coordinate cleaning, and pre-fetching of GeoJSON and county candidates to optimize performance. It also adds robust error handling, caching, and unit tests. Feedback on these changes highlights a bug where caching a single _oris_df across different years will incorrectly reuse the first year's crosswalk data, and suggests caching by year instead. Additionally, using continue instead of break is recommended when skipping existing downloads to ensure other years are still checked, and the private _COUNTY_CANDIDATES_CACHE should not be accessed directly.
…ies_Ownership_refresh
…ies_Ownership_refresh
…_refresh' of https://github.com/balit-raibot/data into EPA_GHGRPFacilities_EPA_GHGRP_ParentCompanies_Ownership_refresh
…ies_Ownership_refresh
…_refresh' of https://github.com/balit-raibot/data into EPA_GHGRPFacilities_EPA_GHGRP_ParentCompanies_Ownership_refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.