Repository navigation
JiT Worker in CLI and RPC infrastructure - #2109
Merged
Merged
Conversation
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
from
March 9, 2026 19:55
a08d4da to
01fa6ba
Compare
rafal-hawrylak
marked this pull request as ready for review
March 9, 2026 19:59
rafal-hawrylak
enabled auto-merge (squash)
March 9, 2026 19:59
kolina
requested changes
Mar 10, 2026
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
from
March 10, 2026 14:39
01fa6ba to
33b9f19
Compare
ikholopov-omni
requested changes
Mar 11, 2026
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
10 times, most recently
from
March 12, 2026 15:50
a05cf58 to
be56edb
Compare
kolina
requested changes
Mar 14, 2026
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
5 times, most recently
from
March 27, 2026 18:00
9ca1f45 to
0fe90aa
Compare
kolina
reviewed
Mar 28, 2026
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
2 times, most recently
from
March 29, 2026 08:40
c6650a7 to
22d3661
Compare
rafal-hawrylak
commented
Mar 29, 2026
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
3 times, most recently
from
March 30, 2026 11:01
38433f2 to
e687190
Compare
kolina
reviewed
Apr 3, 2026
kolina
reviewed
Apr 11, 2026
kolina
left a comment
Contributor
There was a problem hiding this comment.
The current PR LGTM, there are a couple of questions about diffs in BigQuery adapters.
After they're responded, I can approve from my side
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
from
May 14, 2026 19:01
20fffc4 to
b104030
Compare
Collaborator
|
@kolina can you take a look here? |
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
from
May 19, 2026 13:35
b104030 to
3cc37de
Compare
kolina
approved these changes
May 19, 2026
apilaskowski
approved these changes
May 20, 2026
ikholopov-omni
requested changes
May 20, 2026
ikholopov-omni
left a comment
Collaborator
There was a problem hiding this comment.
Overall LGTM, feel free to submit once the comments are addressed.
* feat: add worker process management for JiT compilation - Introduce base worker and JiT-specific child process logic - Implement RPC bridge for database access during JiT - Add VM scripts and loader for isolated execution - Add unit tests for the RPC mechanism
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
from
May 20, 2026 09:55
3cc37de to
2f917ba
Compare
rafal-hawrylak
force-pushed
the
cli_jit_workers
branch
from
May 20, 2026 10:08
2f917ba to
271e6e6
Compare
Collaborator
Author
Addressed. However the merged is blocked due to request for a change. |
ikholopov-omni
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change establishes the foundation for executing JiT compilation in an isolated environment. It introduces the worker process management, the RPC bridge for database access during JiT, and the necessary Bazel targets.