Repository navigation
fix(ci): skip already-published dependency packages in conda uploads - #381
Merged
Merged
Conversation
An extensions-only release rebuilds the ROS message packages next to unilabos-ros2 and unilabos-full. When the message version is unchanged, the rebuilt files already exist on the uni-lab channel, so the first upload returns 409 and the job stops before unilabos-full is uploaded. The 0.13.0a1 ROS 2 / full upload stopped exactly there on all four platforms. Only the framework platform packages (unilabos, unilabos-full) must be new on every release. Every other package is a reused dependency and now uploads with --skip-existing, as noarch packages and mcp already did. Nothing is overwritten: --force is never passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The manual ROS 2 / full upload for v0.13.0a1 (run 44541199446) failed on all four platforms at "Upload packages after successful tests":
An extensions-only build rebuilds the message packages (
recipes()putsmsgsbeforeros2andfull). The message version did not change since 0.12.3, so the rebuilt files already exist on the channel.build_conda_release.py uploadpasses--skip-existingonly for noarch packages andmcp, so the platform message packages fail with 409. Upload stops there, andunilabos-full(a platform package that sorts after them) never gets uploaded. The noarchunilabos-ros20.13.0a1 packages did go up on linux-64 before the failure.Change
FRAMEWORK_PLATFORM_PACKAGES = {"unilabos", "unilabos-full"}: these must be new on every release. If the same file already exists, upload fails as before.mcp, is a reused dependency and uploads with--skip-existing. noarch packages keep--skip-existingbecause every matrix job builds them.--forceis still never passed.Tests
test_extension_upload_skips_published_message_packagesreproduces the failing case: an extensions-only linux-64 upload with both message packages,unilabos-ros2andunilabos-full. It fails on the currentdevscript and passes with this change.tests/app/test_no_ros_installation.py: 38 passed.dev. None are new.After merge
Re-dispatch
unilabos-conda-build.yml(extensions only, jazzy + humble + full, upload on) withsource_refset to the merge commit.unilabos-fullandunilabos-ros2are metapackages without asource:section, and their recipes are unchanged, so the packages built are the same as from the tag.