Repository navigation
Conversation
45e2fc0 to
43177a4
Compare
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
The package update needs fixes for legacy-model compatibility, system discovery, and the OpenMP-disabled configuration.
[P2] Update system-package discovery — In toolchain/scripts/stage4/install_nep.sh:64–68, --with-nep=system still probes -lnep and the old header location. The new CMake package installs libnep_cpu and include/NEP_CPU/nep.h, so this branch rejects a valid new installation. Please discover the CMake package or update those probes.
Static review of 43177a4 against 52bc797. Whitespace and pinned governance checks passed, and the dependency archive checksum matched. No configure/build, runtime, or CI checks were run; numerical parity after model conversion remains unverified.
|
We need to make sure that the new NEP version can run on DSP, so please do not merge now. |
QuantumMisaka
left a comment
There was a problem hiding this comment.
Request changes: the NEP_CPU package-discovery contract and bundled-model migration still need to be completed. Please also finish the requested DSP validation before merging.
f6e3f32 to
07ae40d
Compare
|
Closing for now. Will reopen once the new release of NEP_CPU is out. |
NEP_CPU package now supports building with CMake.