Skip to content

Use CMake build of NEP_CPU - #8311

Closed
Growl1234 wants to merge 2 commits into
deepmodeling:developfrom
Growl1234:develop
Closed

Growl1234 wants to merge 2 commits into
deepmodeling:developfrom
Growl1234:develop

Conversation

@Growl1234

Copy link
Copy Markdown
Collaborator

NEP_CPU package now supports building with CMake.

@Growl1234 Growl1234 added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Nov 12, 2026
@Growl1234
Growl1234 force-pushed the develop branch 4 times, most recently from 45e2fc0 to 43177a4 Compare November 12, 2026 13:25

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package update needs fixes for legacy-model compatibility, system discovery, and the OpenMP-disabled configuration.

[P2] Update system-package discovery — In toolchain/scripts/stage4/install_nep.sh:64–68, --with-nep=system still probes -lnep and the old header location. The new CMake package installs libnep_cpu and include/NEP_CPU/nep.h, so this branch rejects a valid new installation. Please discover the CMake package or update those probes.

Static review of 43177a4 against 52bc797. Whitespace and pinned governance checks passed, and the dependency archive checksum matched. No configure/build, runtime, or CI checks were run; numerical parity after model conversion remains unverified.

Comment thread toolchain/scripts/package_versions.sh Resolved
Comment thread CMakeLists.txt Resolved
Comment thread cmake/CollectBuildInfoVars.cmake Resolved
@ZhouXY-PKU

Copy link
Copy Markdown
Collaborator

We need to make sure that the new NEP version can run on DSP, so please do not merge now.

@QuantumMisaka QuantumMisaka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: the NEP_CPU package-discovery contract and bundled-model migration still need to be completed. Please also finish the requested DSP validation before merging.

Comment thread CMakeLists.txt Resolved
Comment thread tests/PP_ORB/nep_hfo2.txt Resolved
@Growl1234
Growl1234 force-pushed the develop branch 2 times, most recently from f6e3f32 to 07ae40d Compare November 19, 2026 11:33
@Growl1234
Growl1234 marked this pull request as draft November 19, 2026 12:51
@Growl1234

Copy link
Copy Markdown
Collaborator Author

Closing for now. Will reopen once the new release of NEP_CPU is out.

@Growl1234 Growl1234 closed this Nov 19, 2026
@ZhouXY-PKU ZhouXY-PKU added Solve before 3.11 AI4M For the AI4M branch. labels Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI4M For the AI4M branch. Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS Solve before 3.11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants