Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
static_cast<std::size_t>wrappers from standard-container subscript expressions in the current code derived from previously merged PRs by 19hello.Verification
source /home/fy19/abacus-develop/toolchain/install/setup && cmake -S /tmp/abacus-size-cast-cleanup -B /tmp/abacus-size-cast-build -DENABLE_MPI=ON -DENABLE_LCAO=OFF -DBUILD_TESTING=ON -DDeePMD_DIR=/home/fy19/00_software/deepmd-kit-c -DCMAKE_BUILD_TYPE=Release— passed.source /home/fy19/abacus-develop/toolchain/install/setup && cmake --build /tmp/abacus-size-cast-build --target abacus_pw_para -j 12— passed after the source changes and again after the final DP-file exclusion.MODULE_MD_verlet; its test passed 1/1.python3 tools/03_code_analysis/agent_governance_check.py --base origin/develop --head HEAD --format text— no blockers; documentation review warning only, addressed by the no-behavior-change rationale above.git diff --check origin/develop...HEAD— passed.Limits
.cufiles were not compiled locally becausenvccis unavailable. Their edits only remove explicit conversion before standard-container indexing; the implicit conversion has the same type and value.develop.