Repository navigation
docs(pt): sync DPA4 compile compatibility docs - #6046
wanghan-iapcm merged 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe ChangesCompile support documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The updated documentation reflects the supported PyTorch releases and CUDA requirement; no merge-blocking issue is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
njzjz-bot
left a comment
There was a problem hiding this comment.
Reviewed the complete three-file documentation-only change against the runtime compile policy. SUPPORTED_COMPILE_TORCH is ((2, 11), (2, 12), (2, 13)), and check_compile_torch_version enforces that allowlist, so the updated wording correctly removes the obsolete 2.11-only restriction. The model docstring and argument documentation agree, and the inference table now links to the same use_compile option instead of maintaining another version list. No new actionable issue found.
This is source/documentation review only; no compiler or documentation build was run locally. Exact-head pre-commit succeeds, but all seven build/test/security workflows are action_required and Read the Docs failed (https://app.readthedocs.org/projects/deepmd/builds/34940370/). Rendered cross-reference validation is therefore still unverified.
Agent: dot
Reviewed head: a7e9c3a
wanghan-iapcm
left a comment
There was a problem hiding this comment.
The synced text matches the code at this head: SUPPORTED_COMPILE_TORCH is ((2, 11), (2, 12), (2, 13)), check_compile_torch_version() is what gates both model.use_compile and DP_COMPILE_INFER, and the {ref} target model[dpa4]/use_compile is generated by dargs from the dpa4 model plugin, so the cross-reference resolves. The class docstring, the argument help and the DPA4 table now agree with each other and with the runtime allowlist, and the CUDA and dependency pins are left as intended.
Two non-blocking observations, recorded for a later cleanup rather than as changes requested:
- The
use_compilehelp text points atSUPPORTED_COMPILE_TORCHand then re-states its contents as "(currently 2.11.x, 2.12.x, and 2.13.x)", which is a second hand-maintained copy that will drift on the next allowlist change. Issue #5981 explicitly asked to avoid another hard-coded list where practical; the sibling docstring insezm_model.pyalready names only the constant. :data:is consumed verbatim as the JSON-schemadescription(dargs copiesArgument.docunchanged), sodp doc-train-input --out-type json_schema, DP-GUI and editor tooltips show the role markup literally. There is precedent for this in the file (:py:meth:indoc_rcond), so it is a formatting wart rather than a new failure mode.
Pull request was closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6046 +/- ##
==========================================
+ Coverage 77.74% 77.91% +0.17%
==========================================
Files 1155 1207 +52
Lines 139649 146598 +6949
Branches 5056 5209 +153
==========================================
+ Hits 108573 114226 +5653
- Misses 29191 30408 +1217
- Partials 1885 1964 +79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f4c0073
Update the DPA4/SeZM documentation to match the supported PyTorch versions: 2.11.x, 2.12.x, and 2.13.x. Keep the CUDA 12.6 requirement and existing dependency pins unchanged.
Fixes #5981.
Validation
Summary by CodeRabbit