ci: run script/mcpx-cleanup.test.ts in the unit job by dezren39 · Pull Request #139 · developing-today-forks/opencode

dezren39 · 2026-10-19T22:35:55Z

Fixes #138

script/mcpx-cleanup.test.ts (14 tests / 29 assertions for the mcpx leaked-daemon cleanup script) was run by nothing: script/ is not a workspace so bun turbo test skips it, and the root bunfig.toml test root deliberately blocks running tests from the repo root.

This adds one step to the existing unit job in test.yml that runs the file explicitly with working-directory: script, on both OS legs. The root-level test block stays intact.

Verified locally with the step's exact command:

Clean: 14 pass / 0 fail, 29 expect() calls.
Ablation: breaking one pinned expectation (processDiscovery("linux")) makes the run fail (1 fail); reverted, green again.
YAML parses.

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by CodeRabbit

Tests
- Expanded automated test coverage to include the cleanup script, helping verify its behavior as part of the project’s test suite. No user-facing functionality changed.

script/ is not a workspace, so bun turbo test never executed the mcpx-cleanup tests, and the root bunfig test root deliberately blocks running tests from the repo root. Add a unit-job step that runs the file explicitly from script/ on both OS legs. Verified: 14 pass / 0 fail locally via the step's exact command; a deliberate breakage of a pinned expectation makes it fail.

chatgpt-codex-connector · 2026-10-19T22:36:01Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-19T22:35:58.847670Z	`055dc93`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-10-19T22:36:04Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

github-actions · 2026-10-19T22:36:09Z

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 72 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

github-actions · 2026-10-19T22:36:10Z

Hey! Your PR title ci: run script/mcpx-cleanup.test.ts in the unit job doesn't follow conventional commit format.

Please update it to start with one of:

feat: or feat(scope): new feature
fix: or fix(scope): bug fix
docs: or docs(scope): documentation changes
chore: or chore(scope): maintenance tasks
refactor: or refactor(scope): code refactoring
test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

coderabbitai · 2026-10-19T22:36:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: b50cc6a4-71bf-4271-af91-90f477efb26d

📥 Commits

Reviewing files that changed from the base of the PR and between 2a6b962 and 055dc93.

📒 Files selected for processing: 1

.github/workflows/test.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The unit job now runs mcpx-cleanup.test.ts with Bun from the script directory. The workflow comments explain why the root test command and workspace test discovery do not run this file.

Changes: Script test execution

Layer / File(s)	Summary
Run script cleanup tests in the unit job `.github/workflows/test.yml`	The unit job runs `mcpx-cleanup.test.ts` with Bun from `script/`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: thdxr

Merge Risk: ⚪ Minimal · up to 055dc

The cleanup tests are included in both unit-job OS runs, and failures will fail the check. No merge-blocking risk was identified.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: running the script test in the CI unit job.
Description check		The description identifies issue `#138`, explains the CI change and its rationale, and documents local verification. It omits the change-type selection and checklist, but the core required information i…
Linked Issues check		Issue `#138` requires a PR check for `script/mcpx-cleanup.test.ts`, failure propagation, and preservation of the root test block. At the reviewed head, the `unit` job contains an unconditional `Test mcp…
Out of Scope Changes check		The supplied change summary identifies only an eight-line addition in `.github/workflows/test.yml`. The added step directly implements Issue `#138` by executing the previously omitted test file from `sc…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Full details: Description check

Explanation

The description identifies issue #138, explains the CI change and its rationale, and documents local verification. It omits the change-type selection and checklist, but the core required information is present.

Full details: Linked Issues check

Explanation

Issue #138 requires a PR check for script/mcpx-cleanup.test.ts, failure propagation, and preservation of the root test block. At the reviewed head, the unit job contains an unconditional Test mcpx-cleanup script step with working-directory: script and run: bun test mcpx-cleanup.test.ts. The unit job matrix runs this step on Linux and Windows. The step uses normal GitHub Actions failure handling, so a failing test command fails the job. bunfig.toml still sets [test] root = "./do-not-run-tests-from-root", and the root test script still exits with failure. The PR description also reports 14 passing tests and a deliberate failing-expectation check.

Full details: Out of Scope Changes check

Explanation

The supplied change summary identifies only an eight-line addition in .github/workflows/test.yml. The added step directly implements Issue #138 by executing the previously omitted test file from script/. No unrelated production behavior or unrelated workflow job change is shown.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-19T22:36:35Z

The following comment was made by an LLM, it may be inaccurate:

github-actions Bot added the needs:compliance label Oct 19, 2026

github-actions Bot added the needs:title label Oct 19, 2026

dezren39 merged commit 8a84c1f into main Oct 19, 2026
19 of 24 checks passed

dezren39 deleted the creator/138-mcpx-cleanup-tests branch October 27, 2026 16:21

Navigation Menu

Repository navigation

ci: run script/mcpx-cleanup.test.ts in the unit job - #139

ci: run script/mcpx-cleanup.test.ts in the unit job#139
dezren39 merged 1 commit into
mainfrom
creator/138-mcpx-cleanup-tests

dezren39 commented Oct 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

dezren39 commented Oct 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2026

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

coderabbitai Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dezren39 commented Oct 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading