Skip to content

test(ai,tui,cli): pin the named-form calendar check in the ai/tui/cli copies (#1003) - #1614

Merged
dezren39 merged 1 commit into
mainfrom
queue/8070-1003-calendar-pin
Nov 4, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/8070-1003-calendar-pin

Conversation

@dezren39

@dezren39 dezren39 commented Nov 4, 2026 •

Copy link
Copy Markdown

Fixes #1003.

Tests only — no parser changes. PR #801's named-form calendar check (namedDateParts) exists in the ai (x2), tui, and cli copies but was pinned only in core. This pins it at every copy through each package's existing public test surface:

  • ai executor (responseRateLimit path, packages/ai/test/response-hook.test.ts): rejects Feb 30 2026, 30 Feb 2026, and Feb 28 2026 24:00 as retry-after; accepts named controls Oct 21 2015 / 21 Oct 2015.
  • ai replicate (parseCompletedAt path, packages/ai/test/provider/replicate-images.test.ts): Feb 30 2026 completed_at leaves expiresAt undefined; a valid named-form completed_at (Wed, 21 Oct 2015 07:28:00 GMT) derives expiresAt = completed_at + 1h exactly.
  • tui (validDateTime via formValidateValue, packages/tui/test/util/form.test.ts): rejects Feb 30 2026, 30 Feb 2026, Feb 28 2026 24:00; accepts Jan 5 2026 and the GMT named form.
  • cli (validDateTime via validateText, packages/cli/test/auth-form.test.ts): the same five cases.

Verification (laptop worktree at main 27656e6): bun test — ai response-hook + replicate-images 31 pass, cli auth-form 21 pass, tui form 6 pass, 0 fail. Mutation check: removing each copy's namedDateParts call makes exactly that package's new cases fail (verified per copy, sources restored).

Queue task 8070, lane opencode-a.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c1a87ec0-0304-461f-a715-cae661e360e5
Commits

Reviewing files that changed from the base of the PR and between 27656e6 and a0ce060.

Files selected for processing: 4
  • packages/ai/test/provider/replicate-images.test.ts
  • packages/ai/test/response-hook.test.ts
  • packages/cli/test/auth-form.test.ts
  • packages/tui/test/util/form.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T10:52:54.830540Z a0ce060 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit d5f6296 into main Nov 4, 2026
1 check passed
@dezren39
dezren39 deleted the queue/8070-1003-calendar-pin branch November 4, 2026 11:28
@dezren39
dezren39 restored the queue/8070-1003-calendar-pin branch November 8, 2026 04:35
@dezren39
dezren39 deleted the queue/8070-1003-calendar-pin branch November 8, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ai,tui,cli): PR #801's non-ISO calendar check is pinned only in core — the ai/tui/cli namedDateParts copies have no named-form tests

1 participant