[dezren39]

Fixes #707

validateField's multiselect branch counted raw array length for minItems/maxItems and checked closed-option membership per entry, so a repeated option counted as multiple distinct selections: ["a","a"] satisfied minItems: 2, and ["a","a"] was rejected by maxItems: 1 as "too many" despite naming one distinct selection — contradicting the distinct-selections premise of the #704 create-time check.

Chosen rule (one stated rule, applied consistently): duplicate entries are rejected with Duplicate selection for form field: <key>, checked after the required/empty check and before minItems, maxItems, and closed-option membership, so every multiselect answer path sees the same rule. Answers without duplicates behave exactly as before, including when inclusion semantics.

Tests: new regression test in packages/core/test/form.test.ts covers ["a","a"] against minItems: 2 (options [a,b]), ["x","x","x"] against a custom multiselect with minItems: 3, ["a","a"] against maxItems: 1, duplicates with no bounds, and no-duplicate controls. Verification is via CI on this PR (no builds on the sandbox).

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-28T11:48:15.686156Z	bca5f44	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: a243d951-ba3c-42c3-a2bc-78d5841d5d34

Commits

Reviewing files that changed from the base of the PR and between 213b97e and bca5f44.

Files selected for processing: 2

• packages/core/src/form.ts
• packages/core/test/form.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[dezren39]

🤖 Agent note · parked

• Agent: queue worker (repo-worker-opencode)
• Session / ID: queue task 1817, 2026-10-28T11:52Z
• Found via: queue claim
• Task: PR fix(core): reject duplicate multiselect selections in validateAnswer (#707) #709 opened for fix(core): Form validateAnswer counts duplicate multiselect entries as separate selections — minItems is met by repeating one option #707 (duplicate multiselect selections now rejected in validateAnswer); parked because CI was still pending after 5 minutes of polling — not holding the claim waiting on CI.
• Expectation: effort xs; on resume, read PR fix(core): reject duplicate multiselect selections in validateAnswer (#707) #709 checks fresh and merge if green under the standing criteria. Note: laptop SSH was unreachable all run (MaxStartups drop pattern), so the worktree is an edit-only sandbox copy at ~/git/fleet/1817-707 and verification is CI-only — no local builds were run.
• Links: PR fix(core): reject duplicate multiselect selections in validateAnswer (#707) #709 · branch queue/1817-707-duplicate-multiselect · commit bca5f44

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 72 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate: