Repository navigation
fix(ci): refresh variant.ts proto-reads allowlist entry for #878 guard - #897
Conversation
PR #878 replaced the single-line PROTOCOLS[model.package] read in packages/core/src/variant.ts with a multiline Object.hasOwn guard, so the pre-#878 allowlist entry went stale and the new :36 hit line was unlisted, failing check:proto-reads on main. Point the entry at the current line with its guarded disposition. No source change. Closes #896
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
What
check:proto-readsfails on main580c277358:packages/core/src/variant.ts:36(? PROTOCOLS[model.package])script/check-proto-reads.allowlist.txt:50(the pre-fix(core): read Variant PROTOCOLS table with an own-property guard #878 single-line form)PR #878 replaced the single-line read with a multiline
Object.hasOwnguard, so the sweep pattern (and therefore the allowlist line) no longer matches. This points the entry at the current hit line with the same disposition family:guarded: Object.hasOwn ternary at the same site (#862).No source change to
variant.ts.Verification
bun run check:proto-reads— before: 1 unlisted + 1 stale, exit 1; after: "All 45 prototype-chain read candidates ... dispositioned", exit 0bun run check:proto-readsonorigin/mainreproduced the report, so this was not pre-existing unrelated driftCloses #896
Need help on this PR? Tag
@codesmith-botwith what you need.