Skip to content

fix(ci): refresh variant.ts proto-reads allowlist entry for #878 guard - #897

Merged
dezren39 merged 1 commit into
mainfrom
queue/3525-896-proto-reads-allowlist
Oct 29, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/3525-896-proto-reads-allowlist

Conversation

@dezren39

@dezren39 dezren39 commented Oct 29, 2026 •

Copy link
Copy Markdown

What

check:proto-reads fails on main 580c277358:

PR #878 replaced the single-line read with a multiline Object.hasOwn guard, so the sweep pattern (and therefore the allowlist line) no longer matches. This points the entry at the current hit line with the same disposition family: guarded: Object.hasOwn ternary at the same site (#862).

No source change to variant.ts.

Verification

  • bun run check:proto-reads — before: 1 unlisted + 1 stale, exit 1; after: "All 45 prototype-chain read candidates ... dispositioned", exit 0
  • bun run check:proto-reads on origin/main reproduced the report, so this was not pre-existing unrelated drift

Closes #896


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

PR #878 replaced the single-line PROTOCOLS[model.package] read in
packages/core/src/variant.ts with a multiline Object.hasOwn guard, so the
pre-#878 allowlist entry went stale and the new :36 hit line was unlisted,
failing check:proto-reads on main. Point the entry at the current line with
its guarded disposition. No source change.

Closes #896
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: afbd3775-2f1d-4156-82eb-b37de24fad29
Commits

Reviewing files that changed from the base of the PR and between 580c277 and a19a9ae.

Files selected for processing: 1
  • script/check-proto-reads.allowlist.txt
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T15:45:53.545764Z a19a9ae PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 72 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@dezren39
dezren39 merged commit e030d19 into main Oct 29, 2026
11 of 13 checks passed
@dezren39
dezren39 deleted the queue/3525-896-proto-reads-allowlist branch October 29, 2026 16:25
@dezren39
dezren39 restored the queue/3525-896-proto-reads-allowlist branch November 1, 2026 10:12
@dezren39
dezren39 deleted the queue/3525-896-proto-reads-allowlist branch November 1, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): check:proto-reads fails on main — variant.ts guarded read is unlisted and its pre-#878 allowlist entry is stale

1 participant