You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Parent stack should use same schema version as Node.js Runtime parent stack #1589
Since the Node.js Runtime nodejs devfile registry stack updated the default schema version devfile/registry#403, devfile library parent devfile test case is failing as the test child devfile still uses 2.1.0.
To Reproduce:
Run make test
Expected behavior
To continue to use the Node.js Runtime parent stack for the test, the mock child devfile should match this schema version.
Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable
=== RUN Test_Parent_RegistryURL
test_utils.go:389: [..... ERROR : Error validating testDevfile error parsing devfile because of non-compliant data due to the parent devfile version from id: nodejs, registryURL: https://registry.stage.devfile.io/ is greater than the child devfile version from main devfile ]
--- FAIL: Test_Parent_RegistryURL (0.23s)
=== RUN Test_Everything
--- PASS: Test_Everything (3.04s)
=== RUN Test_EverythingEdit
--- PASS: Test_EverythingEdit (3.10s)
FAIL
coverage: [no statements]
FAIL github.com/devfile/library/v2/tests/v2/libraryTest 85.123s
FAIL
make: *** [Makefile:37: test] Error 1
Additional context
Any workaround?
Revert devfile/registry#403 change in the parent devfile, this is not ideal as we will periodically need to update the schema version in our devfile registry stacks.
Activity
michael-valdron commentedon Jun 5, 2024
blocking devfile/library#212 from merging
michael-valdron commentedon Jun 5, 2024
Sized issue based on duration it took me.
Priority set as blocker due to it blocking a high priority PR devfile/library#212.
michael-valdron commentedon Jun 5, 2024
PR ready for review: devfile/library#213