Skip to content

Parent stack should use same schema version as Node.js Runtime parent stack #1589

Closed
devfile/library
#213

Description

@michael-valdron

/kind bug

Which area is this bug related to?

/area library

What versions of software are you using?

Go project

Operating System and version: N/A

Go Pkg Version: N/A

Bug Summary

Describe the bug:

Since the Node.js Runtime nodejs devfile registry stack updated the default schema version devfile/registry#403, devfile library parent devfile test case is failing as the test child devfile still uses 2.1.0.

To Reproduce:

Run make test

Expected behavior

To continue to use the Node.js Runtime parent stack for the test, the mock child devfile should match this schema version.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

=== RUN   Test_Parent_RegistryURL
    test_utils.go:389: [..... ERROR : Error validating testDevfile error parsing devfile because of non-compliant data due to the parent devfile version from id: nodejs, registryURL: https://registry.stage.devfile.io/ is greater than the child devfile version from main devfile ]
--- FAIL: Test_Parent_RegistryURL (0.23s)
=== RUN   Test_Everything
--- PASS: Test_Everything (3.04s)
=== RUN   Test_EverythingEdit
--- PASS: Test_EverythingEdit (3.10s)
FAIL
coverage: [no statements]
FAIL	github.com/devfile/library/v2/tests/v2/libraryTest	85.123s
FAIL
make: *** [Makefile:37: test] Error 1

Additional context

Any workaround?

Revert devfile/registry#403 change in the parent devfile, this is not ideal as we will periodically need to update the schema version in our devfile registry stacks.

Suggestion on how to fix the bug

Need to bump 2.1.0 to 2.2.2 to match parent: https://github.com/devfile/library/blob/090339307b56bf381092bdafdf2c764c180c6570/tests/v2/devfiles/samples/Test_Parent_RegistryURL.yaml#L1

Activity

  1. added
    kind/bugSomething isn't working
    area/libraryCommon devfile library for interacting with devfiles
    on Jun 5, 2024
  2. michael-valdron commented on Jun 5, 2024

    @michael-valdron
    MemberAuthor

    blocking devfile/library#212 from merging

  3. michael-valdron commented on Jun 5, 2024

    @michael-valdron
    MemberAuthor

    Sized issue based on duration it took me.

    Priority set as blocker due to it blocking a high priority PR devfile/library#212.

  4. moved this from Refinement to In Review 👀 in Devfile Projecton Jun 5, 2024
  5. michael-valdron commented on Jun 5, 2024

    @michael-valdron
    MemberAuthor

    PR ready for review: devfile/library#213

  6. moved this from In Review 👀 to Done ✅ in Devfile Projecton Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/libraryCommon devfile library for interacting with devfileskind/bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions