[tolusha]

What does this PR do?

Enhance the backup cronjob controller to track backup status individually for each workspace using annotations. This allows more granular control over when backups are triggered based on each workspace's specific backup history rather than a global timestamp.

• Add handleBackupJobStatus to update DevWorkspace annotations when backup jobs complete or fail
• Modify wasStoppedSinceLastBackup to check workspace-specific annotations first, falling back to global time
• Include DevWorkspace name label on backup jobs for easier association

Assisted-by: Claude

What issues does this PR fix or reference?

#1549

Is it tested? How?

Follow the #1530

kind: DevWorkspace
metadata:
  annotations:
    controller.devfile.io/last-backup-successful: 'true'
    controller.devfile.io/last-backup-time: '2025-12-23T10:20:05.030687Z'

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rohanKanojia]

I tested it and it seems to work as expected.

On successful backup devworkspace is updated with annotations:

- apiVersion: workspace.devfile.io/v1alpha2
  kind: DevWorkspace
  metadata:
    annotations:
      controller.devfile.io/last-backup-successful: "true"
      controller.devfile.io/last-backup-time: "2026-01-05T11:02:40.149872Z"

[akurinnoy]

I think the RFC3339Micro should be used (according to https://github.com/devfile/devworkspace-operator/pull/1550/changes#diff-5509053b46d7570ac99788ae88a71179c263829eb7b4d3d91ecfc87775e58467R188-R190)

Suggested change

	parsedTime, err := time.Parse(time.RFC3339Nano, lastBackupFinishedAtStr)
	parsedTime, err := time.Parse(time.RFC3339Micro, lastBackupFinishedAtStr)

[dkwon17]

Adding to @akurinnoy 's comment, is there a reason why we are using time.RFC3339Micro when setting the time here [1], but use time.RFC3339Nano when parsing the lastBackupFinishedAtStr ?

[1]

devworkspace-operator/controllers/backupcronjob/backupcronjob_handler.go

Line 134 in d5ee878

devWorkspace.Annotations[constants.DevWorkspaceLastBackupFinishedAtAnnotation] = condition.LastTransitionTime.Format(metav1.RFC3339Micro)

[tolusha]

Unfortunately, the reason is claude

[dkwon17]

LGTM functionality-wise, just 1 comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia, tolusha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkwon17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[tolusha]

/retest

[tolusha]

/retest

[openshift-ci]

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v14-che-happy-path	80a9d5c	link	true	/test v14-che-happy-path

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dkwon17]

The e2e test failure looks like the same error we see in this PR #1554