Repository navigation
Conversation
Fix issue with npm publish script
Build preparation for release v2.15.1
|
The icons look good, but at first glance I see one thing that needs to be changed, and one that should be added. First off, you need to base your branch on the develop branch, and not master. And then when you open a PR, it should be for the develop branch. 2nd, it would be nice if you could add plain versions of the icons. That is, single color versions. Iirc, there should be some plain verions available on their website as well. |
|
Could you also add |
| @@ -1 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path fill="#fa930d" d="M5.55 64.73a17.08 17.08 0 1017.08-17.09A17.11 17.11 0 005.55 64.73z"/><path fill="#136ba2" d="M107.48 4.73c-9.39 0-15 7.56-15 20.23v77.8c0 12.66 5.59 20.23 15 20.23s15-7.56 15-20.23V25c-.03-12.7-5.63-20.27-15-20.27zM81.25 6.38H19.88a14.92 14.92 0 000 29.81v.11h31.41v28.4a28.7 28.7 0 01-28.63 28.7h-.77l-.08.1c-.42 0-.85-.07-1.29-.07a14.94 14.94 0 100 29.87c.45 0 .9 0 1.34-.07v.05h.78a58.65 58.65 0 0058.61-58.55v-.54-9.59-.11V6.38z"/></svg> No newline at end of file | |||
| <svg xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://www.w3.org/2000/svg" class="sprite-img intellij-idea" width="128" height="128" ><defs><symbol xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 70 70" id="intellij-idea"><defs><linearGradient id="intellij-idea_intellij-idea_svg__a" x1="5.174" x2="40.014" y1="39.889" y2="38.123" gradientUnits="userSpaceOnUse"><stop offset=".091" stop-color="#FC801D"></stop><stop offset=".231" stop-color="#B07F61"></stop><stop offset=".409" stop-color="#577DB3"></stop><stop offset=".533" stop-color="#1E7CE6"></stop><stop offset=".593" stop-color="#087CFA"></stop></linearGradient><linearGradient id="intellij-idea_intellij-idea_svg__b" x1="61.991" x2="50.158" y1="36.915" y2="1.557" gradientUnits="userSpaceOnUse"><stop offset="0" stop-color="#FE2857"></stop><stop offset=".078" stop-color="#CB3979"></stop><stop offset=".16" stop-color="#9E4997"></stop><stop offset=".247" stop-color="#7557B2"></stop><stop offset=".339" stop-color="#5362C8"></stop><stop offset=".436" stop-color="#386CDA"></stop><stop offset=".541" stop-color="#2373E8"></stop><stop offset=".658" stop-color="#1478F2"></stop><stop offset=".794" stop-color="#0B7BF8"></stop><stop offset="1" stop-color="#087CFA"></stop></linearGradient><linearGradient id="intellij-idea_intellij-idea_svg__c" x1="10.066" x2="53.876" y1="16.495" y2="88.96" gradientUnits="userSpaceOnUse"><stop offset="0" stop-color="#FE2857"></stop><stop offset=".08" stop-color="#FE295F"></stop><stop offset=".206" stop-color="#FF2D76"></stop><stop offset=".303" stop-color="#FF318C"></stop><stop offset=".385" stop-color="#EA3896"></stop><stop offset=".553" stop-color="#B248AE"></stop><stop offset=".792" stop-color="#5A63D6"></stop><stop offset="1" stop-color="#087CFA"></stop></linearGradient></defs><path fill="url("#intellij-idea_intellij-idea_svg__a")" d="M11.2 49.4668L0.699951 41.3001L9 26L18.5 33.5L11.2 49.4668Z"></path><path fill="#087CFA" d="M69.9999 18.6666L68.8333 59.2666L41.7666 70L27.0666 60.4333L41.7666 37.5L69.9999 18.6666Z"></path><path fill="url("#intellij-idea_intellij-idea_svg__b")" d="M70 18.6666L55.5 33L37 15L48.0666 1.16663L70 18.6666Z"></path><path fill="url("#intellij-idea_intellij-idea_svg__c")" d="M27.0667 60.4333L5.6 68.3667L10.0333 52.5L15.8667 33.1333L0 27.7667L10.0333 0L33.1333 2.8L54.5 31L55.5 33L27.0667 60.4333Z"></path><path fill="#000" d="M56 14H14V56H56V14Z"></path><g fill="#FFFFFF"><path d="M27.1366 22.1433V19.25H19.2733V22.1433H21.4666V32.1067H19.2733V34.9767H27.1366V32.1067H24.92V22.1433H27.1366Z" fill="#FFFFFF"></path><path d="M34.6967 35.21C33.46 35.21 32.4334 34.9767 31.6167 34.51C30.7767 34.0433 30.1 33.4833 29.5634 32.8533L31.7334 30.4267C32.1767 30.9167 32.6434 31.3133 33.0867 31.5933C33.5534 31.8733 34.0434 32.0133 34.6034 32.0133C35.2567 32.0133 35.77 31.8033 36.1434 31.3833C36.5167 30.9633 36.7034 30.31 36.7034 29.4V19.2733H40.25V29.5633C40.25 30.4967 40.1334 31.3133 39.8767 32.0133C39.62 32.7133 39.2467 33.2967 38.78 33.7633C38.29 34.2533 37.7067 34.6033 37.0067 34.86C36.3067 35.0933 35.5367 35.21 34.6967 35.21Z" fill="#FFFFFF"></path><path d="M34.4166 48.6499H18.6666V51.3332H34.4166V48.6499Z" fill="#FFFFFF"></path></g></symbol></defs><use xlink:href="#intellij-idea"></use></svg> No newline at end of file | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
The same applies to all the icons you submitted^
|
Please "Create a separate pull request (PR) for each Icon" (see https://github.com/devicons/devicon/wiki/Example-of-Submitting-Icons-to-the-Repository). This is required for our automated workflow to work properly! :) Thank you! |
|
I mean. I like to help, but all I wanted was to use these icons in my profile. I'm not a visual designer or anything so I most likely will not assist you in this any further. You can gladly use the icons from my repo or the website i provided to update the existing jetbrains icons, but this is just too much work for my already filled schedule. |
|
@Kek5chen |
|
i'll see what i can do. if i have some spare time on hand ill fix the stuff you suggested. it does not seem like its a huge thing to do |
|
@Kek5chen |
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #1125
Link to prove your SVG is correct and up-to-date.
https://www.jetbrains.com/de-de/company/brand/#logos-and-icons