Repository navigation
(LLM-generated content removed) - #280
Closed
GLITCHKISS wants to merge 1 commit into
Closed
GLITCHKISS wants to merge 1 commit into
GLITCHKISS wants to merge 1 commit into
Conversation
VOICE_UPDATE was cleared only for voice 0 (in the DMA callback) and by the look-ahead, which clears the next active voice's flag while the voice before it is still being mixed. A voice set with ASND_SetVoice after the look-ahead had passed it was sent to the DSP with the flag still on. When its mix came back, __dsp_requestcallback took the flag to mean the voice had been set again during the mix, discarded the DSP's progress and sent the voice from its start once more, so the first 1024 samples of the sound played twice. Clear the flag at the point the voice is sent, as the voice 0 path already does. A voice set while it is on the DSP still sets the flag again and is restarted as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM-generated content removed