Repository navigation
chore: refactor the canister status/info/show commands - #225
Merged
Merged
Conversation
raymondk
commented
Dec 10, 2025
Collaborator
raymondk
force-pushed
the
rk/canister-list-show
branch
from
December 10, 2025 23:29
62b1a43 to
8938d58
Compare
raymondk
force-pushed
the
rk/canister-list-show
branch
from
December 11, 2025 00:58
1e7aaa2 to
3bf3585
Compare
raymondk
marked this pull request as ready for review
December 11, 2025 20:19
| #[allow(clippy::large_enum_variant)] | ||
| pub(crate) enum Command { | ||
| /// Display a canister's settings | ||
| /// Show the status of a canister. By default this queries the |
Contributor
There was a problem hiding this comment.
This whole paragraph is shown in icp canister settings help. Double linebreak after the first sentence prevents that.
|
|
||
| if reject.error_code.as_deref() != Some(E_NOT_A_CONTROLLER) { | ||
| // We don't know this error code | ||
| bail!("Error looking up canister {cid}: {:?}", reject.error_code); |
Contributor
There was a problem hiding this comment.
This should also include the reject message
adamspofford
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.