Repository navigation
Remove the Terminal Context autorun - #1540
Merged
Merged
Conversation
Ned's call: typing `git status` is no burden, and the setting confused more than it helped. A helper now starts its shell and runs nothing, which also retires the one accepted risk it carried: a saved command running without asking in the source's directory. Gone: the Modify control and its dialog, the command on HelperIdentity (spawn, list, restore), the sidecar's preference file and validation, the shell readiness wait and injection, the helper status machine, and the refresh that replaced an untouched helper on reopening. The Reset slot is now always there, since Modify shared it, and the status row speaks only for an exit. What a helper does now: reopening keeps it as you left it, untouched or not, with the mismatch warning if the source has moved on; only Reset replaces it. The refresh's only other job was following the source, and without a command to re-run it would kill and respawn a shell the user may be looking at. Stored values: nothing reads ~/.dormouse/helper-terminal.json any more, so an installed setting is inert and the file stays where it is rather than keep a migration alive. Live helper metadata is the only other place the command lived; a sidecar keeps only parentId from whatever it is sent. Webview and host ship together, so no build pairs a new webview with an old sidecar. `settings` becomes `home` on the context wire, the only thing it still answers. A helper's start directory keeps its rule, since a terminal's output should not choose where a shell opens. S167 keeps its git and launch-write duty and now says helper-terminal.ts writes nothing; S132 loses the watchHelper write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
744aacd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://938bcb3f.mouseterm.pages.dev |
| Branch Preview URL: | https://remove-terminal-autorun.mouseterm.pages.dev |
nedtwigg
marked this pull request as ready for review
November 3, 2026 06:42
dormouse-bot
reviewed
Nov 3, 2026
dormouse-bot
left a comment
Collaborator
There was a problem hiding this comment.
No code findings. The removal is complete: nothing still references the settings op, HelperStatus, the autorun constants, or the sidecar's helper-terminal.json read/write. The home op is wired the same way in the fake adapter, the sidecar, and the VS Code router's ownership exemption. The spec, S132/S167, and the security.md known-gap edits match the code.
I'm not approving while the three Argos statuses (argos/storybook-chromium, argos/storybook-webkit, argos/summary) are red. Their builds show 39 changed, 1 added, and 3 removed stories waiting on a decision. That matches the story moves the description lists (AutorunRunning/AutorunOff/ModifyAutorun removed, HelperExited added), so accepting the builds in Argos is what clears them.
Autorun's status and prompt tracking was what needed a 100ms poll. All it did afterwards was notice an exit and throttle the 2 second work inspection, ten wakeups a second per visible helper. One interval now does both, running at once when a helper becomes visible so an exit or the first inspection isn't left waiting. The terminal already prints the exit as it happens; only the status row can trail it. HelperTerminal.exited went with it: it mirrored the registry entry, and the row reads that directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Take the larger budget per spec, then ratchet security-local.md, security-remote.md, and security.md to their merged sizes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dormouse-bot
previously approved these changes
Nov 3, 2026
dormouse-bot
reviewed
Nov 3, 2026
dormouse-bot
left a comment
Collaborator
There was a problem hiding this comment.
Withdrawing my approval: the three Argos statuses are red again on this head, with the same counts as before (39 changed, 1 added, 3 removed, waiting for a decision). The 2-second watch commit and the main merge added no story changes. The code looks good to me, so accepting those builds in Argos is the only thing left before this can merge.
dormouse-bot
dismissed
their stale review
November 3, 2026 06:58
CI failed — Argos visual diffs await a decision.
Take the larger budget per spec, then ratchet security-local.md to its merged size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # scripts/spec-word-budgets.json
The view's status and command props overlapped: a command only mattered while running, and running was a Tool's alone. It now takes runningCommand and exited, each owned by one role, which drops the dead lastCommand fallback. With Modify's input gone nothing in the view composes text, so its IME guard and the test that faked composition on a button go too. Also removes a test of a host answer openHelper no longer asks for, narrows another to what it still checks, collapses openHelper's retained-helper path, inlines two one-use constants, and renames what still spoke of the old dialog and statuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dormouse-bot
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Terminal Context autorun. Typing
git statusis no burden, and the setting confused more than it helped. The helper terminal stays: it now starts its shell and runs nothing, which also retires the one accepted risk this carried, a saved command running without asking in the source's directory.Gone: the Modify control and its dialog, the command on
HelperIdentity(spawn, list, restore), the sidecar's preference file and validation, the shell readiness wait and injection, the helper status machine, and the refresh that replaced an untouched helper on reopening.settingsbecomeshomeon the context wire, the only thing it still answers.What a helper does now: opening starts a shell and writes nothing. Reopening keeps it as you left it, untouched or not, with the mismatch warning if the source has moved on; only Reset replaces it, and Reset is always offered. The status row speaks only for an exit.
Maintainer's decision: an untouched helper no longer follows its source on reopen. The refresh's only other job was following the source, and without a command to re-run it would kill and respawn a shell the user may be looking at.
Stored values: autorun shipped in v1.3.0. Nothing reads
~/.dormouse/helper-terminal.jsonany more, so an installed setting is inert and the file stays where it is, with no migration. A sidecar keeps onlyparentIdfrom helper metadata it is sent. A new webview on an old sidecar would have its helper refused, which the agent judged unreachable because they ship together; that wasn't run.Security: the accepted risk leaves
security.md. A helper's start directory keeps its rule, since a terminal's output should not choose where a shell opens.S167keeps its git and launch-write duty and now sayshelper-terminal.tswrites nothing;S132loses thewatchHelperwrite. No rule ID is retired, and no canary changed.Verified: targeted vitest in lib, standalone, vscode-ext, and website; sidecar tests;
tscin all three; the specs, md, public-docs, outbound, and loopback lints;test:audit;test:checks; the Chromium Argos config on the TerminalContext, HelperPlacement, TerminalPaneHeader, and Wall stories. 7 mutations went red. Not verified: the live app, WebKit, or Windows.Argos: every TerminalContext story moves, since Reset replaces Modify and the prompt is bare.
AutorunRunning,AutorunOff, andModifyAutorungo, andHelperExitedis new. HelperPlacement and any story opening a helper also move.🤖 Generated with Claude Code