Repository navigation
sidebar active class and expand don't work as expect when use "space" in markdown filename #1032
Description
Bug Report
Steps to reproduce
- create an markdown file and use
test sidebar.mdas it's name - make sure this markdown file has some content so that can generate some item in sidebar
- open the url
/#/test%20sidebar - click the sidebar item, and you will see sometimes the item doesn't has
activeclass - create more markdown file, and set
loadSidebarto use custom sidebar - config
subMaxLevel - click the sidebar item, and you will find out that the sidebar item can't be expanded
What is current behaviour
- sidebar item doesn't has
activeclass when click - sidebar item doesn't been expanded when click
What is the expected behaviour
- sidebar item has
activeclass when click - sidebar item will be expanded when click
-
Bug does still occur when all/other plugins are disabled?
-
Your OS: Mac OS 10.13.6 (17G65)
-
Node.js version: N/A
-
npm/yarn version: N/A (use index.html)
-
Browser version: Chrome 79.0.3945.130
-
Docsify version: unpkg latest
-
Docsify plugins: N/A
Activity
anikethsaha commentedon Feb 23, 2020
Can you share a reproducible repo? having a repo makes things quicker 👍
Just a note that it is never recommended to use a space in a markdown file name. Use
-instead of space.csu-feizao commentedon Feb 26, 2020
hi, this is the repo, sorry for reply so late
anikethsaha commentedon Feb 26, 2020
Thanks I will take a look .
Feel free to investigate and submit a fix if its a bug to make the process faster. cause I think i cant investigate it any time soon.
anikethsaha commentedon Mar 9, 2020
as per the repo you shared, I could get the hightlighted sidebar links for activeBug page
and I can confirm with the expand bug , its a bug
fix: decode href in sidebar (docsifyjs#1032)
enzy commentedon Dec 17, 2020
PR provided
fix: sidebar active class and expand don't work as expect when use "s…