Skip to content

vulnerability report #1126

Description

@Sharifi-Amin

Bug Report

I have found a security vulnerability in docsify.sj. How would you like me to report it?

Steps to reproduce

What is current behaviour

What is the expected behaviour

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version:

  • Docsify plugins:

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

Activity

  1. anikethsaha commented on Apr 19, 2020

    @anikethsaha
    Member

    here only. fill the template and you can submit the report here

  2. Sharifi-Amin commented on Apr 20, 2020

    @Sharifi-Amin
    Author

    I would advise against disclosing security vulnerabilities in a public manner before there is fix. please confirm that you want me to disclose details of the vulnerability here. I'll be happy to provide a detailed report and try to help to push a fix as soon as possible .

  3. anikethsaha commented on Apr 20, 2020

    @anikethsaha
    Member

    I would advise against disclosing security vulnerabilities in a public manner before there is fix.

    thanks for the alert. no don't report here.
    Actually we didn't set up any security policy as of now (I know its bad, I will set up this as soon as possible after discussing with the team ).

    • I would suggest reporting it to Snyk Security Team first. They will help triage the security issue and work with all involved parties to remediate and release a fix.
    • if you want to contact me, you can contact through my email
      and if you want to share some sensitive report ( still I would suggest to reach snyk team first ), mention in the mail and we can discuss there how to do so !
  4. trusktr commented on Apr 20, 2020

    @trusktr
    Member

    How severe is this issue? Is it in an NPM module that affects local development?

    It is hard to imagine any issue with static HTML (markdown) sites being insecure. Docsify sites are purely static by default, with no user information (or did I miss something?).

    @anikethsaha Maybe we can make a security issue template, and it can specify contact instructions there.

  5. anikethsaha commented on Apr 20, 2020

    @anikethsaha
    Member

    we need to set up a policy here

  6. trusktr commented on Apr 20, 2020

    @trusktr
    Member

    Ah cool, I didn't know about that.

  7. anikethsaha commented on Apr 20, 2020

    @anikethsaha
    Member

    It is hard to imagine any issue with static HTML (markdown) sites being insecure. Docsify sites are purely static by default, with no user information (or did I miss something?).

    true, but we do support GA, codefund plugins and markdown may contain embedded files so it may be harmful in those cases. not sure though 😅 .

    I will still suggest reporting first in snyk for any cases even if it is in our dependencies,

  8. Sharifi-Amin commented on Apr 20, 2020

    @Sharifi-Amin
    Author

    I'll get in touch with snyk team asap. I'll contact you through email for a detailed report

  9. Sharifi-Amin commented on Apr 20, 2020

    @Sharifi-Amin
    Author

    we need to set up a policy here

    please let me know if I can contribute in any way

  10. anikethsaha commented on Apr 20, 2020

    @anikethsaha
    Member

    I'll get in touch with snyk team asap. I'll contact you through email for a detailed report

    great. 👍

    please let me know if I can contribute in any way

    contribution of any kind are always welcome. you can share some idea or submit as a policy for better approach. We can discuss there

  11. Sharifi-Amin commented on Apr 20, 2020

    @Sharifi-Amin
    Author

    The Snyk team have verified the vulnerability. they will try to get in touch with you to discuss a fix. if you want to close this issue, you can always reach me at amin.sharifi691@gmail.com.

  12. anikethsaha commented on Apr 20, 2020

    @anikethsaha
    Member

    Thanks a lot for the reports and responses.
    this issue also was a reminder that we need a policy for security reports.

    you can always reach me at amin.sharifi691@gmail.com.

    sure.

    Thanks 👍

  13. anikethsaha commented on Apr 20, 2020

    @anikethsaha
    Member

    I think it's better to keep it open until a response from snyk just to mark it. 👍

  14. Sharifi-Amin commented on Apr 20, 2020

    @Sharifi-Amin
    Author

    Thanks a lot for the reports and responses.
    this issue also was a reminder that we need a policy for security reports.

    you can always reach me at amin.sharifi691@gmail.com.

    sure.

    Thanks 👍

    my pleasure

  15. Sharifi-Amin commented on Apr 20, 2020

    @Sharifi-Amin
    Author

    I think it's better to keep it open until a response from snyk just to mark it. 👍

    I agree

  16. added
    pinnedThis is to pinned the PR/Issue in order to keep it open
    on Apr 20, 2020
  17. Koooooo-7 commented on Apr 21, 2020

    @Koooooo-7
    Member

    I can't imagine the vulnerability in Docsify either.
    As a static website, all congratulations can be reached in the browser. including the GA or something stuff(all websites deployed it in same way).

  18. anikethsaha commented on Apr 21, 2020

    @anikethsaha
    Member

    I got a mail from snyk and I think we should fix it cause it may be serious. there is a PoC as well. I will share the mail with @docsifyjs/reviewers chat room soon so that we can discuss the fix.

  19. added a commit that references this issue on Feb 5, 2021
    e6c6abb
  20. added a commit that references this issue on Feb 5, 2021
    14ce7f3
  21. added a commit that references this issue on Feb 14, 2021
    8c1ae12
  22. added a commit that references this issue on Feb 18, 2021
    ff2a66f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pinnedThis is to pinned the PR/Issue in order to keep it open

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions