You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove the src directory from packages.json's files #1343
There's no good reason to make these sorts of breaking changes. It is useful for some people to rely on source files for build systems, and if someone already is, then this breaks their setup.
We should instead try writing tests. We don't need to wait for playwright PR to be finished in order to begin doing that.
I think it was kept as a mistake may cause even if we use this from cdn, it will break as styles are written in .styl and ja as modules.
And it is not mentioned in anywhere to use any files from src/*. So I think even if it is breaking, it might not be an issue with us.
Thoughts?
Activity
trusktr commentedon Aug 21, 2020
There's no good reason to make these sorts of breaking changes. It is useful for some people to rely on source files for build systems, and if someone already is, then this breaks their setup.
We should instead try writing tests. We don't need to wait for playwright PR to be finished in order to begin doing that.
sy-records commentedon Aug 22, 2020
I think the build system should use github instead of npm
anikethsaha commentedon Aug 22, 2020
I think it was kept as a mistake may cause even if we use this from cdn, it will break as styles are written in
.styland ja as modules.And it is not mentioned in anywhere to use any files from
src/*. So I think even if it is breaking, it might not be an issue with us.Thoughts?