Skip to content

Remove the src directory from packages.json's files #1343

Closed

Description

@anikethsaha

Remove this line https://github.com/docsifyjs/docsify/blob/develop/package.json#L20 , till now we are publishing this directory as well and we should not have that.

Activity

  1. trusktr commented on Aug 21, 2020

    @trusktr
    Member

    There's no good reason to make these sorts of breaking changes. It is useful for some people to rely on source files for build systems, and if someone already is, then this breaks their setup.

    We should instead try writing tests. We don't need to wait for playwright PR to be finished in order to begin doing that.

  2. sy-records commented on Aug 22, 2020

    @sy-records
    Member

    I think the build system should use github instead of npm

  3. anikethsaha commented on Aug 22, 2020

    @anikethsaha
    MemberAuthor

    I think it was kept as a mistake may cause even if we use this from cdn, it will break as styles are written in .styl and ja as modules.
    And it is not mentioned in anywhere to use any files from src/*. So I think even if it is breaking, it might not be an issue with us.
    Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions