Skip to content

Search is KO with IE11 #1526

Closed
Closed

Description

@StephaneG31

When an IE11 user try to search in docsfy with IE11, there's an JS error and the search doesn't work.
image

Activity

  1. sy-records commented on Mar 8, 2021

    @sy-records
    Member

    Have you tried this?

    image

    <script src="//polyfill.io/v3/polyfill.min.js?features=String.prototype.normalize"></script>

    see https://docsify.js.org/#/plugins?id=full-text-search

  2. StephaneG31 commented on Mar 8, 2021

    @StephaneG31
    Author

    The problem seems to be here :

    $appName.classList.remove('hide');

    In our case $appName is null. Is it possible to just add an if behind to test the presence of this object ?

  3. sy-records commented on Mar 8, 2021

    @sy-records
    Member

    Can you provide a reproducible sandbox?

  4. StephaneG31 commented on Mar 8, 2021

    @StephaneG31
    Author
  5. StephaneG31 commented on Mar 8, 2021

    @StephaneG31
    Author

    If I remove the "n.classList.remove('hide')" it works but I think it's better to do an if check

  6. sy-records commented on Mar 8, 2021

    @sy-records
    Member

    Can you use this for testing?

    <script src="https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app/lib/docsify.js"></script>
    <script src="https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app/lib/plugins/search.js"></script>
  7. StephaneG31 commented on Mar 8, 2021

    @StephaneG31
    Author

    Can you use this for testing?

    <script src="https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app/lib/docsify.js"></script>
    <script src="https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app/lib/plugins/search.js"></script>
    

    I this it on my DEV ENV and it works!

  8. sy-records commented on Mar 8, 2021

    @sy-records
    Member

    Thank you for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions