Repository navigation
external links don't work in history router mode #1803
Description
Bug Report
Steps to reproduce
- Set
routerModetohistory. - Create mailto link with
<my@mail.com>, or any external link. - Click on rendered link.
What is current behaviour
Crashes with error:
SecurityError
Failed to execute 'replaceState' on 'History': A history state object with URL 'mailto:my@email.com' cannot be created in a document with origin 'https://kc32ry.csb.app' and URL 'https://kc32ry.csb.app/'.
What is the expected behaviour
Native behaviour
Other relevant information
-
Bug does still occur when all/other plugins are disabled?
-
Your OS: macOS Catalina, version 10.15.7
-
Node.js version: 16.13.2
-
npm/yarn version: npm v8.1.2
-
Browser version: Google Chrome 100.0.4896.127
-
Docsify version: 4.12.2
-
Docsify plugins: -
Please create a reproducible sandbox
Live example: https://docs.lume.io/
Activity
trusktr commentedon Jan 9, 2023
Indeed, non-docsify links (external links) are currently not working in history router mode. We need to fix this and add tests.
live example: https://docs.lume.io/
[-]mailto link doesn't work in history mode[/-][+]external links don't work in history router mode[/+]trusktr commentedon Jan 22, 2023
I found the issue. It happens when
externalLinkTarget: '_self'is specified. Fix WIPRemove the externalLinkTarget option for now, it breaks nav links in …
ref docsifyjs#1803: the crossOriginLinks option is no longer needed, …