Relative path link with ':ignore' dosen't work #1929

Activity

1. Koooooo-7

   added

   needs investigation

   on Dec 9, 2022
2. aKuad commented on Jan 5, 2023

   

   aKuad

   on Jan 5, 2023

   Last edited by aKuad

   Author

   More actions

   I think, this part has some probrem...

   In /src/core/render/compiler/link.js, Line 21:
   (+ my guessing note)

   if (
     !isAbsolutePath(href) &&  // -> true
     !compilerClass._matchNotCompileLink(href) && // -> true
     !config.ignore            // -> false
   ) {
     /* in this case: this part will not run */
     if (href === compilerClass.config.homepage) {
       href = 'README';
     }
     href = router.toURL(href, null, router.getCurrentPath()); // Relative path resolving to absolute path?
   } else {
     /* in this case: this part will run */
     if (!isAbsolutePath(href) && href.slice(0, 2) === './') {
       //     -> true                  -> true
       /* in this case: this part will run */
       href =
         document.URL.replace(/\/(?!.*\/).*/, '/').replace('#/./', '') + href;
           // Remove from last '/' to end of URL, and reemove '#/./' (for compile ignored link) ?
     }
     // for 'mailto:' link process?
     // ...
   }

   About this part:

       href =
         document.URL.replace(/\/(?!.*\/).*/, '/').replace('#/./', '') + href;
           // Remove string from last '/', remove '#/./' (for compile ignored link) ?

   If current document URL: http://localhost:3000/#/page/any_doc
   If wrote link: ./any_file.pdf

   document.URL
   // -> http://localhost:3000/#/page/any_doc
   document.URL.replace(/\/(?!.*\/).*/, '/').replace('#/./', '')
   // -> http://localhost:3000/#/page/
   href
   // -> ./any_file.pdf
   document.URL.replace(/\/(?!.*\/).*/, '/').replace('#/./', '') + href
   // -> http://localhost:3000/#/page/./any_file.pdf
   // (but should be: http://localhost:3000/page/any_file.pdf)

   👍React with 👍1Reacted by Koy Zhuang
3. trusktr commented on Nov 13, 2023

   

   trusktr

   on Nov 13, 2023

   Member

   More actions

   I think we should be letting the browser handle URLs natively. F.e. maybe we can use new URL('./relative/file.foo', base) where base could be the site base path like http://localhost:3000/#/page/any_doc. So that we avoid doing relative path logic if the browser already can.

   Does URL support having # in the base? If not, then that would prevent the idea from being feasible. Need to try it
4. sy-records

   self-assigned this

   on Jul 25, 2025
5. sy-records

   added

   bugconfirmed as a bugconfirmed as a bug

   and removed

   needs investigation

   on Jul 25, 2025
6. sy-records

   closed this as completedin #2579on Aug 30, 2025