Skip to content

Accessibility - hidden anchors are still tabbable #2225

Description

@kburk1997

Bug Report

Steps to reproduce

  1. Go to develop preview
  2. Press Tab key to move to next focusable element on the page
  3. Repeat step 2 until "Edit document" link is focused

Current behaviour

Sidebar items remain in the tab order regardless of whether the menu is open or closed.
Screen recording with keystrokes:

Screen.Recording.2023-09-12.at.11.11.40.AM.mov

Expected behaviour

Hidden sidebar items are not tabbable when closed.
Sidebar items are tabbable when the sidebar is open.

Other relevant information

  • Docsify version: latest
  • Bug still occurs when all/other plugins are disabled?

  • Docsify plugins (if the bug happens when plugins enabled, please try to isolate the issue): n/s

Activity

  1. added a commit that references this issue on Oct 14, 2023
    96e6c88
  2. jhildenbiddle commented on Oct 17, 2023

    @jhildenbiddle
    Member

    Thanks for creating the issue, @kburk1997!

    I've created a draft PR here: #2265. In that PR you will find a preview link which will allow you to review the changes:

    CleanShot 2023-10-17 at 08 59 27@2x

    Before I mark this PR as ready for review by the maintainers, I would love to get your thoughts and/or feedback.

    Thanks!

  3. linked a pull request that will close this issueFeat: Prevent focus on hidden sidebar #2265on Nov 16, 2023
  4. added a commit that references this issue on Nov 16, 2023
    ae71c69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions