Repository navigation
Sidebar button does not have a description useful for screen reader users #658
Description
Accessibility test errors
It would be nice to have an aria-label attribute that will help screen reader users understand what action will perform the button.
Without an aria-label attribute:
- the sidebar button is identified by the screen readers only as a button element
- impossible to the user to know what action will perform the button, once clicked / selected
aria-label has no effect on browsers. It only helps assistive technology attach a label to an HTML element.
Activity
cheng-kang commentedon Oct 31, 2018
This is definitely a thing to be added. Would be best if you could make some suggestions about the labels 😄
andrapetronela commentedon Oct 31, 2018
aria-label="Toggle sidebar">aria-label="Search through site content">What do you think, @cheng-kang? :)
chris-79 commentedon May 15, 2019
Bump
We need this
jhildenbiddle commentedon Oct 17, 2023
Thanks for creating the issue and for your patience white waiting for it to be addressed, @andrapetronela.
I've created a draft PR here: #2253. In that PR you will find a preview link which will allow you to review the changes:
Before I mark this PR as ready for review by the maintainers, I would love to get your thoughts and/or feedback.
Thanks!