Repository navigation
When relativePath: true, even absolute paths are for icons in sidebar are resolved as relative. #877
Description
Activity
While I understand your intention (and you're right), here's a small note:
But both of the mentioned paths are absolute paths:- /subfolder/assets/home.svg
- /assets/home.svg
they simple start at a different root-directory. A relative path would ideally start with an './' (or even without a slash).
This is an important feature, because otherwise it's cumbersome to link from one .md to the contents of another <sibling/parent/child>.md.
Resolving image seems to use a different algorithm that's why images are not working.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
I can reproduce this in any page:
is resolved as:
{base-path}#/_assets/secure-website.pngwhen i'm e.g. at#/quickstart, but as{base-path}#/ja/_assets/secure-website.png, which doesn't exists and returns 404, when i'm e.g. at#/ja/quickstart.
Given the URL is absolute I don't understand why Docsify feels like it should consider it relative, especially since I don't set
relativePath.Reacted by Kenneth Geerts, Frédéric Hannes, Chris Andrew, Petr Broz, Rostislav Kirillov, Amir and PhilBug acknowledged. Tracking with #1891.
Bug Report
When
relativePath: true, absolute paths are for icons in sidebar are resolved as relative.Steps to reproduce
Set
relativePath: trueIn the both _sidebar files, I have
- [Home](/ "Home")What is current behaviour
While the link gets resolved as absolute (👍 ),
for images,
the data-origin is correct (👍 ), but the img scr is relative and thus failing (👎 )
What is the expected behaviour
The img src should be absolute:
"/assets/home.svg"
Other relevant information
Bug does still occur when all/other plugins are disabled?
Your OS:
Node.js version:
npm/yarn version:
Browser version:
Docsify version: 4.9.4
Docsify plugins: pagination, themeable