Skip to content

Accessibility issues #945

Closed
Closed

Description

@PicchiKevin

Hi,

Here are some issues that I found regarding accessibility:

  • Viewport not allowing to scale and zoom
  • The burger menu button must have discernible text
  • The burger menu button must have a :focus styling
  • Search plugin is text missing a label for the search input
  • Search text input is also missing a :focus styling

Low contrast text according to Web Content Accessibility Guidelines (WCAG) 2.1:

  • Between #42b983 and #ffffff (ratio: 2.47)
  • Between #858585 and #ffffff (ratio: 3.69)
  • Between #e96900 and #ffffff (ratio: 3.04)
  • Between #36bc98 and #ffffff (ratio: 2.38)

I also do like to note that some of the image alternate text can be improved.

I can submit a PR for the first 5 issues, but what should we do about the contrast ratio ?

PS: Sorry about not following the templates, but this is not a bug report nor a feature request

Activity

  1. anikethsaha commented on Nov 21, 2019

    @anikethsaha
    Member

    The burger menu button must have discernible text

    You meant a tooltip ?

    Search text input is also missing a :focus styling

    what style are you planning to add in the focus?

    Feel free to submit a PR

    We can take a look at the ratio thing Future.

  2. PicchiKevin commented on Nov 25, 2019

    @PicchiKevin
    ContributorAuthor

    For the burger menu an aria label should do the trick although the button seems a bit small.

    And for the text input here is what I was thinking of :
    screenshot on the search bar of docsify with an outer glow
    (An outer glow should be enough I thing, with the theme color)

  3. anikethsaha commented on Nov 25, 2019

    @anikethsaha
    Member

    For the burger menu an aria label should do the trick although the button seems a bit small.

    Can you try this and share the screenshot

    And about the input, try something which will work with other theme too. And I think the outer glow is bit more, try reducing it little bit

  4. added a commit that references this issue on May 7, 2020
  5. added a commit that references this issue on Mar 22, 2024
    8d5787e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions