Skip to content

Fix nested toc style issue on sidebar - #595

Merged
QingWei-Li merged 1 commit into
docsifyjs:masterfrom
keelii:fix/nested-heading-sidebar
Aug 8, 2018
Merged

QingWei-Li merged 1 commit into
docsifyjs:masterfrom
keelii:fix/nested-heading-sidebar

Conversation

@keelii

@keelii keelii commented Jul 31, 2018 •

Copy link
Copy Markdown
Contributor

This PR is trying to fix nested toc style issue below.

Before
before

After
after

Here is my solution.

  1. Remove recursive toc outer tag li
  2. remove .sidebar li marginLeft
  3. add .sidebar ul marginLeft

Related issue:
#421
#519

1. Remove recursive toc outer tag li
2. remove .sidebar li marginLeft
3. add .sidebar ul marginLeft
@jhildenbiddle

Copy link
Copy Markdown
Member

I haven't tested the PR, but if this fixes the inconsistent nesting then I'm all for it!

Thanks, @keelii. Looking forward to this being merged.

@QingWei-Li
QingWei-Li merged commit 100ab01 into docsifyjs:master Aug 8, 2018
@ThomsonTang

Copy link
Copy Markdown

The issue haven't been fixed. How to solve it? @keelii Thanks!

@keelii

keelii commented Aug 30, 2018

Copy link
Copy Markdown
Contributor Author

@ThomsonTang This PR has being merged, just waiting for next release or you can read Files change fix it by yourself.

@ThomsonTang

Copy link
Copy Markdown

@keelii I change the files on my local machine about this PR then that's all right. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants