Repository navigation
Conversation
added 2 commits
October 3, 2026 15:05
- Implement KartSus functions to match MWCC 2.6 decompilation - Flip Yamamoto/kartSus.cpp to Matching in configure.py - Unit now 100% matched (matched_code=6188, 19/19 functions) - complete_units 518 -> 519, complete_code +6188, no regressions
Rename the _xxx placeholder member variables in KartSus to descriptive names
and split the large u8 arrays into properly-typed members:
- _a8[8] -> f32 mSpring, f32 mDamp
- _bc[4] -> f32 mSusForce
- _27c[8] -> f32 mTireGrip, f32 mGripScale
- _290[60]-> f32/u8/u32 members (mSusPower, mSusPowerMul, mTireSusA/B,
mSusParam0, mSusState, mSpringBase/Max/Min/K/Div, mSuspRearY,
mSuspFrontY, mSusParam2, mObjKind)
Also rename scalar/vector/matrix placeholders (mSusMtx, mTireMtx, mArmMtx,
mSuspArmMtx, mSuspMtx, mDumpMtx, mDumpArmMtx, mWheelRPM, mRPM, etc.) and
update all references across kartCtrlInfo.cpp, KartDisp.cpp, KartDossin.cpp,
KartSound.cpp, kartBody.cpp, KartCrash.cpp. All 19 kartSus functions remain
100% matched (no regression).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100% LLM-generated, no human review yet. Will review to comply with LLM contribution policy later.