TVec3 but no UB by Mrkol · Pull Request #382 · doldecomp/sms

Mrkol · 2026-11-01T02:04:26Z

No description provided.

decomp-dev · 2026-11-01T02:08:08Z

Report for GMSP01_NX (`3e70d1b` - `315a366`)

📈 Matched code: 50.14% (+0.04%, +1420 bytes)

✅ 6 new matches

Unit	Item	Bytes	Before	After
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::operator*=(float)`	+40	0.00%	100.00%
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::TVec3(const JGeometry::TVec3<float>&)`	+28	0.00%	100.00%
`mario/NPC/NpcWalkTurn`	`JGeometry::TVec3<float>::set<float>(float, float, float)`	+16	0.00%	100.00%
`mario/Enemy/killer`	`TFlyEnemy::fly()`	+2	99.72%	100.00%
`mario/Player/MarioCollision`	`TMario::isTakeSituation(THitActor*)`	+1	99.80%	100.00%
`mario/Player/MarioSound`	`TMario::soundTorocco()`	+1	99.59%	100.00%

📈 25 improvements in unmatched items

Unit	Item	Bytes	Before	After
`mario/MoveBG/MapObjPlane`	`TMapObjPlane::calcNrm(int, int)`	+542	55.34%	99.83%
`mario/System/EventWatcher`	`evWarpFrontToMario(TSpcTypedInterp<TEventWatcher>*, unsigned long)`	+88	84.15%	99.70%
`mario/NPC/NpcWalkTurn`	`TBaseNPC::execWalk(bool)`	+73	92.53%	99.81%
`mario/Player/MarioCollision`	`TMario::damageExec(THitActor*, int, int, int, float, int, float, short)`	+68	93.13%	97.84%
`mario/Player/MarioSpecial`	`TMario::wireRolling()`	+65	59.63%	63.14%
`mario/Player/MarioSpecial`	`TMario::wireSWait()`	+60	89.30%	95.89%
`mario/Player/Tongue`	`TYoshiTongue::movement()`	+60	95.18%	97.88%
`mario/Enemy/walker`	`TWalker::bind(TLiveActor*)`	+48	98.07%	99.57%
`mario/Player/MarioSpecial`	`TMario::wireHanging()`	+45	51.45%	54.40%
`mario/Enemy/enemy`	`TSpineEnemy::zigzagToCurPathNode(float, float, float, float)`	+40	95.51%	98.78%
`mario/Player/MarioSpecial`	`TMario::wireWait()`	+37	66.30%	69.62%
`mario/GC2D/SelectShine2`	`TSelectShineManager::perform(unsigned long, JDrama::TGraphics*)`	+26	87.83%	90.02%
`mario/NPC/NpcCallback`	`NPCNeckCallBack(J3DNode*, int)`	+15	94.26%	95.67%
`mario/Enemy/enemyAttachment`	`TEnemyAttachment::bind()`	+8	98.57%	99.74%
`mario/Enemy/hamukuri`	`TNerveHaneHamuKuriMoveOnGraph::execute(TSpineBase<TLiveActor>*) const`	+1	97.57%	97.67%
`mario/Enemy/elecNokonoko`	`TElecCarapace::shoot()`	+1	96.39%	96.45%
`mario/Enemy/fireWanwan`	`TFireWanwan::bindPoint(JGeometry::TVec3<float>, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, float, TBGWallCheckRecord)`	+1	99.69%	99.72%
`mario/Enemy/wireBinder`	`TWireBinder::bind(TLiveActor*)`	+1	99.57%	99.60%
`mario/MarioUtil/DrawUtil`	`TTrembleModelEffect::clash(float)`	+1	97.28%	97.44%
`mario/Enemy/gesso`	`TNerveGessoFall::execute(TSpineBase<TLiveActor>*) const`	0	99.84%	99.85%
`mario/Enemy/poihana`	`TPoiHana::genEventCoin()`	0	99.74%	99.83%
`mario/Enemy/BossHanachanMain`	`TBossHanachan::bind()`	0	99.55%	99.58%
`mario/Enemy/Kumokun`	`TKumokun::bind()`	0	97.66%	97.66%
`mario/Player/MarioSpecial`	`TMario::fenceMove()`	0	99.82%	99.83%
`mario/Player/MarioParticle`	`TMario::toroccoEffect()`	0	99.65%	99.75%

📉 24 regressions in unmatched items

Unit	Item	Bytes	Before	After
`mario/Player/MarioMove`	`TMario::gunExec()`	-2	98.37%	98.26%
`mario/Player/MarioSpecial`	`TMario::pulling()`	-2	98.23%	98.13%
`mario/Animal/boid`	`TBoidLeader::calcForces(const TBoid*) const`	-1	99.55%	99.53%
`mario/Camera/cameralib`	`CLBRotatePosAndUp(short, short, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, JGeometry::TVec3<float>, JGeometry::TVec3<float>)`	-1	97.91%	97.85%
`mario/Enemy/fireWanwan`	`TTailRubber::bindOne(TTailRubber::Node&)`	-1	99.32%	98.96%
`mario/Enemy/chuuhana`	`TChuuHana::attackToMario()`	-1	99.95%	99.79%
`mario/Enemy/chuuhana`	`TChuuHana::bind()`	-1	99.96%	99.78%
`mario/Enemy/BossHanachanSub`	`TSphereLink::setDegreeZAndRevisionPosXZ(int, float)`	-1	97.82%	97.68%
`mario/Enemy/Kumokun`	`TKumokun::bindOnFlying()`	-1	99.46%	99.41%
`mario/Enemy/Amenbo`	`TAmenbo::bind()`	-1	99.96%	99.80%
`mario/Enemy/coasterkiller`	`TCoasterEnemy::bind()`	-1	99.87%	99.45%
`mario/Strategic/liveactor`	`TLiveActor::bind()`	-1	99.95%	99.76%
`mario/Player/MarioSpecial`	`TMario::wireMove(float)`	-1	99.69%	99.62%
`mario/Player/Tongue`	`TYoshiTongue::emit(const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&)`	-1	99.80%	99.73%
`mario/Enemy/emario`	`TEMario::perform(unsigned long, JDrama::TGraphics*)`	0	99.85%	99.81%
`mario/Enemy/tamaNoko`	`TTamaNoko::landEffect()`	0	99.71%	99.68%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaHideWait::execute(TSpineBase<TLiveActor>*) const`	0	99.77%	99.70%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaFallDemo::execute(TSpineBase<TLiveActor>*) const`	0	99.97%	99.91%
`mario/Enemy/bombhei`	`TBombHei::genEventCoin()`	0	99.90%	99.71%
`mario/Enemy/hauntLeg`	`TNerveHauntLegHaunt::execute(TSpineBase<TLiveActor>*) const`	0	96.95%	96.91%
`mario/MoveBG/MapObjGeneral`	`TMapObjGeneral::bind()`	0	99.79%	99.69%
`mario/Player/MarioMove`	`TMario::moveRequest(const JGeometry::TVec3<float>&)`	0	99.93%	99.85%
`mario/Player/MarioPhysics`	`TMario::keepDistance(const JGeometry::TVec3<float>&, float, float)`	0	99.50%	99.43%
`mario/Player/Tongue`	`TYoshiTongue::canGo()`	0	99.71%	99.68%

Report for GMSP01 (`3e70d1b` - `315a366`)

📈 Matched code: 50.90% (+0.04%, +1420 bytes)

✅ 6 new matches

Unit	Item	Bytes	Before	After
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::operator*=(float)`	+40	0.00%	100.00%
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::TVec3(const JGeometry::TVec3<float>&)`	+28	0.00%	100.00%
`mario/NPC/NpcWalkTurn`	`JGeometry::TVec3<float>::set<float>(float, float, float)`	+16	0.00%	100.00%
`mario/Enemy/killer`	`TFlyEnemy::fly()`	+2	99.72%	100.00%
`mario/Player/MarioCollision`	`TMario::isTakeSituation(THitActor*)`	+1	99.80%	100.00%
`mario/Player/MarioSound`	`TMario::soundTorocco()`	+1	99.59%	100.00%

📈 25 improvements in unmatched items

Unit	Item	Bytes	Before	After
`mario/MoveBG/MapObjPlane`	`TMapObjPlane::calcNrm(int, int)`	+542	55.34%	99.83%
`mario/System/EventWatcher`	`evWarpFrontToMario(TSpcTypedInterp<TEventWatcher>*, unsigned long)`	+88	84.15%	99.70%
`mario/NPC/NpcWalkTurn`	`TBaseNPC::execWalk(bool)`	+73	92.53%	99.81%
`mario/Player/MarioCollision`	`TMario::damageExec(THitActor*, int, int, int, float, int, float, short)`	+68	93.14%	97.84%
`mario/Player/MarioSpecial`	`TMario::wireRolling()`	+65	59.64%	63.14%
`mario/Player/MarioSpecial`	`TMario::wireSWait()`	+60	89.30%	95.89%
`mario/Player/Tongue`	`TYoshiTongue::movement()`	+60	95.18%	97.88%
`mario/Enemy/walker`	`TWalker::bind(TLiveActor*)`	+48	98.07%	99.57%
`mario/Player/MarioSpecial`	`TMario::wireHanging()`	+45	51.46%	54.41%
`mario/Enemy/enemy`	`TSpineEnemy::zigzagToCurPathNode(float, float, float, float)`	+40	95.51%	98.78%
`mario/Player/MarioSpecial`	`TMario::wireWait()`	+37	66.30%	69.62%
`mario/GC2D/SelectShine2`	`TSelectShineManager::perform(unsigned long, JDrama::TGraphics*)`	+26	87.83%	90.02%
`mario/NPC/NpcCallback`	`NPCNeckCallBack(J3DNode*, int)`	+15	94.26%	95.67%
`mario/Enemy/enemyAttachment`	`TEnemyAttachment::bind()`	+8	98.57%	99.74%
`mario/Enemy/hamukuri`	`TNerveHaneHamuKuriMoveOnGraph::execute(TSpineBase<TLiveActor>*) const`	+1	97.57%	97.67%
`mario/Enemy/elecNokonoko`	`TElecCarapace::shoot()`	+1	96.39%	96.45%
`mario/Enemy/fireWanwan`	`TFireWanwan::bindPoint(JGeometry::TVec3<float>, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, float, TBGWallCheckRecord)`	+1	99.69%	99.72%
`mario/Enemy/wireBinder`	`TWireBinder::bind(TLiveActor*)`	+1	99.57%	99.60%
`mario/MarioUtil/DrawUtil`	`TTrembleModelEffect::clash(float)`	+1	97.28%	97.44%
`mario/Enemy/gesso`	`TNerveGessoFall::execute(TSpineBase<TLiveActor>*) const`	0	99.84%	99.85%
`mario/Enemy/poihana`	`TPoiHana::genEventCoin()`	0	99.74%	99.83%
`mario/Enemy/BossHanachanMain`	`TBossHanachan::bind()`	0	99.55%	99.58%
`mario/Enemy/Kumokun`	`TKumokun::bind()`	0	97.66%	97.66%
`mario/Player/MarioSpecial`	`TMario::fenceMove()`	0	99.82%	99.83%
`mario/Player/MarioParticle`	`TMario::toroccoEffect()`	0	99.65%	99.75%

📉 24 regressions in unmatched items

Unit	Item	Bytes	Before	After
`mario/Player/MarioSpecial`	`TMario::pulling()`	-2	98.23%	98.13%
`mario/Animal/boid`	`TBoidLeader::calcForces(const TBoid*) const`	-1	99.55%	99.53%
`mario/Camera/cameralib`	`CLBRotatePosAndUp(short, short, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, JGeometry::TVec3<float>, JGeometry::TVec3<float>)`	-1	97.91%	97.85%
`mario/Enemy/fireWanwan`	`TTailRubber::bindOne(TTailRubber::Node&)`	-1	99.32%	98.96%
`mario/Enemy/chuuhana`	`TChuuHana::attackToMario()`	-1	99.95%	99.79%
`mario/Enemy/chuuhana`	`TChuuHana::bind()`	-1	99.96%	99.78%
`mario/Enemy/BossHanachanSub`	`TSphereLink::setDegreeZAndRevisionPosXZ(int, float)`	-1	97.82%	97.68%
`mario/Enemy/Kumokun`	`TKumokun::bindOnFlying()`	-1	99.46%	99.41%
`mario/Enemy/Amenbo`	`TAmenbo::bind()`	-1	99.96%	99.80%
`mario/Enemy/coasterkiller`	`TCoasterEnemy::bind()`	-1	99.87%	99.45%
`mario/Strategic/liveactor`	`TLiveActor::bind()`	-1	99.95%	99.76%
`mario/Player/MarioMove`	`TMario::gunExec()`	-1	98.40%	98.29%
`mario/Player/MarioSpecial`	`TMario::wireMove(float)`	-1	99.69%	99.62%
`mario/Player/Tongue`	`TYoshiTongue::emit(const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&)`	-1	99.80%	99.73%
`mario/Enemy/emario`	`TEMario::perform(unsigned long, JDrama::TGraphics*)`	0	99.85%	99.81%
`mario/Enemy/tamaNoko`	`TTamaNoko::landEffect()`	0	99.71%	99.68%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaHideWait::execute(TSpineBase<TLiveActor>*) const`	0	99.77%	99.70%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaFallDemo::execute(TSpineBase<TLiveActor>*) const`	0	99.97%	99.91%
`mario/Enemy/bombhei`	`TBombHei::genEventCoin()`	0	99.90%	99.71%
`mario/Enemy/hauntLeg`	`TNerveHauntLegHaunt::execute(TSpineBase<TLiveActor>*) const`	0	96.95%	96.91%
`mario/MoveBG/MapObjGeneral`	`TMapObjGeneral::bind()`	0	99.79%	99.69%
`mario/Player/MarioMove`	`TMario::moveRequest(const JGeometry::TVec3<float>&)`	0	99.93%	99.85%
`mario/Player/MarioPhysics`	`TMario::keepDistance(const JGeometry::TVec3<float>&, float, float)`	0	99.50%	99.43%
`mario/Player/Tongue`	`TYoshiTongue::canGo()`	0	99.71%	99.68%

Report for GMSJ01 (`3e70d1b` - `315a366`)

📈 Matched code: 51.88% (+0.04%, +1448 bytes)

✅ 7 new matches

Unit	Item	Bytes	Before	After
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::operator*=(float)`	+40	0.00%	100.00%
`mario/System/EventWatcher`	`JGeometry::TVec3<float>::set(const Vec&)`	+28	0.00%	100.00%
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::TVec3(const JGeometry::TVec3<float>&)`	+28	0.00%	100.00%
`mario/NPC/NpcWalkTurn`	`JGeometry::TVec3<float>::set<float>(float, float, float)`	+16	0.00%	100.00%
`mario/Enemy/killer`	`TFlyEnemy::fly()`	+2	99.72%	100.00%
`mario/Player/MarioCollision`	`TMario::isTakeSituation(THitActor*)`	+1	99.80%	100.00%
`mario/Player/MarioSound`	`TMario::soundTorocco()`	+1	99.59%	100.00%

📈 25 improvements in unmatched items

Unit	Item	Bytes	Before	After
`mario/MoveBG/MapObjPlane`	`TMapObjPlane::calcNrm(int, int)`	+542	55.34%	99.83%
`mario/System/EventWatcher`	`evWarpFrontToMario(TSpcTypedInterp<TEventWatcher>*, unsigned long)`	+88	84.15%	99.70%
`mario/NPC/NpcWalkTurn`	`TBaseNPC::execWalk(bool)`	+73	92.53%	99.81%
`mario/Player/MarioCollision`	`TMario::damageExec(THitActor*, int, int, int, float, int, float, short)`	+68	93.14%	97.84%
`mario/Player/MarioSpecial`	`TMario::wireRolling()`	+65	68.26%	71.55%
`mario/Player/MarioSpecial`	`TMario::wireSWait()`	+60	89.30%	95.89%
`mario/Player/Tongue`	`TYoshiTongue::movement()`	+60	95.18%	97.88%
`mario/Enemy/walker`	`TWalker::bind(TLiveActor*)`	+48	98.07%	99.57%
`mario/Player/MarioSpecial`	`TMario::wireHanging()`	+47	61.40%	64.28%
`mario/Enemy/enemy`	`TSpineEnemy::zigzagToCurPathNode(float, float, float, float)`	+40	95.51%	98.78%
`mario/Player/MarioSpecial`	`TMario::wireWait()`	+37	66.30%	69.62%
`mario/GC2D/SelectShine2`	`TSelectShineManager::perform(unsigned long, JDrama::TGraphics*)`	+26	87.83%	90.02%
`mario/NPC/NpcCallback`	`NPCNeckCallBack(J3DNode*, int)`	+15	94.26%	95.67%
`mario/Enemy/enemyAttachment`	`TEnemyAttachment::bind()`	+8	98.57%	99.74%
`mario/MarioUtil/DrawUtil`	`TTrembleModelEffect::clash(float)`	+1	97.28%	97.44%
`mario/Enemy/hamukuri`	`TNerveHaneHamuKuriMoveOnGraph::execute(TSpineBase<TLiveActor>*) const`	+1	97.57%	97.67%
`mario/Enemy/elecNokonoko`	`TElecCarapace::shoot()`	+1	96.39%	96.45%
`mario/Enemy/fireWanwan`	`TFireWanwan::bindPoint(JGeometry::TVec3<float>, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, float, TBGWallCheckRecord)`	+1	99.69%	99.72%
`mario/Enemy/wireBinder`	`TWireBinder::bind(TLiveActor*)`	+1	99.57%	99.60%
`mario/Player/MarioSpecial`	`TMario::fenceMove()`	0	99.82%	99.83%
`mario/Player/MarioParticle`	`TMario::toroccoEffect()`	0	99.65%	99.75%
`mario/Enemy/gesso`	`TNerveGessoFall::execute(TSpineBase<TLiveActor>*) const`	0	99.84%	99.85%
`mario/Enemy/poihana`	`TPoiHana::genEventCoin()`	0	99.74%	99.83%
`mario/Enemy/BossHanachanMain`	`TBossHanachan::bind()`	0	99.55%	99.58%
`mario/Enemy/Kumokun`	`TKumokun::bind()`	0	97.66%	97.66%

📉 25 regressions in unmatched items

Unit	Item	Bytes	Before	After
`mario/Player/MarioSpecial`	`TMario::pulling()`	-2	98.23%	98.13%
`mario/Strategic/liveactor`	`TLiveActor::bind()`	-1	99.95%	99.76%
`mario/Player/MarioMove`	`TMario::gunExec()`	-1	98.40%	98.29%
`mario/Player/MarioSpecial`	`TMario::wireMove(float)`	-1	99.69%	99.62%
`mario/Player/Tongue`	`TYoshiTongue::emit(const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&)`	-1	99.80%	99.73%
`mario/Player/Tongue`	`TYoshiTongue::findTarget(bool, bool)`	-1	99.78%	99.75%
`mario/Enemy/fireWanwan`	`TTailRubber::bindOne(TTailRubber::Node&)`	-1	99.32%	98.96%
`mario/Enemy/chuuhana`	`TChuuHana::attackToMario()`	-1	99.95%	99.79%
`mario/Enemy/chuuhana`	`TChuuHana::bind()`	-1	99.96%	99.78%
`mario/Enemy/BossHanachanSub`	`TSphereLink::setDegreeZAndRevisionPosXZ(int, float)`	-1	97.82%	97.68%
`mario/Enemy/Kumokun`	`TKumokun::bindOnFlying()`	-1	99.46%	99.41%
`mario/Enemy/Amenbo`	`TAmenbo::bind()`	-1	99.96%	99.80%
`mario/Enemy/coasterkiller`	`TCoasterEnemy::bind()`	-1	99.87%	99.45%
`mario/Camera/cameralib`	`CLBRotatePosAndUp(short, short, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, JGeometry::TVec3<float>, JGeometry::TVec3<float>)`	-1	97.91%	97.85%
`mario/Animal/boid`	`TBoidLeader::calcForces(const TBoid*) const`	-1	99.55%	99.53%
`mario/Player/MarioMove`	`TMario::moveRequest(const JGeometry::TVec3<float>&)`	0	99.93%	99.85%
`mario/Player/MarioPhysics`	`TMario::keepDistance(const JGeometry::TVec3<float>&, float, float)`	0	99.50%	99.43%
`mario/Player/Tongue`	`TYoshiTongue::canGo()`	0	99.71%	99.68%
`mario/MoveBG/MapObjGeneral`	`TMapObjGeneral::bind()`	0	99.79%	99.69%
`mario/Enemy/emario`	`TEMario::perform(unsigned long, JDrama::TGraphics*)`	0	99.85%	99.81%
`mario/Enemy/tamaNoko`	`TTamaNoko::landEffect()`	0	99.71%	99.68%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaHideWait::execute(TSpineBase<TLiveActor>*) const`	0	99.77%	99.70%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaFallDemo::execute(TSpineBase<TLiveActor>*) const`	0	99.97%	99.91%
`mario/Enemy/bombhei`	`TBombHei::genEventCoin()`	0	99.90%	99.71%
`mario/Enemy/hauntLeg`	`TNerveHauntLegHaunt::execute(TSpineBase<TLiveActor>*) const`	0	96.95%	96.91%

Report for GMSE01 (`3e70d1b` - `315a366`)

📈 Matched code: 49.84% (+0.04%, +1420 bytes)

✅ 6 new matches

Unit	Item	Bytes	Before	After
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::operator*=(float)`	+40	0.00%	100.00%
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::TVec3(const JGeometry::TVec3<float>&)`	+28	0.00%	100.00%
`mario/NPC/NpcWalkTurn`	`JGeometry::TVec3<float>::set<float>(float, float, float)`	+16	0.00%	100.00%
`mario/Enemy/killer`	`TFlyEnemy::fly()`	+2	99.72%	100.00%
`mario/Player/MarioCollision`	`TMario::isTakeSituation(THitActor*)`	+1	99.80%	100.00%
`mario/Player/MarioSound`	`TMario::soundTorocco()`	+1	99.59%	100.00%

📈 25 improvements in unmatched items

Unit	Item	Bytes	Before	After
`mario/MoveBG/MapObjPlane`	`TMapObjPlane::calcNrm(int, int)`	+542	55.34%	99.83%
`mario/System/EventWatcher`	`evWarpFrontToMario(TSpcTypedInterp<TEventWatcher>*, unsigned long)`	+88	84.15%	99.70%
`mario/NPC/NpcWalkTurn`	`TBaseNPC::execWalk(bool)`	+73	92.53%	99.81%
`mario/Player/MarioCollision`	`TMario::damageExec(THitActor*, int, int, int, float, int, float, short)`	+68	93.14%	97.84%
`mario/Player/MarioSpecial`	`TMario::wireRolling()`	+65	59.64%	63.14%
`mario/Player/MarioSpecial`	`TMario::wireSWait()`	+60	89.30%	95.89%
`mario/Player/Tongue`	`TYoshiTongue::movement()`	+60	95.18%	97.88%
`mario/Enemy/walker`	`TWalker::bind(TLiveActor*)`	+47	98.06%	99.56%
`mario/Player/MarioSpecial`	`TMario::wireHanging()`	+45	51.46%	54.41%
`mario/Enemy/enemy`	`TSpineEnemy::zigzagToCurPathNode(float, float, float, float)`	+40	95.51%	98.78%
`mario/Player/MarioSpecial`	`TMario::wireWait()`	+37	66.30%	69.62%
`mario/GC2D/SelectShine2`	`TSelectShineManager::perform(unsigned long, JDrama::TGraphics*)`	+26	87.83%	90.02%
`mario/NPC/NpcCallback`	`NPCNeckCallBack(J3DNode*, int)`	+15	94.26%	95.67%
`mario/Enemy/enemyAttachment`	`TEnemyAttachment::bind()`	+8	98.57%	99.74%
`mario/Enemy/hamukuri`	`TNerveHaneHamuKuriMoveOnGraph::execute(TSpineBase<TLiveActor>*) const`	+1	97.57%	97.67%
`mario/Enemy/elecNokonoko`	`TElecCarapace::shoot()`	+1	96.39%	96.45%
`mario/Enemy/fireWanwan`	`TFireWanwan::bindPoint(JGeometry::TVec3<float>, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, float, TBGWallCheckRecord)`	+1	99.69%	99.72%
`mario/Enemy/wireBinder`	`TWireBinder::bind(TLiveActor*)`	+1	99.57%	99.60%
`mario/MarioUtil/DrawUtil`	`TTrembleModelEffect::clash(float)`	+1	97.28%	97.44%
`mario/Enemy/gesso`	`TNerveGessoFall::execute(TSpineBase<TLiveActor>*) const`	0	99.84%	99.85%
`mario/Enemy/poihana`	`TPoiHana::genEventCoin()`	0	99.74%	99.83%
`mario/Enemy/BossHanachanMain`	`TBossHanachan::bind()`	0	99.55%	99.58%
`mario/Enemy/Kumokun`	`TKumokun::bind()`	0	97.66%	97.66%
`mario/Player/MarioSpecial`	`TMario::fenceMove()`	0	99.82%	99.83%
`mario/Player/MarioParticle`	`TMario::toroccoEffect()`	0	99.65%	99.75%

📉 24 regressions in unmatched items

Unit	Item	Bytes	Before	After
`mario/Player/MarioSpecial`	`TMario::pulling()`	-2	98.23%	98.13%
`mario/Animal/boid`	`TBoidLeader::calcForces(const TBoid*) const`	-1	99.55%	99.53%
`mario/Camera/cameralib`	`CLBRotatePosAndUp(short, short, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, JGeometry::TVec3<float>, JGeometry::TVec3<float>)`	-1	97.91%	97.85%
`mario/Enemy/fireWanwan`	`TTailRubber::bindOne(TTailRubber::Node&)`	-1	99.32%	98.96%
`mario/Enemy/chuuhana`	`TChuuHana::attackToMario()`	-1	99.95%	99.79%
`mario/Enemy/chuuhana`	`TChuuHana::bind()`	-1	99.96%	99.78%
`mario/Enemy/BossHanachanSub`	`TSphereLink::setDegreeZAndRevisionPosXZ(int, float)`	-1	97.82%	97.68%
`mario/Enemy/Kumokun`	`TKumokun::bindOnFlying()`	-1	99.46%	99.41%
`mario/Enemy/Amenbo`	`TAmenbo::bind()`	-1	99.96%	99.80%
`mario/Enemy/coasterkiller`	`TCoasterEnemy::bind()`	-1	99.87%	99.45%
`mario/Strategic/liveactor`	`TLiveActor::bind()`	-1	99.95%	99.76%
`mario/Player/MarioMove`	`TMario::gunExec()`	-1	98.40%	98.29%
`mario/Player/MarioSpecial`	`TMario::wireMove(float)`	-1	99.69%	99.62%
`mario/Player/Tongue`	`TYoshiTongue::emit(const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&)`	-1	99.80%	99.73%
`mario/Enemy/emario`	`TEMario::perform(unsigned long, JDrama::TGraphics*)`	0	99.85%	99.81%
`mario/Enemy/tamaNoko`	`TTamaNoko::landEffect()`	0	99.71%	99.68%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaHideWait::execute(TSpineBase<TLiveActor>*) const`	0	99.77%	99.70%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaFallDemo::execute(TSpineBase<TLiveActor>*) const`	0	99.97%	99.91%
`mario/Enemy/bombhei`	`TBombHei::genEventCoin()`	0	99.90%	99.71%
`mario/Enemy/hauntLeg`	`TNerveHauntLegHaunt::execute(TSpineBase<TLiveActor>*) const`	0	96.95%	96.91%
`mario/MoveBG/MapObjGeneral`	`TMapObjGeneral::bind()`	0	99.79%	99.69%
`mario/Player/MarioMove`	`TMario::moveRequest(const JGeometry::TVec3<float>&)`	0	99.93%	99.85%
`mario/Player/MarioPhysics`	`TMario::keepDistance(const JGeometry::TVec3<float>&, float, float)`	0	99.50%	99.43%
`mario/Player/Tongue`	`TYoshiTongue::canGo()`	0	99.71%	99.68%

Report for GMSJ01_01 (`3e70d1b` - `315a366`)

📈 Matched code: 50.48% (+0.04%, +1420 bytes)

✅ 6 new matches

Unit	Item	Bytes	Before	After
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::operator*=(float)`	+40	0.00%	100.00%
`mario/Player/MarioCollision`	`JGeometry::TVec3<float>::TVec3(const JGeometry::TVec3<float>&)`	+28	0.00%	100.00%
`mario/NPC/NpcWalkTurn`	`JGeometry::TVec3<float>::set<float>(float, float, float)`	+16	0.00%	100.00%
`mario/Enemy/killer`	`TFlyEnemy::fly()`	+2	99.72%	100.00%
`mario/Player/MarioCollision`	`TMario::isTakeSituation(THitActor*)`	+1	99.80%	100.00%
`mario/Player/MarioSound`	`TMario::soundTorocco()`	+1	99.59%	100.00%

📈 25 improvements in unmatched items

Unit	Item	Bytes	Before	After
`mario/MoveBG/MapObjPlane`	`TMapObjPlane::calcNrm(int, int)`	+542	55.34%	99.83%
`mario/System/EventWatcher`	`evWarpFrontToMario(TSpcTypedInterp<TEventWatcher>*, unsigned long)`	+88	84.15%	99.70%
`mario/NPC/NpcWalkTurn`	`TBaseNPC::execWalk(bool)`	+73	92.53%	99.81%
`mario/Player/MarioCollision`	`TMario::damageExec(THitActor*, int, int, int, float, int, float, short)`	+68	93.14%	97.84%
`mario/Player/MarioSpecial`	`TMario::wireRolling()`	+65	59.64%	63.14%
`mario/Player/MarioSpecial`	`TMario::wireSWait()`	+60	89.30%	95.89%
`mario/Player/Tongue`	`TYoshiTongue::movement()`	+60	95.18%	97.88%
`mario/Enemy/walker`	`TWalker::bind(TLiveActor*)`	+48	98.07%	99.57%
`mario/Player/MarioSpecial`	`TMario::wireHanging()`	+45	51.46%	54.41%
`mario/Enemy/enemy`	`TSpineEnemy::zigzagToCurPathNode(float, float, float, float)`	+40	95.51%	98.78%
`mario/Player/MarioSpecial`	`TMario::wireWait()`	+37	66.30%	69.62%
`mario/GC2D/SelectShine2`	`TSelectShineManager::perform(unsigned long, JDrama::TGraphics*)`	+26	87.83%	90.02%
`mario/NPC/NpcCallback`	`NPCNeckCallBack(J3DNode*, int)`	+15	94.26%	95.67%
`mario/Enemy/enemyAttachment`	`TEnemyAttachment::bind()`	+8	98.57%	99.74%
`mario/Enemy/hamukuri`	`TNerveHaneHamuKuriMoveOnGraph::execute(TSpineBase<TLiveActor>*) const`	+1	97.57%	97.67%
`mario/Enemy/elecNokonoko`	`TElecCarapace::shoot()`	+1	96.39%	96.45%
`mario/Enemy/fireWanwan`	`TFireWanwan::bindPoint(JGeometry::TVec3<float>, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, float, TBGWallCheckRecord)`	+1	99.69%	99.72%
`mario/Enemy/wireBinder`	`TWireBinder::bind(TLiveActor*)`	+1	99.57%	99.60%
`mario/MarioUtil/DrawUtil`	`TTrembleModelEffect::clash(float)`	+1	97.28%	97.44%
`mario/Enemy/gesso`	`TNerveGessoFall::execute(TSpineBase<TLiveActor>*) const`	0	99.84%	99.85%
`mario/Enemy/poihana`	`TPoiHana::genEventCoin()`	0	99.74%	99.83%
`mario/Enemy/BossHanachanMain`	`TBossHanachan::bind()`	0	99.55%	99.58%
`mario/Enemy/Kumokun`	`TKumokun::bind()`	0	97.66%	97.66%
`mario/Player/MarioSpecial`	`TMario::fenceMove()`	0	99.82%	99.83%
`mario/Player/MarioParticle`	`TMario::toroccoEffect()`	0	99.65%	99.75%

📉 24 regressions in unmatched items

Unit	Item	Bytes	Before	After
`mario/Player/MarioSpecial`	`TMario::pulling()`	-2	98.23%	98.13%
`mario/Animal/boid`	`TBoidLeader::calcForces(const TBoid*) const`	-1	99.55%	99.53%
`mario/Enemy/fireWanwan`	`TTailRubber::bindOne(TTailRubber::Node&)`	-1	99.32%	98.96%
`mario/Enemy/chuuhana`	`TChuuHana::attackToMario()`	-1	99.95%	99.79%
`mario/Enemy/chuuhana`	`TChuuHana::bind()`	-1	99.96%	99.78%
`mario/Enemy/BossHanachanSub`	`TSphereLink::setDegreeZAndRevisionPosXZ(int, float)`	-1	97.82%	97.68%
`mario/Enemy/Kumokun`	`TKumokun::bindOnFlying()`	-1	99.46%	99.41%
`mario/Enemy/Amenbo`	`TAmenbo::bind()`	-1	99.96%	99.80%
`mario/Enemy/coasterkiller`	`TCoasterEnemy::bind()`	-1	99.87%	99.45%
`mario/Strategic/liveactor`	`TLiveActor::bind()`	-1	99.95%	99.76%
`mario/Player/MarioMove`	`TMario::gunExec()`	-1	98.40%	98.29%
`mario/Player/MarioSpecial`	`TMario::wireMove(float)`	-1	99.69%	99.62%
`mario/Player/Tongue`	`TYoshiTongue::emit(const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&)`	-1	99.80%	99.73%
`mario/Camera/cameralib`	`CLBRotatePosAndUp(short, short, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, JGeometry::TVec3<float>, JGeometry::TVec3<float>)`	-1	97.91%	97.85%
`mario/Enemy/emario`	`TEMario::perform(unsigned long, JDrama::TGraphics*)`	0	99.85%	99.81%
`mario/Enemy/tamaNoko`	`TTamaNoko::landEffect()`	0	99.71%	99.68%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaHideWait::execute(TSpineBase<TLiveActor>*) const`	0	99.77%	99.70%
`mario/Enemy/bosstelesa`	`TNerveBossTelesaFallDemo::execute(TSpineBase<TLiveActor>*) const`	0	99.97%	99.91%
`mario/Enemy/bombhei`	`TBombHei::genEventCoin()`	0	99.90%	99.71%
`mario/Enemy/hauntLeg`	`TNerveHauntLegHaunt::execute(TSpineBase<TLiveActor>*) const`	0	96.95%	96.91%
`mario/MoveBG/MapObjGeneral`	`TMapObjGeneral::bind()`	0	99.79%	99.69%
`mario/Player/MarioMove`	`TMario::moveRequest(const JGeometry::TVec3<float>&)`	0	99.93%	99.85%
`mario/Player/MarioPhysics`	`TMario::keepDistance(const JGeometry::TVec3<float>&, float, float)`	0	99.50%	99.43%
`mario/Player/Tongue`	`TYoshiTongue::canGo()`	0	99.71%	99.68%

Mrkol added 2 commits November 1, 2026 05:03

TVec3 but no UB

fab7b5c

formatting

315a366

Navigation Menu

Repository navigation

TVec3 but no UB - #382

TVec3 but no UB#382
Mrkol wants to merge 2 commits into
mainfrom
tvec3

Mrkol commented Nov 1, 2026

Uh oh!

decomp-dev Bot commented Nov 1, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Mrkol commented Nov 1, 2026

Uh oh!

decomp-dev Bot commented Nov 1, 2026

Report for GMSP01_NX (3e70d1b - 315a366)

Report for GMSP01 (3e70d1b - 315a366)

Report for GMSJ01 (3e70d1b - 315a366)

Report for GMSE01 (3e70d1b - 315a366)

Report for GMSJ01_01 (3e70d1b - 315a366)

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Report for GMSP01_NX (`3e70d1b` - `315a366`)

Report for GMSP01 (`3e70d1b` - `315a366`)

Report for GMSJ01 (`3e70d1b` - `315a366`)

Report for GMSE01 (`3e70d1b` - `315a366`)

Report for GMSJ01_01 (`3e70d1b` - `315a366`)