Repository navigation
Require feature triage and coverage review for release notes - #10600
Merged
Merged
Conversation
Reject placeholder features.json files, carry scored candidates into component drafting, and reconcile noteworthy omissions during final and incremental review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7e7e9011-e85b-469d-88f5-7843d1de691f
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Feature validation and cross-branch aggregation remain incomplete.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Strengthens the release-notes workflow with complete feature triage and final editorial coverage review.
Changes:
- Requires populated, scored
features.jsonbefore drafting. - Removes draft-based scoring fallback.
- Adds final review for milestone drafts and omissions.
| File | Description |
|---|---|
.github/skills/update-existing-branch/SKILL.md |
Adds final review to refresh workflows. |
.github/skills/review-release-notes/SKILL.md |
Enforces complete triage and omission reconciliation. |
.github/skills/release-notes/SKILL.md |
Adds triage and final-review gates. |
.github/skills/release-notes/references/changes-schema.md |
Clarifies feature manifest requirements. |
.github/skills/generate-features/SKILL.md |
Requires shipped-change data and scored candidates. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Compare complete feature and change manifests, review drafts on their component branches, and record intentional omissions in feature score reasons. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7e7e9011-e85b-469d-88f5-7843d1de691f
Keep every shipped change and commit key in features.json while scoring only noteworthy candidates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7e7e9011-e85b-469d-88f5-7843d1de691f
danroth27
marked this pull request as ready for review
September 26, 2026 20:00
jongalloway
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
features.jsonwith shipped changes, commit mapping, and scored noteworthy candidates before drafting component release notes; reject schema stubs and slim candidate lists.features.jsonwas missing.This intentionally does not add fallback handling for missing milestones or incorrect area labels; those are upstream metadata/automation concerns.
Fixes #10435
Validation
git diff --checkpassed.