Skip to content

Enable Alpine Arm64 SOS builds - #1010

Merged
sdmaclea merged 2 commits into
dotnet:masterfrom
sdmaclea:AlpineArm64
Apr 10, 2020
Merged

sdmaclea merged 2 commits into
dotnet:masterfrom
sdmaclea:AlpineArm64

Conversation

@sdmaclea

Copy link
Copy Markdown
Contributor

Fixes #1009

@sdmaclea sdmaclea added this to the 5.0 milestone Apr 10, 2020
@sdmaclea
sdmaclea requested review from hoyosjs and mikem8361 April 10, 2020 18:56
@sdmaclea sdmaclea self-assigned this Apr 10, 2020

@hoyosjs hoyosjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good. Waiting for an internal build.

@mikem8361

Copy link
Copy Markdown
Contributor

Do we need/want to support Linux musl arm32 also? Is that a supported platform?

@sdmaclea

Copy link
Copy Markdown
Contributor Author

Do we need/want to support Linux musl arm32 also? Is that a supported platform?

It is not shipping yet. I think it is still in the backlog.

@hoyosjs

hoyosjs commented Apr 10, 2020

Copy link
Copy Markdown
Member

https://github.com/dotnet/core/blob/master/release-notes/5.0/5.0-supported-os.md Neither 3.1 nor 5.0 support arm musl.

Use clang-9 for linux-musl-arm64
Generalize -clang* options
@sdmaclea
sdmaclea merged commit 1105ce9 into dotnet:master Apr 10, 2020
@sdmaclea
sdmaclea deleted the AlpineArm64 branch April 10, 2020 22:50
sdmaclea added a commit that referenced this pull request Apr 22, 2020
* Enable Alpine Arm64 SOS builds

* Revise clang version selection

Use clang-9 for linux-musl-arm64
Generalize -clang* options

Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com>
sdmaclea added a commit that referenced this pull request Apr 22, 2020
* Enable Alpine Arm64 SOS builds

* Revise clang version selection

Use clang-9 for linux-musl-arm64
Generalize -clang* options

Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com>
mikem8361 pushed a commit to mikem8361/diagnostics that referenced this pull request Apr 23, 2020
* Enable Alpine Arm64 SOS builds

* Revise clang version selection

Use clang-9 for linux-musl-arm64
Generalize -clang* options

Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add arm64 alpine SOS build

3 participants