Skip to content

Update clrmd to fix dotnet-dump module enum perf. - #1048

Merged
1 commit merged into
dotnet:masterfrom
mikem8361:clrmdupdate
Apr 21, 2020
Merged

1 commit merged into
dotnet:masterfrom
mikem8361:clrmdupdate

Conversation

@mikem8361

Copy link
Copy Markdown
Contributor

Add assembly version to clrmodules -v command.

Add more info to dumpmodule.

Update clrmd to version 1.1.122004. See PR microsoft/clrmd#609 for details.

Add assembly version to clrmodules -v command.

Add more info to dumpmodule.

Update clrmd to version 1.1.122004. See PR microsoft/clrmd#609 for details.
@mikem8361
mikem8361 requested a review from hoyosjs April 21, 2020 01:19
@mikem8361 mikem8361 self-assigned this Apr 21, 2020
@mikem8361 mikem8361 added the auto-merge Automatically merge PR once CI passes. label Apr 21, 2020
@ghost

ghost commented Apr 21, 2020

Copy link
Copy Markdown

Hello @mikem8361!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@hoyosjs hoyosjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we OK with cdecl on Linux? Normally COM required stdcall, but I'm not sure how that applies to our usage of in SOS. I assume we setup the frames ourselves with loadlibrary + getprocaddress or dlopen and call an export?

@ghost
ghost merged commit d96440c into dotnet:master Apr 21, 2020
@mikem8361

mikem8361 commented Apr 21, 2020 via email

Copy link
Copy Markdown
Contributor Author

@mikem8361
mikem8361 deleted the clrmdupdate branch April 22, 2020 23:11
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 19, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto-merge Automatically merge PR once CI passes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants