Repository navigation
Update clrmd to fix dotnet-dump module enum perf. - #1048
Merged
1 commit merged intoApr 21, 2020
Merged
1 commit merged into
1 commit merged into
Conversation
Add assembly version to clrmodules -v command. Add more info to dumpmodule. Update clrmd to version 1.1.122004. See PR microsoft/clrmd#609 for details.
|
Hello @mikem8361! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
hoyosjs
reviewed
Apr 21, 2020
hoyosjs
left a comment
Member
There was a problem hiding this comment.
Are we OK with cdecl on Linux? Normally COM required stdcall, but I'm not sure how that applies to our usage of in SOS. I assume we setup the frames ourselves with loadlibrary + getprocaddress or dlopen and call an export?
hoyosjs
approved these changes
Apr 21, 2020
Contributor
Author
|
The clrmd interop only supports CallingConvention.Winapi (or no attribute/default) now because it works best across all architectures (mainly Linux x86).
|Winapi|This member is not actually a calling convention, but instead uses the default platform calling convention. For example, on Windows x86 the default is StdCall and on Linux x86 it is Cdecl.|
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add assembly version to clrmodules -v command.
Add more info to dumpmodule.
Update clrmd to version 1.1.122004. See PR microsoft/clrmd#609 for details.