Skip to content

Simplify dotnet-trace main loop - #1257

Merged
11 commits merged into
dotnet:masterfrom
josalem:dev/josalem/dotnet-trace-copytoasync
Jul 27, 2020
Merged

11 commits merged into
dotnet:masterfrom
josalem:dev/josalem/dotnet-trace-copytoasync

Conversation

@josalem

@josalem josalem commented Jun 18, 2020 •

Copy link
Copy Markdown
Contributor
  • Uses Stream.CopyToAsync instead of manually copying bytes using Stream.Read and Stream.Write
  • Simplifies try/catch blocks
  • Improves rendering of console text due to ordering of the new loop
  • Removes need for polling in the UI thread, which greatly simplifies code
  • Removes the console clear since the rendering is cleaner now
  • removes hasConsole to allow for redirection of input and output

@josalem josalem added this to the 5.0 milestone Jun 18, 2020
@josalem
josalem requested review from hoyosjs and sywhang June 18, 2020 02:02
@josalem josalem self-assigned this Jun 18, 2020

@sywhang sywhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josalem

josalem commented Jun 19, 2020

Copy link
Copy Markdown
Contributor Author

I've found some oddities in the printing when it reaches the end of a terminal buffer. Let me sort these out before we merge this.

John Salem added 2 commits June 29, 2020 17:07
* timer could cause interleved output
* needs to be checked on Windows terminal
@josalem
josalem requested a review from sywhang July 21, 2020 17:28

@sywhang sywhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits but LGTM

@josalem josalem added the auto-merge Automatically merge PR once CI passes. label Jul 24, 2020
@ghost

ghost commented Jul 24, 2020

Copy link
Copy Markdown

Hello @josalem!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
ghost merged commit 584624c into dotnet:master Jul 27, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 17, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto-merge Automatically merge PR once CI passes. dotnet-trace

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants