Repository navigation
Simplify dotnet-trace main loop - #1257
Merged
11 commits merged intoJul 27, 2020
Merged
11 commits merged into
11 commits merged into
Conversation
added 2 commits
June 17, 2020 18:53
Contributor
Author
|
I've found some oddities in the printing when it reaches the end of a terminal buffer. Let me sort these out before we merge this. |
added 2 commits
June 29, 2020 17:07
* timer could cause interleved output
* needs to be checked on Windows terminal
sywhang
approved these changes
Jul 22, 2020
josalem
commented
Jul 24, 2020
|
Hello @josalem! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream.CopyToAsyncinstead of manually copying bytes usingStream.ReadandStream.WritehasConsoleto allow for redirection of input and output